From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 649D71DF254 for ; Tue, 14 Apr 2026 13:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776171760; cv=none; b=LwLvUe8tX3RkOusnP/Z1Oq0j5YWx6/rARkvAyuZpPesU27GqoWNw+LrGUcABInALu5RuXHHyXJILwh8msX70RYHvrvTyzGo1srUrGSEvo96Cint4KH+RkhPNBh7l1GVD/lUG3KQil6Ilt1fBk33uwmD3bOuz2zS1z45QX4N2N2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776171760; c=relaxed/simple; bh=T+bDo2QrsDmzyawj0e7e+J4d7pMFaswH7o6m8bbf4hs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D2f4hGdXLF9l7O144WD5v682745+FjVGflNiohA3pfrsHoWmBEDg9XiTD1sniiVQlXs0Rw+AcKyj7R+ElThEDH6xg8qDOBaH5gSxYYy0ZCtZXJjTghZPCvr8hEP7u97UVWQE4e2nnImnRQhwCrLMK22WYaTDzWPHelc+ObwPOsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ca5FJf3y; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ca5FJf3y" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso86924245e9.3 for ; Tue, 14 Apr 2026 06:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776171758; x=1776776558; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l/ThIx4+xtrxrBR4kGGwtQo3YXjegxw0z+ZYGF/h5Ro=; b=Ca5FJf3yB1+b7vJipBfKXZSqvd9GiI2xzCUoeW0pR2nU3YB3OJ7oTLLAc2fsHnAVbT DQxCmjdQpmSfeL937mSU7RerClLEoJIRjeo6QfPKX/j59l6MMYMI3KdXDIzFAReaFDND kSIQDrPAkxVtzVgS4J0OUOJdXYGt6S720Dp3MTvSQNIn0tdEETUbcQOFkmHEg7f5Cm1b 2K1pyQiQhJF2XWfYzRwwz0oQHvl0kIW4PDrImeLFZd5LoSRnwwAiwwKS+TVU3x7CPAkS 2MMfCfH2saR8K1sy2o6oFadvSorlVu/IB9JP0RHDzlckCr/vcSgg1ZX4OBy0PVbKOE3L ILaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776171758; x=1776776558; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l/ThIx4+xtrxrBR4kGGwtQo3YXjegxw0z+ZYGF/h5Ro=; b=GXNYcbrHZLS9fU3GdivTIvA42V7YShSyzIUIcyCG75+5JkHuvL0xrxImSjSGTMiP59 A41U1wNpsE0FdjbtilylEE9DjR9xYzU50zRnb5Ur6eflED+QStivvI9QaOeD4Y1OGNMr nVyIg3abKWL1gIWPi0f4AcOIrm64UIAq6iaBCY/r5uweJ8DwubuLbVCTOzpXn+Uas3Pf BEPPzkBL5IuGJILzwgf48BroF+VoraP6MBTKjMsbMUzjeczBa+An5DV5VVSwZ6SlgXID ieeW5SxN5C42mpYFHuG7uR5kC1fHPbqbuUiDmF7121Hg9eSBTwDodzrDzQOMtJz25XiV uWmA== X-Forwarded-Encrypted: i=1; AFNElJ/btgfVKbgEgPof5YDJ7jPe3+bMPidD3MLxfPDr1l14sBmAv/bvbM4TGbk3IsO9mmDup+15/b2ZPrpdoSU=@vger.kernel.org X-Gm-Message-State: AOJu0YzXKH/ddqwL7Vonk0iMfmQFWDjc8md1NUoNIbhwrCE+iSir4j3V 1Zj7ADIVjfFovKK7W9PrV/wEbl+RCkj7M6jJFdRXVf9/bVQoJYgSzgBI X-Gm-Gg: AeBDieuvt4x00TNO7K5Wy4XgHSZsqaAqol6aF56UE/Wo9BiM54YQhz4iYQcUPqaROZX +EwG2b1UUV1f2KlzkBVOZI/S9e9YPS/BtIK5qNFyVc1xLepz+MeeQgetg1T2bbcZcu54pEvTObt sPw8grIQ0H03wr0LApGMF7uj+3+Gd02qsx7JWf4RcMoucoig0lA0QekPy1qtOoJciGaSLY9hmt4 sz4ntHBpZZKj42KCBXA2lCbKUqIqsiBwgoc3J5yuURdFXjkKXUo8Qik/UZ/FxDX1y8NDvddJmmU 0reYVn7BuYbchY2Z7b85fHKBDwVZPO8Y9x5lp2ZuMneiKHonCHVGuKJVGUZWJOSiW54rCYthhbo 8DKkMOeYaaC2IeH1+rEVUxLD0hI0FKLZYRStbkeP3A5bBrGBsBxXoPZ63pVu4OmasnR11OrPpxx rO38X45Zua8Ip4ymemNRAg5vxEKLw7VyJW0k0Z X-Received: by 2002:a05:600c:a311:b0:483:7903:c3b1 with SMTP id 5b1f17b1804b1-488d68607fbmr176523385e9.20.1776171757537; Tue, 14 Apr 2026 06:02:37 -0700 (PDT) Received: from localhost (hf33.n1.ips.mtn.co.ug. [41.210.143.51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d5d97c65sm122528565e9.6.2026.04.14.06.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 06:02:35 -0700 (PDT) Date: Tue, 14 Apr 2026 16:02:30 +0300 From: Dan Carpenter To: Andy Shevchenko Cc: Joshua Crofts , lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] iio: frequency: ad9832: simplify bitwise math Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 14, 2026 at 03:33:52PM +0300, Andy Shevchenko wrote: > On Tue, Apr 14, 2026 at 12:45:31PM +0200, Joshua Crofts wrote: > > On Tue, 14 Apr 2026 at 11:57, Andy Shevchenko > > wrote: > > > It's up to you. (u64) casting here is not bad per se. And it's more robust > > > against changes in the second operand the type of which is hidden currently. > > > (Reading again what I just wrote, it seems I objecting my own suggestion!) > > > If I'm not mistaken, the compiler would always do a type promotion of the > > "smaller" operand (in this case fout). By casting at this point we're just doing > > the work for it, so I guess it doesn't matter. > > Yes, and the problem here that BIT_ULL() is (semi)hidden on what it returns for > smaller values. There is no way we'd implement a BIT_ULL() that doesn't give you a ULL. regards, dan carpenter