From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A22D2E54A3 for ; Tue, 14 Apr 2026 09:29:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776158985; cv=none; b=bI2NpLbMzXPDe6wedjcng+Z6jGKQM8zfK/Pty7zR9/LY9cr6VyVVlu5j4osdyXw0r2STcditwYhiZY1Hn0L77sL46cyavod1GrHMf6nOKt1j0vCK3hGvgtFsMQNZXc4UBN2VwvzyecdjMzaW6liZx34jswTpMVsRxpLAeFuXrDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776158985; c=relaxed/simple; bh=6WrYkMkWX7cyrbQo3P9Jza58hYr53iV1mLC4z09wV2g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R5PW95SNr8WY53A0DdRznT/X4T5joFa/sDS8SMwBu5Da9DMHYv60zP+8h8ouONzFasHRnQ88WQGP/Liz3mF/2wDOM0OksK7EQPu6ZvZfqaIXhKeip0irjipNfLNq0gSIUOl33If4LC0wB+cYB8SvhhQf62wy5aeu916bjl1dToU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qsV9QK6V; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qsV9QK6V" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-482f454be5bso56336525e9.0 for ; Tue, 14 Apr 2026 02:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776158983; x=1776763783; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gl3Qvsd1K65hGxW/TqznDU9B0KdcLly7K4NHEh+ehGI=; b=qsV9QK6VL/rJMOMnPQrRgcJUH0tWqDpnRTyaeREmEZknThgBiXp8p9NEBjNUteQEVR Rdo9PnREWnURU8QnQw4rlH77kWPPP79cFk/UgZqM2DAoHo6KHj4fvprBzSKn1GHt69+l bXohyEWNlondAgoWUP2Moc6rNjU3giXQIw6Rfiu4whOOgfOszIoKK2nTXhc5wFnMnWfe tep6/XB5BoY5sCqaM4tnlDK1tX7iGofiIIGP116IfeeqaGWmZVWGXNjFCS7bvIUvppNc crHkJYL2j8zaPoeKEFpz44zvjo13utsXEypOw3pHE2TLlLf1wX0wn87KY9TazGHB1JHu 1psw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776158983; x=1776763783; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gl3Qvsd1K65hGxW/TqznDU9B0KdcLly7K4NHEh+ehGI=; b=VeDkKyR9QWiJFZ+abI12+P3FPiKS31Jj9/ZfKTUd3QY6FpqiTWN2PCWL0ACyh9CuDn DAAD2Unn5/dftAGFCCe6HtaF5Q8Xl+Dir6iyB1UAoAiK68/BUIguGUbRuExBTt9IAiPZ 48eDRMU245shgUVLdSNbdo7iUiYdmqzeh+NbYehfiNMOHW5smhE8x42J0Z3MItO2Xk1U VSHUjwaPDxm4nXnACl4IYQM9ehgzgltv/oDp+dLbb0YwN0LACefIeEW8N9DzWTOiyMgL 7UNR/nMhKwBlsZR1bPVgzQ1B76O45Nwr3IfogZVBhWOvcTTe2oNJGfYnfj2jP8QiFYDV T6VA== X-Forwarded-Encrypted: i=1; AFNElJ8SfXslHRzGM3mVRKNC9U9dYKrPmDxIg1CsGGUlPj4dcxkRVzj+E0VBxPi4kgEflpkmg1FsE6f/ySKbRcI=@vger.kernel.org X-Gm-Message-State: AOJu0YwQLWzRkN1at3ddpoBfRNSzNYCtnV0fEAdi1a8v1Aqahal95Sxz E3zNIGAPlPaQZ+kZY9X9fuuGQCCkeZLs46NIu80poAxWA8L+HaFr17Yq X-Gm-Gg: AeBDieti4fnHMZ+nMy52jJdS3vCv8XmObOpf9IDkGvx0Eqi09EGuCROy4frV4mCSZ6u sP8eGZBjK2Fr6cfqqOlbG4d10K/uowXwVhe+aKkyjMCWrhnE+KfPWXN9Q09KjrZZUTIelGyx7to CqSknnSqoPGrDpOaSQw+1r2QhY0LdGpSkzA1RhHE+hqjZ1oq2XaUUmCanSLScr/a5gJiV/KYcZA qEuwy7Y01vkfK15EDCtS4wEqv6neC5STvHFOx3TM2S/KJfJRWDixrEJZJRwmGPqcZSZNsl+LPx6 lPJzrJZrXmbX1UZCtyhp8jxQls6+kQUwrGOELl/15iX98IZFMRt02SwgsIjYVwgtxGE6ih4VwTD 1AtX8Xdd4AKqEhGw6wEYJd61MYQtQq7tkKQBLI01l7+ylRNEFpfhOrp0gH44xrH1H7eeawwEcIJ QKtaqIugCUQfzlBIc2p/JLeU1ShHM= X-Received: by 2002:a05:600c:4847:b0:487:1ed:6bf4 with SMTP id 5b1f17b1804b1-488cd4f08a1mr186437495e9.3.1776158982838; Tue, 14 Apr 2026 02:29:42 -0700 (PDT) Received: from localhost ([41.210.143.51]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d762decf6sm27762073f8f.8.2026.04.14.02.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:29:42 -0700 (PDT) Date: Tue, 14 Apr 2026 12:09:38 +0300 From: Dan Carpenter To: Andy Shevchenko Cc: Shyam Sunder Reddy Padira , gregkh@linuxfoundation.org, ethantidmore06@gmail.com, nayana.mariyappa@gmail.com, s9430939@naver.com, kees@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: rtl8723bs: os_dep: avoid NULL pointer dereference in rtw_cbuf_alloc Message-ID: References: <20260413224417.5674-2-shyamsunderreddypadira@gmail.com> <20260414071308.4781-2-shyamsunderreddypadira@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 14, 2026 at 11:44:18AM +0300, Andy Shevchenko wrote: > On Tue, Apr 14, 2026 at 11:33:22AM +0300, Dan Carpenter wrote: > > Really _obj() can't be ZERO_SIZE_PTR either, or if they are then it's > > very difficult to dereference them since they don't have any struct > > members. > > > > The main way that ZERO_SIZE_PTR bugs show up is with strings and NUL > > terminators. > > Wouldn't it be the problem for > > struct foo { > u32 baz[]; > }; There isn't really any difference between doing an out of bounds access on an array with zero elements vs 10 elements. That's the beauty of the ZERO_SIZE_PTR is that it lets you treat zero as just another number of elements. But zero sizes can cause problems for code which does things like "size - 1" but because of signedness that's ULONG_MAX. regards, dan carpenter