From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21FD03D4126 for ; Tue, 14 Apr 2026 10:15:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776161751; cv=none; b=JKGT0nvqdyN00SpdsqpCZn0x0dTtGgmhc/pOydN8yTR5Yr1SxFA4HkUVKQqYor4iqbQgCqxeggffAYuRUiev6i8A6iVNF2fxrqfUSwfKFDcq7qFdxof49neBiogwFdjnwEdD3N4t+lDTovN/39X75IEsi0uEipXy/+cfE/QzjqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776161751; c=relaxed/simple; bh=EZFTJMKcrqiZC6dkU5fpiW8Qoxn1WiPO5DZe3A7zqYA=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U8CV5F2qkeeX0bBBOEkKzky9+2Qv3la2UkBVGi2v5lcqE6bNFa4Ci5jZaUeRYcpPpgTh/I4qS05YoEUFzB2pUFnnXTwH7790O/phzy3jSlPWWCfspvKaub3CZ68IlRl4+fBvIIF1rv+Lmrb1iV3XSNl76wnI6CYwsN5jSPvv0Ok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nSM7sRz5; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nSM7sRz5" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488a8ca4aadso63112095e9.3 for ; Tue, 14 Apr 2026 03:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776161746; x=1776766546; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RCAdQQYTWgc6G+kBIPkvatkt1LtP91HaA3fA5VOFl5A=; b=nSM7sRz5YrION0hNmVhILt8wNdH4f7dgL8M/fIITvSjEEbzgZCZ8ctSJ3UHSIIifC4 OtOhxiMOW+E0QFbKBkwhjyf1saC0xRXTA9negpqYaWDYWNuT24WC9m22AKfoRTmrXkWd Tf+yNPDlBeFv9F9EG6ObN+hEZt8/YDGIzeneQonJ7i3iNf/K8XQkZ2OfPkzZ6clP4nFc Nw/KOgtI2mlDsTWSmoW11qViUM2Fcbg3D8oTLSylQUwT2ZUb6YhEw0NE1Jj2EYqU+IDm 26JebRMgk0Q/We6lMPRmjxgMC7OQWm2YWzyTQMcrwZ9Xu3mhcfyTW+TjziSpA4kiXEX/ /Pgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776161746; x=1776766546; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RCAdQQYTWgc6G+kBIPkvatkt1LtP91HaA3fA5VOFl5A=; b=pBteHZHSfJapIxPzvRAYJ2Ofae/qCTvngPbxTpW8q+GDwiGJKrjZo4ROpLoqmazsx4 oUBlmbeDJgrBRttz1QC0jo1Z+WhyfQYjNtZFsfCH+qV9xpeeBXy4/O5wYTKis74YEQ0N dh2uZy4TWBTqUszqGmQpkIr3EFxsTG27j7sjgu1vrPufo+l2JUEtmybNPf5GA0uP+7Az Vf4nQaPjhWYMXgFHYUp9d4VmjWiq1emHYKwlFeTdUX8F743p0Kc4RdJci+Xf4/rM4Ytn LVq2mo9hwiDKOq0yuNq8qb0CwTN5lDGAnE7YgihoZJOlYzvXobVlP7URjPv9SbKb1GNL YPcg== X-Forwarded-Encrypted: i=1; AFNElJ/RRCGQQwsWnBweralvl/nf+Kbj6zO5ZfkwgQrYGOJsrMpeH3DPNNvO/fILFs8QcFGoptLH2wY0Kp+KyaY=@vger.kernel.org X-Gm-Message-State: AOJu0YxLcl8JDL6ufb4oucs6VymX6Sc4nrv8Af1whnDefe29i3K201T/ VDRn+Dp2R4yPhiilePagXRoxSvjktPOxGOCLYspqryXRL6qasZXEvlDI X-Gm-Gg: AeBDievORLJg85sU5pNFYlfDwBPzj7mPuK93kP2Kt4nL/tuj9kyfhGnx04RJVIv248Q 0kvvq1Pfa1IVW+Yhwg2nV72KH3+pPJTWvwAr2acra5WVgXYV+Bc+8/7SnUsFE6vK2ze1wcgQX1o fwCTTEOacCUBq5khqCUnO6z0oBmfwFHP1uWqgrJ9z5hcFPvNIN1ctx2DtHQHq54165q7Q2TbUKp wtr7A6Ad9E/p7Yzwaq4fCxyV66KLKKBMoMJK4DqfMzPsYU1GVx3K/5UbXYGhMX5PCXy0fWChnLP TTdeAHiz6/NhreWe5+s+OYWSNVMDRMg+Iamm/Xy7s0m9vP2PPFjFwVC88F15t10BkNqmPBdZwUb tk7GdWBl3QgS36ysaAut88se4P0qwvHBhQjWYmZydt6hssmq3r6nnik7Pvluwep9CfZUMCG8bM7 rsodIdsWlYb2+rR13qcfMt7pF2ugmcN/1z7f9muRtS+N+DGkdAYPp9jXOSiw== X-Received: by 2002:a05:6000:240f:b0:43d:77f4:714e with SMTP id ffacd0b85a97d-43d77f4749fmr12143895f8f.48.1776161745939; Tue, 14 Apr 2026 03:15:45 -0700 (PDT) Received: from osama ([2a02:908:1b6:8980:1aaa:ede0:d93f:dcaa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e46a85sm40627273f8f.24.2026.04.14.03.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 03:15:45 -0700 (PDT) Date: Tue, 14 Apr 2026 12:15:43 +0200 From: Osama Abdelkader To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Vladimir Kondratiev , Thomas Gleixner , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] riscv: panic if IRQ handler stacks cannot be allocated Message-ID: References: <20260404185522.21767-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260404185522.21767-1-osama.abdelkader@gmail.com> On Sat, Apr 04, 2026 at 08:55:20PM +0200, Osama Abdelkader wrote: > init_irq_stacks() and init_irq_scs() may fail when arch_alloc_vmap_stack > or scs_alloc return NULL, call panic() in this case. > > Signed-off-by: Osama Abdelkader > --- > v2: > - call panic() in place instead of return -ENOMEM > --- > arch/riscv/kernel/irq.c | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c > index b6af20bc300f..017d42e778be 100644 > --- a/arch/riscv/kernel/irq.c > +++ b/arch/riscv/kernel/irq.c > @@ -75,28 +75,34 @@ DECLARE_PER_CPU(ulong *, irq_shadow_call_stack_ptr); > DEFINE_PER_CPU(ulong *, irq_shadow_call_stack_ptr); > #endif > > -static void init_irq_scs(void) > +static void __init init_irq_scs(void) > { > int cpu; > + void *s; > > if (!scs_is_enabled()) > return; > > - for_each_possible_cpu(cpu) > - per_cpu(irq_shadow_call_stack_ptr, cpu) = > - scs_alloc(cpu_to_node(cpu)); > + for_each_possible_cpu(cpu) { > + s = scs_alloc(cpu_to_node(cpu)); > + if (!s) > + panic("Failed to allocate IRQ shadow call stack resources\n"); > + per_cpu(irq_shadow_call_stack_ptr, cpu) = s; > + } > } > > DEFINE_PER_CPU(ulong *, irq_stack_ptr); > > #ifdef CONFIG_VMAP_STACK > -static void init_irq_stacks(void) > +static void __init init_irq_stacks(void) > { > int cpu; > ulong *p; > > for_each_possible_cpu(cpu) { > p = arch_alloc_vmap_stack(IRQ_STACK_SIZE, cpu_to_node(cpu)); > + if (!p) > + panic("Failed to allocate IRQ stack resources\n"); > per_cpu(irq_stack_ptr, cpu) = p; > } > } > @@ -104,7 +110,7 @@ static void init_irq_stacks(void) > /* irq stack only needs to be 16 byte aligned - not IRQ_STACK_SIZE aligned. */ > DEFINE_PER_CPU_ALIGNED(ulong [IRQ_STACK_SIZE/sizeof(ulong)], irq_stack); > > -static void init_irq_stacks(void) > +static void __init init_irq_stacks(void) > { > int cpu; > > @@ -129,8 +135,8 @@ void do_softirq_own_stack(void) > #endif /* CONFIG_SOFTIRQ_ON_OWN_STACK */ > > #else > -static void init_irq_scs(void) {} > -static void init_irq_stacks(void) {} > +static void __init init_irq_scs(void) {} > +static void __init init_irq_stacks(void) {} > #endif /* CONFIG_IRQ_STACKS */ > > int arch_show_interrupts(struct seq_file *p, int prec) > -- > 2.43.0 > Hi All, Can you please review? Best regards, Osama