From: Krzysztof Kozlowski <krzk@kernel.org>
To: Renjiang Han <quic_renjiang@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_qiweil@quicinc.com
Subject: Re: [PATCH v3 1/4] dt-bindings: qcom,qcs615-venus: add support for video hardware
Date: Tue, 26 Nov 2024 11:07:21 +0100 [thread overview]
Message-ID: <ad5893a8-d84a-4b36-bf89-08203bba726a@kernel.org> (raw)
In-Reply-To: <26353cfa-5c74-4b80-933d-f719b0d4f738@quicinc.com>
On 26/11/2024 10:58, Renjiang Han wrote:
>
> On 11/26/2024 5:34 PM, Krzysztof Kozlowski wrote:
>> On 26/11/2024 09:57, Renjiang Han wrote:
>>>>> +description:
>>>>> + The Venus IP is a video encode and decode accelerator present
>>>>> + on Qualcomm platforms
>>>>> +
>>>>> +allOf:
>>>>> + - $ref: qcom,venus-common.yaml#
>>>>> +
>>>>> +properties:
>>>>> + compatible:
>>>>> + const: qcom,qcs615-venus
>>>> Please extend sc7180-venus.yaml instead. No need to duplicate
>>>> unnecessary things.
>>> Thanks for your review. But I'm sorry I can't get it. The devicetree for
>>>
>>> qcs615-venus is in qcs615.dtsi. I'm not sure how to use sc7180-venus.yaml
>>>
>>> instead.
>> DTSI is not relevant here to the bindings. I don't understand the
>> problem, so not sure what you are asking here about.
> The opp-table parameters are different in devicetree. Can we also use
> the same yaml file?
Please look at existing bindings for other devices.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-26 10:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 5:34 [PATCH v3 0/4] media: venus: enable venus on qcs615 Renjiang Han
2024-11-25 5:34 ` [PATCH v3 1/4] dt-bindings: qcom,qcs615-venus: add support for video hardware Renjiang Han
2024-11-25 6:37 ` Rob Herring (Arm)
2024-11-25 8:06 ` Renjiang Han (QUIC)
2024-11-25 8:16 ` Krzysztof Kozlowski
2024-11-25 7:50 ` Krzysztof Kozlowski
2024-11-25 15:49 ` Renjiang Han (QUIC)
2024-11-25 15:55 ` Krzysztof Kozlowski
2024-11-26 6:07 ` Renjiang Han
2024-11-26 6:42 ` Krzysztof Kozlowski
2024-11-26 9:39 ` Renjiang Han
2024-11-26 9:42 ` Krzysztof Kozlowski
2024-11-25 16:12 ` Dmitry Baryshkov
2024-11-26 8:57 ` Renjiang Han
2024-11-26 9:34 ` Krzysztof Kozlowski
2024-11-26 9:58 ` Renjiang Han
2024-11-26 10:07 ` Krzysztof Kozlowski [this message]
2024-11-26 12:00 ` Dmitry Baryshkov
2024-11-27 8:09 ` Vikash Garodia
2024-11-25 5:34 ` [PATCH v3 2/4] media: venus: core: add qcs615 platform data Renjiang Han
2024-11-25 8:44 ` Renjiang Han (QUIC)
2024-11-25 8:56 ` Krzysztof Kozlowski
2024-11-25 9:06 ` Renjiang Han (QUIC)
2024-11-25 13:35 ` Dmitry Baryshkov
2024-11-25 15:34 ` Renjiang Han (QUIC)
2024-11-25 16:20 ` Dmitry Baryshkov
2024-11-26 7:40 ` Renjiang Han
2024-11-26 12:03 ` Dmitry Baryshkov
2024-11-27 8:07 ` Vikash Garodia
2024-11-25 5:34 ` [PATCH v3 3/4] arm64: dts: qcom: add venus node for the qcs615 Renjiang Han
2024-11-25 8:50 ` Renjiang Han (QUIC)
2024-11-30 22:00 ` Bryan O'Donoghue
2024-11-30 13:34 ` Konrad Dybcio
2024-11-25 5:34 ` [PATCH v3 4/4] arm64: dts: qcom: qcs615-ride: enable venus node Renjiang Han
2024-11-25 8:53 ` Renjiang Han (QUIC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad5893a8-d84a-4b36-bf89-08203bba726a@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_qiweil@quicinc.com \
--cc=quic_renjiang@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox