From: Md Sadre Alam <quic_mdalam@quicinc.com>
To: <thara.gopinath@gmail.com>, <herbert@gondor.apana.org.au>,
<davem@davemloft.net>, <vkoul@kernel.org>, <kees@kernel.org>,
<robin.murphy@arm.com>, <fenghua.yu@intel.com>,
<av2082000@gmail.com>, <u.kleine-koenig@pengutronix.d>,
<linux-crypto@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <dmaengine@vger.kernel.org>,
<quic_varada@quicinc.com>, <quic_srichara@quicinc.com>
Subject: Re: [PATCH v4 00/11] dmaengine: qcom: bam_dma: add cmd descriptor support
Date: Wed, 20 Nov 2024 12:45:14 +0530 [thread overview]
Message-ID: <ad5dcd6c-1dbf-d682-024a-d4093611388f@quicinc.com> (raw)
In-Reply-To: <20240909092632.2776160-1-quic_mdalam@quicinc.com>
On 9/9/2024 2:56 PM, Md Sadre Alam wrote:
> Requirements:
> In QCE crypto driver we are accessing the crypto engine registers
> directly via CPU read/write. Trust Zone could possibly to perform some
> crypto operations simultaneously, a race condition will be created and
> this could result in undefined behavior.
>
> To avoid this behavior we need to use BAM HW LOCK/UNLOCK feature on BAM
> pipes, and this LOCK/UNLOCK will be set via sending a command descriptor,
> where the HLOS/TZ QCE crypto driver prepares a command descriptor with a
> dummy write operation on one of the QCE crypto engine register and pass
> the LOCK/UNLOCK flag along with it.
>
> This feature tested with tcrypt.ko and "libkcapi" with all the AES
> algorithm supported by QCE crypto engine. Tested on IPQ9574 and
> qcm6490.LE chipset.
Hi,
Could you please provide feedback for this patch series.
Thanks
Alam.
prev parent reply other threads:[~2024-11-20 7:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 9:26 [PATCH v4 00/11] dmaengine: qcom: bam_dma: add cmd descriptor support Md Sadre Alam
2024-09-09 9:26 ` [PATCH v4 01/11] dmaengine: qcom: bam_dma: Add bam_sw_version register read Md Sadre Alam
2024-09-09 9:26 ` [PATCH v4 02/11] dmaengine: qcom: bam_dma: add LOCK & UNLOCK flag support Md Sadre Alam
2024-12-04 12:45 ` Vinod Koul
2024-12-09 5:38 ` Md Sadre Alam
2024-09-09 9:26 ` [PATCH v4 03/11] crypto: qce - Add support for crypto address read Md Sadre Alam
2024-09-09 9:26 ` [PATCH v4 04/11] crypto: qce - Add bam dma support for crypto register r/w Md Sadre Alam
2024-09-09 9:26 ` [PATCH v4 05/11] crypto: qce - Convert register r/w for skcipher via BAM/DMA Md Sadre Alam
2024-09-09 9:26 ` [PATCH v4 06/11] crypto: qce - Convert register r/w for sha " Md Sadre Alam
2024-09-09 9:26 ` [PATCH v4 07/11] crypto: qce - Convert register r/w for aead " Md Sadre Alam
2024-09-09 9:26 ` [PATCH v4 08/11] crypto: qce - Add LOCK and UNLOCK flag support Md Sadre Alam
2024-09-09 9:26 ` [PATCH v4 09/11] crypto: qce - Add support for lock/unlock in skcipher Md Sadre Alam
2024-09-09 9:26 ` [PATCH v4 10/11] crypto: qce - Add support for lock/unlock in sha Md Sadre Alam
2024-09-09 9:26 ` [PATCH v4 11/11] crypto: qce - Add support for lock/unlock in aead Md Sadre Alam
2024-11-20 7:15 ` Md Sadre Alam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad5dcd6c-1dbf-d682-024a-d4093611388f@quicinc.com \
--to=quic_mdalam@quicinc.com \
--cc=av2082000@gmail.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=kees@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robin.murphy@arm.com \
--cc=thara.gopinath@gmail.com \
--cc=u.kleine-koenig@pengutronix.d \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox