From: Shannon Nelson <shannon.nelson@oracle.com>
To: David Miller <davem@davemloft.net>, stephen@networkplumber.org
Cc: netdev@vger.kernel.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support
Date: Mon, 13 Feb 2017 09:15:17 -0800 [thread overview]
Message-ID: <ad602c10-c5da-0378-98f9-b73106803c45@oracle.com> (raw)
In-Reply-To: <20170211.210101.1450332574457722492.davem@davemloft.net>
On 2/11/2017 6:01 PM, David Miller wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Fri, 10 Feb 2017 16:22:08 -0800
>
>> On Fri, 10 Feb 2017 09:38:20 -0800
>> Shannon Nelson <shannon.nelson@oracle.com> wrote:
>>
>>> +static void vsw_get_ethtool_stats(struct net_device *dev,
>>> + struct ethtool_stats *estats, u64 *data)
>>> +{
>>> + int i = 0;
>>> +
>>> + data[i++] = dev->stats.rx_packets;
>>> + data[i++] = dev->stats.tx_packets;
>>> + data[i++] = dev->stats.rx_bytes;
>>> + data[i++] = dev->stats.tx_bytes;
>>> + data[i++] = dev->stats.rx_errors;
>>> + data[i++] = dev->stats.tx_errors;
>>> + data[i++] = dev->stats.rx_dropped;
>>> + data[i++] = dev->stats.tx_dropped;
>>> + data[i++] = dev->stats.multicast;
>>
>> Please do not duplicate regular network statistics into ethtool.
>> This doesn't really add any value.
>
> Agreed.
>
Okay, I'll drop this patch.
sln
next prev parent reply other threads:[~2017-02-13 17:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 17:38 [PATCH v3 net-next 0/9] sunvnet driver updates Shannon Nelson
2017-02-10 17:38 ` [PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable Shannon Nelson
2017-02-12 11:16 ` Sergei Shtylyov
2017-02-13 17:16 ` Shannon Nelson
2017-02-10 17:38 ` [PATCH v3 net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup Shannon Nelson
2017-02-10 17:38 ` [PATCH v3 net-next 3/9] sunvnet: update version and version printing Shannon Nelson
2017-02-10 17:38 ` [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support Shannon Nelson
2017-02-11 0:22 ` Stephen Hemminger
2017-02-12 2:01 ` David Miller
2017-02-13 17:15 ` Shannon Nelson [this message]
2017-02-10 17:38 ` [PATCH v3 net-next 5/9] sunvnet: add memory barrier before check for tx enable Shannon Nelson
2017-02-10 17:38 ` [PATCH v3 net-next 6/9] sunvnet: straighten up message event handling logic Shannon Nelson
2017-02-10 17:38 ` [PATCH v3 net-next 7/9] sunvnet: remove extra rcu_read_unlocks Shannon Nelson
2017-02-10 17:38 ` [PATCH v3 net-next 8/9] ldmvsw: update and simplify version string Shannon Nelson
2017-02-10 17:38 ` [PATCH v3 net-next 9/9] ldmvsw: disable tso and gso for bridge operations Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad602c10-c5da-0378-98f9-b73106803c45@oracle.com \
--to=shannon.nelson@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).