From: Shuah Khan <skhan@linuxfoundation.org>
To: Abhishek Tamboli <abhishektamboli9@gmail.com>,
perex@perex.cz, tiwai@suse.com
Cc: kailang@realtek.com, sbinding@opensource.cirrus.com,
simont@opensource.cirrus.com, josh@joshuagrisham.com,
foss@athaariq.my.id, rf@opensource.cirrus.com,
rbmarliere@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] ALSA: hda/realtek: Add a quirk for HP Pavilion 15z-ec200
Date: Thu, 26 Sep 2024 10:12:03 -0600 [thread overview]
Message-ID: <ad6b7073-4fcf-41f9-b6ff-e01bf7089017@linuxfoundation.org> (raw)
In-Reply-To: <20240926155112.8079-1-abhishektamboli9@gmail.com>
On 9/26/24 09:51, Abhishek Tamboli wrote:
> Add the quirk for HP Pavilion Gaming laptop 15z-ec200 for
> enabling the mute led. The fix apply the ALC285_FIXUP_HP_MUTE_LED
> quirk for this model.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=219303
Were you able to test this on HP Pavilion Gaming laptop? If so
please add that to the change log.
>
> Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 4ca66234e561..94125a977f08 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10315,6 +10315,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> + SND_PCI_QUIRK(0x103c, 0x88DD, "HP Pavilion 15z-ec200", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
Looks like this has been fixed:
https://lore.kernel.org/lkml/20220918171300.24693-1-dhould3@gmail.com/t/#m0c6aeebe5cc89c9a4228d49f56f4a0a4c516e012
thanks,
-- Shuah
next prev parent reply other threads:[~2024-09-26 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 15:51 [PATCH] ALSA: hda/realtek: Add a quirk for HP Pavilion 15z-ec200 Abhishek Tamboli
2024-09-26 16:12 ` Shuah Khan [this message]
2024-09-28 2:14 ` Abhishek Tamboli
2024-09-30 8:09 ` Takashi Iwai
2024-09-30 14:51 ` Abhishek Tamboli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad6b7073-4fcf-41f9-b6ff-e01bf7089017@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=abhishektamboli9@gmail.com \
--cc=foss@athaariq.my.id \
--cc=josh@joshuagrisham.com \
--cc=kailang@realtek.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rbmarliere@gmail.com \
--cc=rf@opensource.cirrus.com \
--cc=sbinding@opensource.cirrus.com \
--cc=simont@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox