From: Thomas Richard <thomas.richard@bootlin.com>
To: Nishanth Menon <nm@ti.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, m.nirmaladevi@ltts.com,
bhargav.r@ltts.com, lee@kernel.org, linux-kernel@vger.kernel.org,
gregory.clement@bootlin.com, thomas.petazzoni@bootlin.com,
u-kumar1@ti.com
Subject: Re: [PATCH] regulator: tps6594-regulator: Fix the number of irqs for TPS65224 and TPS6594
Date: Mon, 10 Jun 2024 11:48:11 +0200 [thread overview]
Message-ID: <ad6b8caf-0ad6-42da-9324-e4a33a05f0cc@bootlin.com> (raw)
In-Reply-To: <20240604121055.lztvn2wu62qqrla6@maximize>
On 6/4/24 14:10, Nishanth Menon wrote:
> On 19:01-20240603, Thomas Richard wrote:
>> The number of irqs is computed to allocate the right amount of memory for
>> the irq data. An array of struct tps6594_regulator_irq_data is allocated
>> one time for all the irqs. Each irq uses one cell of the array.
>>
>> If the computed number of irqs is not correct, not allocated memory could
>> be used.
>>
>> Fix the values used in the calculation for TPS6594 and TPS65224.
>>
>> Fixes: 00c826525fba (regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators)
>> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
>> ---
>
>
> Thanks a ton for fixing this - this solved a bunch of random regressions
> we were tracking:
> am62axx_sk, am69_sk, j721e-idk, j721s2-evm in addition to J7200 evm as
> well.
>
> Tested-by: Nishanth Menon <nm@ti.com>
>
>
> This was definitely a 6.10 regression, could we fast track it in?
Hi Nishanth,
FYI, I also found an other 6.10 regression for j721s2-evm and j7200-evm:
https://lore.kernel.org/all/20240603082110.2104977-1-thomas.richard@bootlin.com/
Regards,
Thomas
next prev parent reply other threads:[~2024-06-10 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 17:01 [PATCH] regulator: tps6594-regulator: Fix the number of irqs for TPS65224 and TPS6594 Thomas Richard
2024-06-04 12:10 ` Nishanth Menon
2024-06-10 9:48 ` Thomas Richard [this message]
2024-06-04 19:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad6b8caf-0ad6-42da-9324-e4a33a05f0cc@bootlin.com \
--to=thomas.richard@bootlin.com \
--cc=bhargav.r@ltts.com \
--cc=broonie@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.nirmaladevi@ltts.com \
--cc=nm@ti.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox