From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFAB239FD4 for ; Tue, 14 Apr 2026 20:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776197129; cv=none; b=ViOpPWdlfCUOC8YHlJ0CWHDdpQ8EuJcUoJd5VNviyLCwW/vE74B8frbMqZRtKLL5jXWfgKA3FPNEjNWgzYs/RrszoRObJJwcK91hY+w77usm3GuvkydYv/pb5hmZYd2XI5I69kOGektYCbWeJlxhdilT3/4s45+SV93WXxi8iXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776197129; c=relaxed/simple; bh=aATsalV8/1i5L0VFh3YiF/WCOnaKmuUJPAwqHhi9cLM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cDWk8PBZsULt3j1HM/eFLrT9txdL1PkKYjYkEigL0KlqRhSMApQmGK81OzGxZ5avFEYAXG56RZ8CO0IxmzdHIY/M59PMF9p4xZQLawyhMdDErEmMd7yV7Csz+zIUXD5NwBLt42cbOoeK7r5xT1mhyYGJz4O3SrQ43BujR4nkgX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WCIEganP; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=hsFAEeb7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WCIEganP"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="hsFAEeb7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776197127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HT80x0fa49gU1qS9LZMVanLH0BXd2Tg/W3HJgvxGomA=; b=WCIEganPs3ZHtiaBxmD9r25ZS30UnsnRLlMESZXMxnNvU4EPMYe70wqMnjAa1LGxRYY9O8 CPN0jW1Kz+LUUl9Eqjb5bRbB1tGvzaLmYjfSNr34q6zm2MI0zCMZerv4E0f5JpanYXStYN jsqCSlkkCuM18MhhuodamErOY8Zqg4c= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-MjwHYrJ-OR61LQU1_qiqSA-1; Tue, 14 Apr 2026 16:05:25 -0400 X-MC-Unique: MjwHYrJ-OR61LQU1_qiqSA-1 X-Mimecast-MFC-AGG-ID: MjwHYrJ-OR61LQU1_qiqSA_1776197125 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8aca6f796d5so86113886d6.0 for ; Tue, 14 Apr 2026 13:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776197125; x=1776801925; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HT80x0fa49gU1qS9LZMVanLH0BXd2Tg/W3HJgvxGomA=; b=hsFAEeb71FPX7kuYWvXNf1awhqcCZs9utsLMZXUCQEZmEhd8eSKa1Kiuo+DbcTJmDC VMDIChPZ8eiXuERXkH1dzJ6U7v/pGb0jAt+RuLbaYIjQUm/CicyolUltzaQxySAZDWhs gjuc5M+IdlGdupgtBeV/CA9EaGXDU2Ugq07BTCHkdbNX7OXPE+s879M/GTvVbMH9lPLp OVY9+GhBcZKQoG7ltBo91kzy8N6dBhmVmDfs0jFbokyR/Be38R7+A7yudcmjp/XW/aq1 IkfhqUVtuc6l2P/Ixm9md8BIqeBqaXcwFCKH8cmfGPVVmRAtH1xJoxwGlBvMWNZP/HEi 8ygw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776197125; x=1776801925; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HT80x0fa49gU1qS9LZMVanLH0BXd2Tg/W3HJgvxGomA=; b=OaND/GwYbxDZG29JEJJhOBNQV++T3aaZVGcXT3XkcvZvzgBPzxSS8Ewq6RAzfQPu0W QvPT4q98iCHy8yAVwmZ5OP+WIS5WgOAdf6+qCAuzsYg8hDjRXvaK03rdZokBEMmFL4nB tL+Kadzt7lEWV4BS/bdwaiN8KwEBugIzm1dh6nze+iPNZnqK4CtlwboWJAe3F/JxCQM9 LMhesGsaef5eyyiRTNJY5IKhehc4VVmGxAUapQfylRcdTANldjUlNIupnP6vcz3mtUIu +4jsc4b5BXIcFaP5WXiVmiZJXO1O1Ger2OUZ9ESiwU4qV19EJZyrvHGN+O22vnE6pCQE VAng== X-Forwarded-Encrypted: i=1; AFNElJ++F7Wv2UShwpHHCC1gpfG0tiaNh2n+P0fW7+CsM4lOzMsyBz8uMMIkw1YIIyVmKA1B5+VITSOw6fAto+M=@vger.kernel.org X-Gm-Message-State: AOJu0YzHDCzm/17NM8gJ2/g5+fnZHzkqfayFDZJ5FSb1IJ3fPH6+hR+Q XepDfSx18PMX8ToU2ovT3anVFrnZBxE9OPgRe0Bv/ClRR50KjWrzuusnWwHjDoO2Is4IdGwnidw SsLrYR2e2D6HSR15c6A+9tDZm1phZVjudd7Q5XDqvQQISjJg40WBzWoLUGF7uzzni7w== X-Gm-Gg: AeBDiev0/SQwdJlAygRYL8FvNB9LSf87WrC0hHRKJPKh8qxagFslRTkkxsGK7fBYO8P dnWHhu9Tr5yjxo8RJKhNg+n116cYbC38uLcXmjtVbSKobXp9GnP3aqaamm1CseZhJZWIi/lV1Ws HX4MvC68ecTHd+WFiqI/L5RHDhi7nzwsGJTwv5NuzkiMHGfMW8IPLcCl3VdvNgBUKi+i6wzIvaD c89Y4ICeFu0oHwxYdhjNOusQEzh6gAgIyb2Mu7lTwaIxlvL44LaH3WS8Ks8k/9/WPhF1i0y9rlQ 6zuSQ2/cZCB13Ra9CuCVz6skOIqeruWamegrDdgjoyMTQjWke26bwzPOCubTYyIXsqEoV0RaXTi p241M6Ga0eaa9NN6nrvIf X-Received: by 2002:a0c:e001:0:b0:8ac:a546:775f with SMTP id 6a1803df08f44-8aca5467d00mr158065396d6.1.1776197125179; Tue, 14 Apr 2026 13:05:25 -0700 (PDT) X-Received: by 2002:a0c:e001:0:b0:8ac:a546:775f with SMTP id 6a1803df08f44-8aca5467d00mr158064646d6.1.1776197124557; Tue, 14 Apr 2026 13:05:24 -0700 (PDT) Received: from redhat.com ([2600:382:8116:76c6:c5b1:9485:5da8:de42]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ac849dbc0fsm133803046d6.1.2026.04.14.13.05.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 13:05:22 -0700 (PDT) Date: Tue, 14 Apr 2026 16:05:20 -0400 From: Brian Masney To: Guangshuo Li Cc: Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Conor Dooley , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] clk: starfive: jh7110: fix memory leak in jh7110_reset_controller_register() error path Message-ID: References: <20260413143643.3002454-1-lgs201920130244@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.3.1 (2026-03-20) On Tue, Apr 14, 2026 at 07:44:18PM +0800, Guangshuo Li wrote: > Hi Brian, > > Thanks for reviewing. > > On Tue, 14 Apr 2026 at 00:46, Brian Masney wrote: > > > There's actually another leak in the error path for > > auxiliary_device_add(). I think this code should be > > converted to devm_kzalloc(). > > > > There is no devm_kzalloc_obj() yet, however according to [1] that should > > be coming soon. > > > > [1] https://lore.kernel.org/lkml/20260330154108.GA3389518@killaraus.ideasonboard.com/ > > > > Brian > > > > I may be missing something, but I think the auxiliary_device_add() error > path is already handled here: > > ret = auxiliary_device_add(adev); > if (ret) { > auxiliary_device_uninit(adev); > return ret; > } > > The embedded auxiliary_device has: > > adev->dev.release = jh7110_reset_adev_release; > > and the release callback does: You are right. Sorry about that. My original suggestion still applies though to move over to the devm variant since that'll allow you to remove the release callback. Brian