From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE3CC23EAB2 for ; Tue, 14 Apr 2026 20:06:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776197172; cv=none; b=WQHdGSsNOYueiW6BmXt0d7l05DJQkEQEXJBk2NQcEvLABi6iXyx7CUAwl5A5vlhbmt9k2H9mOi2mXjo2/f5nd08NCVebobi1ZOQsi2jgwstixPvVyRYCr4fpVRPWJErXWiYaWsIdQxaY2JYYInavfTF5uzy5OSqRq97O47qrvmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776197172; c=relaxed/simple; bh=Dp0+Ssh1K3boeKKgn5yK72BHQcL+OqEVaNq1MEz8SWU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uL6RfoB0JYI1yQXoNOZJOWr+EKfEime6ZofFnkKxZj5ew9JOgzucW2YTWQzDy3BZd/WMb0Ebyjfc/ENeHQsQ+1+7PF3RCDgvRtnMReD0RczHoC7hyL++qqt2P/NsXBI5486Fjc7HsJuFD08YoppVsmkgSD0uWboxXVZVxMX1fAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DkcUy4pb; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=JwyiF/RQ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DkcUy4pb"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="JwyiF/RQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776197170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AEXRhk5IofRA90cdU2Hp7IbZZuVGkK6cyhq8G9bcFWk=; b=DkcUy4pb5tgwFXc8iOKqGwOQC0aAnyyTNFMD88Ka9rCUFO3mhcOR9kq9mlRBNo2SGdGAkL ShkriHhrTaWHAFxMwR2g4Ebq4LIWJMp6jUFNrYGZ/7X+lE2ceMEhVm9ZkbvYtjFudbHTqD vCOH0UZ9tW5gbIsR6K35TTyBNPZvw0A= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-l09ml8RVP6GNcWWb2K5pTg-1; Tue, 14 Apr 2026 16:06:08 -0400 X-MC-Unique: l09ml8RVP6GNcWWb2K5pTg-1 X-Mimecast-MFC-AGG-ID: l09ml8RVP6GNcWWb2K5pTg_1776197168 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50d9a6a853bso148233631cf.0 for ; Tue, 14 Apr 2026 13:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776197168; x=1776801968; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AEXRhk5IofRA90cdU2Hp7IbZZuVGkK6cyhq8G9bcFWk=; b=JwyiF/RQAkoJ2Xw9Pfcpm03a5bTOYXmTIhLGNZ3pCoDpd0El3Jh1OIp1GxbEtsbKT8 1Fe6GkDEE4HrrYsWFL8n/t5IJe+ekb709W17s8rl8Rao2c+kV1e6WyMRDjOoF5IsPQcV HKFskQvueTb/JxblRKrKBHmxhCMB5xGSHSxmqs6BCBxt1oK20DDfiPIe6KMc54EPa5e4 n2YiQbC7+yhKDFBuy9XZOGZlTF49qYgtP+fp6EwYa7rTHPNifUppNFaIfsaIQqWcgQsE P9f+yASndW4Z3VP9ydQgRNQL34X+1omnvVcZBw2SCcsdW+ZpjlH0SWYEmU+NAZvOqICy sS/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776197168; x=1776801968; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AEXRhk5IofRA90cdU2Hp7IbZZuVGkK6cyhq8G9bcFWk=; b=sOQe1sVFZsHwzhf2gyI9+ICOvcY+QJFppcaSjNA0w9CGV8yKVGiqs0pWvEVDI0kqwt nMVPCbzhp7FjnD+DOK79dvY91+EOXmp0Ppl0TM/SR9SEyyJ7UPtyysOLhZjtCMUuWuSh LlStKPLGbcmP+BCxXhWks+LSDlBfDFQem7rg94C8+b062q8rw7aZzS9lR1qofCxO1Pb1 KVE6GDmEcYF9SEoQsiPvEzoU29Uz/As+FDD1TxVazAA4zoXnf1OHqAuazvQyS/2gbwJq KLr90KXH+Fygcb/ZfT0ycq5lzfHE8zte+R1x+5bfKrFrAn6gH0ODfAz6ioje99q3DPWQ +3cA== X-Forwarded-Encrypted: i=1; AFNElJ/NVixWIhlnEzknd4PRYRYWl4XsjGv5FKRcfSABAGUzCPbdN2u2u6shgi2rMyDLYChl6FtOblrTe1/KANw=@vger.kernel.org X-Gm-Message-State: AOJu0YztHETrrJBYjNhuK1T6OknhvH/BHQULOkj3d83t1gyJqUIsxtQW bQrC7y/RRgq1/AfpSOAEvlR9bVz0b8FAEpmAZL3JHlzITsPrKrOe+zvWrt1Y6jknWMjdhw/xuxe Yz+HMUKruf9pv/35tiAyHzPanW2aQNjEi/t5R0q+sUDUz85FGhuUhW5zTZ/LgUAlEFg== X-Gm-Gg: AeBDieu52xY1Ek/kGg6qL2aIujguvmnq7hDq2XSyhuw3Ec1xRSBv8Ke5rNoozXgo460 TWgQFnJ+93B1GiTuymaiLEWrKVLBK7ijUmix7NddNJioDGGnacGu8yqZuD2OgJz3Z/Nw0JDtvjO KEp2jqbyefQudM3q9XYf7MB/fRyNjRGT3cvtImMdapJL5Rolhow45Rujxzuouylxex5HUmSiAIW Kb1o9QscSpBMTQJ2zGOWHmTcoNLMsVuKUJcrZ7ADSdAvngSekXnaFmOOIV0KQD9x7w8yTG0eZQ8 C5QczmsKs1uTYnqVLce2FWxAD5FoVND2CV+zMTtdQhDf3CykcbHfVCgak4jZ3Gyj77B39GuZOws mWvwBybJYmsYlsripTbtW X-Received: by 2002:a05:622a:513:b0:50d:6865:82c9 with SMTP id d75a77b69052e-50e135a3d50mr37242271cf.10.1776197167666; Tue, 14 Apr 2026 13:06:07 -0700 (PDT) X-Received: by 2002:a05:622a:513:b0:50d:6865:82c9 with SMTP id d75a77b69052e-50e135a3d50mr37241511cf.10.1776197167167; Tue, 14 Apr 2026 13:06:07 -0700 (PDT) Received: from redhat.com ([2600:382:8116:76c6:c5b1:9485:5da8:de42]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50df2f4fa51sm69907041cf.5.2026.04.14.13.06.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 13:06:06 -0700 (PDT) Date: Tue, 14 Apr 2026 16:06:03 -0400 From: Brian Masney To: Guangshuo Li Cc: Vladimir Kondratiev , Gregory CLEMENT , =?iso-8859-1?Q?Th=E9o?= Lebrun , Michael Turquette , Stephen Boyd , linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] clk: eyeq: fix memory leak in eqc_auxdev_create() error path Message-ID: References: <20260412124247.2494971-1-lgs201920130244@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.3.1 (2026-03-20) On Tue, Apr 14, 2026 at 07:49:31PM +0800, Guangshuo Li wrote: > Hi Brian, > > Thanks for reviewing. > > On Tue, 14 Apr 2026 at 00:42, Brian Masney wrote: > > > > There is a leak in the error path here as well. I think this code > > should be converted to devm_kzalloc(). > > > > There is no devm_kzalloc_obj() yet, however according to [1] that should > > be coming soon. > > > > [1] https://lore.kernel.org/lkml/20260330154108.GA3389518@killaraus.ideasonboard.com/ > > > > Brian > > > > I may be missing something, but I think the auxiliary_device_add() error > path is already handled here: > > ret = auxiliary_device_add(adev); > if (ret) > auxiliary_device_uninit(adev); > > The auxiliary device also has: > > adev->dev.release = eqc_auxdev_release; > > with: > > static void eqc_auxdev_release(struct device *dev) > { > struct auxiliary_device *adev = to_auxiliary_dev(dev); > > kfree(adev); > } > > So my understanding was that after a successful auxiliary_device_init(), > the auxiliary_device_add() failure path should be cleaned up through > auxiliary_device_uninit(), which would eventually invoke the release > callback and free adev. > > The leak I was trying to fix is only the auxiliary_device_init() failure > path, where the function returns directly before that cleanup path is > available. > > Please let me know if I overlooked something. You are right. Sorry about that. My original suggestion still applies though to move over to the devm variant since that'll allow you to remove the release callback. Brian