From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AB7B23D7FF for ; Wed, 15 Apr 2026 00:55:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776214540; cv=none; b=I8wSaAAj7mYHDSuMkedM8yu4gsrRPsKPX8m/8LeLG/X1PFyng3LZ/EHLOJA6MX585qPFWxCUGQ8nJV6a3NiHZN10vAyV27uPRP7j6wxlCai3FlSbDe7txgPRHWRn51UHJ5MUVDBYekiHyOpMfydRs6KyhFaRPzxR3UvJAMdT0Gw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776214540; c=relaxed/simple; bh=uR7zICZrPqA3pqbX3WQqMUbEPNxsQPQMsyKFmWeczAo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b5CiftpzHI54aWDQ1FemqnVujwIkMmPRUwUvrRp3qCf6rLYhaZc7Ej0n+jaRkhnjDS2WMv1phI9jr4WJ7WBwv5SDY8HHBgZnrb8+AtSZ7gldMTgzIaO1KyKFDW4Gxqfo+H/oIzR4vsFFwoTQptWvQpVwdq+d3y8FmsSKiGOOeLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pCVHs9/g; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pCVHs9/g" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2ad617d5b80so33612785ad.1 for ; Tue, 14 Apr 2026 17:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776214539; x=1776819339; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3gzoPmEVomNuNkQgJ3GGZQ3Hx4+z8ZNknRdL+LmeEQ8=; b=pCVHs9/gVOjsmp99pQU6504kYl+IWNlCj2IxTfUJiZm8kG1Bx493SDS9J9m0Y5M8tH Rhyfz+FDtrRFH8/vDWGzq8AlV18uBAnVV81OUISzhKu1hjphjIb1sCUF4C3JEAespJZM t5BPsV0S2v3AcGVZPBgkl2qmvjHVzGNQ3rx9UQl+20Itkv2CNl5GmSl60pTZOCuS1KY8 zkWAWnQlyfhhrOr3E2qujLZulqI62JIcPxYtwRt19d8ycaHEhbuhd0EAHxLQKy1F3Q26 JxGo1F0nQyvpn7MuskFKXKjdSdYB3vHKEB5qWJrEFUJ+QutD+7j53rARuwF4fehba1nG xwJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776214539; x=1776819339; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3gzoPmEVomNuNkQgJ3GGZQ3Hx4+z8ZNknRdL+LmeEQ8=; b=LfwhHeNXNlkPFfNKosWIJb8ESX+BEij6E61OBB6mqHBbZahbNuK7ikypNCpczEKky4 vDFmk6fsPYx/v1VDo69xlMuuLzScgwrHgs1b8+zVkQXkQnaJ09vofQPKWtvAF5YqMbNF QKEAksiONqMtaUUaOqg9JMnihOLE+HvWLeRGXsAjAxpWoIAHJ7++W9bRCcFbYgkdZv0D DhiTXyQ5I87JPUnEYo+9q+h8VCfs7dj9Iu6fsZjl9d6/ah4W8Dwwjugt8Hz8J86bNR2E vAP4VpXYbadkhH67h6GeaIGK4b3tGE51we26VedVh8MCzZCtXK69jILeZC3ym2/RI9f9 RHrA== X-Forwarded-Encrypted: i=1; AFNElJ/VoENQ6AT7RWSI09SzjsJ4MpYURfE9RcxrXBPEFdpe74vG5SCbHUhbGZ9Jny1CFvpd/gnXsajssa/Q1A8=@vger.kernel.org X-Gm-Message-State: AOJu0YxvKI82N0E29a6keZih0s4t83foNKwV0apdkKhL++zUXR3ev2R6 ZVselKKuNiFJnqO/9uB5WYVWKNFOD/u3G31PIL3tjaYNhmFZc5nGdrGy X-Gm-Gg: AeBDieuomcWvnjdNcCPDNqLxUkR8HwCWXwRGk8df9vVKK8ZFcQFtVinew26fO7Hf+e5 RNAB7t6JjzIKlub9pKBIedCJjPlTTJJtG2M985QiH/eMJpWuxdwiskehLtBMyD/aF1Vi1E/Exh3 TxEZWUijwvW3ywOxpA07toR1drQOcAtbELd5IIuWDi6egWPC05zD/WOBCvK8lVyNWwIUNDgh/mo Tf6ZTPWyaeEeDHXzcJj/JzoyUQf0xpRN4FRlRxAykm9/EEww4vXY6pQha7V1e1TaaJo0gtkIbI1 GfYtQjVNUf84Ndh3TQ8h0nBezKOb+MJBgbOlSYB2WLLkHNIcLgNxE4uUB2fJpFLNxIa0OWg2zS3 iXRmnQtaYFYvLn+SnRFU6JZ5rbph2qIYf75r3GSQrxMBEKYLlNm/GSiHHSR725fi8D+8gBVThkg idK8kHHK6273hrvAu7Q+pAorXXgIKg X-Received: by 2002:a17:903:1b46:b0:2b0:4a57:e480 with SMTP id d9443c01a7336-2b2d5a831a5mr187240625ad.45.1776214538719; Tue, 14 Apr 2026 17:55:38 -0700 (PDT) Received: from localhost ([180.102.171.39]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b478139fe8sm1659615ad.36.2026.04.14.17.55.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 17:55:37 -0700 (PDT) Date: Wed, 15 Apr 2026 08:52:35 +0800 From: Coiby Xu To: Thomas Huth Cc: x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/headers: Remove "#include " from set_memory.h Message-ID: References: <20260409144819.2000120-1-thuth@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260409144819.2000120-1-thuth@redhat.com> On Thu, Apr 09, 2026 at 04:48:19PM +0200, Thomas Huth wrote: >From: Thomas Huth > >The "#include " has been added to set_memory.h in >commit e1e6cd01d933 ("Revert "x86/mm: Remove unused __set_memory_prot()"") >to provide the "pgprot_t" type in the prototype of __set_memory_prot(). >Later, the prototype of __set_memory_prot() has been removed again, see >commit 8a4e92b3260a ("x86/crash: Use set_memory_p() instead of >__set_memory_prot()"), but the pgtable.h line has been left in the header. >Thus, since it's not required here anymore, remove it now from >set_memory.h. However, there is a indirect dependency on pgtable.h >in the sev.h header file instead, so we now have to include it there >to avoid that the build breaks. > >Signed-off-by: Thomas Huth >--- > arch/x86/include/asm/set_memory.h | 1 - > arch/x86/include/asm/sev.h | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > >diff --git a/arch/x86/include/asm/set_memory.h b/arch/x86/include/asm/set_memory.h >index 4362c26aa992d..8d9f1c9aaa4ce 100644 >--- a/arch/x86/include/asm/set_memory.h >+++ b/arch/x86/include/asm/set_memory.h >@@ -4,7 +4,6 @@ > > #include > #include >-#include > > #define set_memory_rox set_memory_rox > int set_memory_rox(unsigned long addr, int numpages); >diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h >index 0e6c0940100f3..3936c821d6b0a 100644 >--- a/arch/x86/include/asm/sev.h >+++ b/arch/x86/include/asm/sev.h >@@ -14,6 +14,7 @@ > #include > #include > #include >+#include > #include > #include > >-- >2.53.0 > I forgot to drop unneeded pgtable.h. Thanks for addressing it! Acked-by: Coiby Xu -- Best regards, Coiby