public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Ye Liu <ye.liu@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, Ye Liu <liuye@kylinos.cn>,
	Vlastimil Babka <vbabka@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] mm/vmstat: simplify folio stat APIs
Date: Wed, 15 Apr 2026 04:59:36 +0100	[thread overview]
Message-ID: <ad8NKAxUAP0RYP5h@casper.infradead.org> (raw)
In-Reply-To: <6c0ab55e-a687-4ad1-b18e-b4ca97305a44@linux.dev>

On Wed, Apr 15, 2026 at 08:47:24AM +0800, Ye Liu wrote:
> Thank you for your feedback, Matthew. I acknowledge that this change may
> introduce additional calls to folio_nr_pages() in some cases where the
> value was previously computed once and reused. However, the new
> add_folio/sub_folio functions provide clearer semantics, explicitly
> indicating that we're accounting for the entire folio rather than
> potentially partial pages. The overhead of recomputing folio_nr_pages()
> is minimal in most scenarios, and the improved readability and reduced
> argument passing outweigh this concern.

I disagree.

  reply	other threads:[~2026-04-15  3:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14  9:15 [PATCH 0/4] mm/vmstat: simplify folio stat APIs Ye Liu
2026-04-14  9:15 ` [PATCH 1/4] mm/vmstat: use node_stat_add_folio/sub_folio for folio_nr_pages operations Ye Liu
2026-04-14 17:52   ` David Hildenbrand (Arm)
2026-04-15  0:48     ` Ye Liu
2026-04-14  9:15 ` [PATCH 2/4] mm/vmstat: use zone_stat_add_folio/sub_folio " Ye Liu
2026-04-14  9:15 ` [PATCH 3/4] mm/vmstat: remove unused __node_stat_* wrappers Ye Liu
2026-04-14 14:59   ` Joshua Hahn
2026-04-15  0:50     ` Ye Liu
2026-04-15  2:29       ` Joshua Hahn
2026-04-15  5:51         ` Ye Liu
2026-04-14  9:15 ` [PATCH 4/4] mm/vmstat: remove unused __zone_stat_* wrappers Ye Liu
2026-04-14 13:18 ` [PATCH 0/4] mm/vmstat: simplify folio stat APIs Matthew Wilcox
2026-04-15  0:47   ` Ye Liu
2026-04-15  3:59     ` Matthew Wilcox [this message]
2026-04-15  5:54       ` Ye Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad8NKAxUAP0RYP5h@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuye@kylinos.cn \
    --cc=vbabka@kernel.org \
    --cc=ye.liu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox