From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BC0802C11DF for ; Wed, 15 Apr 2026 05:36:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776231377; cv=none; b=nDbk1gJEnohhUx+lLS/aOH06LzRoIQlXf6Yz5VFzw4iZLg8NT6pSpxEFxnpLcOgzFdqCA/2c/lGAPik3zoH+OISVBsxllo96ekaeALKcW/8DblMnrmv7q0XsOjSyJQibKKwK0ujJXXWzRSTZ+7eJf03RDjdlCf0DE3CzT8zqpDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776231377; c=relaxed/simple; bh=UU2BXdGMJyr9q4mAsFIm8mMtzZnkRwYF9AofLjkAGrc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dd5ra/fm1ri7lC9c2YKSN5c3FXKfbwXAkZcrIcVJRoLLvWud8KkmWeAfatAZ9R0iTiXFNShghWiv1nng8j0YL9KePN37WxVv5xeswquLkD6k+PpruYl2In7w10DL2+yTodlvXBmHByveAiaxWdxYy36vxdZNkFA3peOqQIhq1kE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=lGfuHt5S; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="lGfuHt5S" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1AB9F4B37; Tue, 14 Apr 2026 22:36:09 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 455D63F641; Tue, 14 Apr 2026 22:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776231374; bh=UU2BXdGMJyr9q4mAsFIm8mMtzZnkRwYF9AofLjkAGrc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lGfuHt5SGpzvLbi4ltzXpaNXfAykcgdkNW2yXwkw+PD7QCjxcMajihLaxyM5506Pj DRv8ZKAMUSa1ToN+LM0M8tG9sYiaA9WNn4Q+7K4EaryuXJQwo7W+mqn6ZzNiULFZFP aqV8UIbpSwG1Dk51c0iXOoDfJkhIfntTm+AtKuX8= Date: Wed, 15 Apr 2026 06:36:10 +0100 From: Yeoreum Yun To: Jie Gan Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com Subject: Re: [PATCH v4 4/9] coresight: etm4x: fix inconsistencies with sysfs configuration Message-ID: References: <20260413142003.3549310-1-yeoreum.yun@arm.com> <20260413142003.3549310-5-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [...] > > @@ -616,23 +622,46 @@ static int etm4_enable_hw(struct etmv4_drvdata *drvdata) > > static void etm4_enable_sysfs_smp_call(void *info) > > { > > struct etm4_enable_arg *arg = info; > > + struct etmv4_drvdata *drvdata; > > struct coresight_device *csdev; > > if (WARN_ON(!arg)) > > return; > > - csdev = arg->drvdata->csdev; > > + drvdata = arg->drvdata; > > + csdev = drvdata->csdev; > > if (!coresight_take_mode(csdev, CS_MODE_SYSFS)) { > > /* Someone is already using the tracer */ > > arg->rc = -EBUSY; > > return; > > } > > - arg->rc = etm4_enable_hw(arg->drvdata); > > + drvdata->active_config = arg->config; > > - /* The tracer didn't start */ > > + if (arg->cfg_hash) { > > + arg->rc = cscfg_csdev_enable_active_config(csdev, > > + arg->cfg_hash, > > + arg->preset); > > + if (arg->rc) > > + goto err; > > + } > > + > > + drvdata->trcid = arg->trace_id; > > + > > + /* Tracer will never be paused in sysfs mode */ > > + drvdata->paused = false; > > + > > + arg->rc = etm4_enable_hw(drvdata); > > if (arg->rc) > > - coresight_set_mode(csdev, CS_MODE_DISABLED); > > + goto err; > > + > > + drvdata->sticky_enable = true; > > + > > + return; > > +err: > > + /* The tracer didn't start */ > > + etm4_release_trace_id(drvdata); > > [NIT] better move this error handle to etm4_enable_sysfs. > > smp_call_function_single possible return before call > etm4_enable_sysfs_smp_call if the cpu is offline. The error path here cannot > handle this error, breaking previous logic(handle all errors in > etm4_enable_sysfs by releasing trace id). > > There is no harm in not releasing the trace id here because ETM can re-use > the allocated trace ID. But it's better to fix the inconsistent logic. Agree. I've missed this! Thanks ;) [...] -- Sincerely, Yeoreum Yun