From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A9362FD69A for ; Wed, 15 Apr 2026 08:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776242855; cv=none; b=VZMGPmcyxz02STjmZeRr8rkxpYff1O2zLBxdCKLZ6OU30WLO64k7C3bOZxXqBSjv112e3gVM3eJX/B+kpGX+IUI9EHl7VRaIqM6Zqi3zTJMAZ1unBS8RPq+TzIDhuRFZZpqLNawVbhp2OI8JTuI/c+T02iWAkFnbmbw1rFBhwzw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776242855; c=relaxed/simple; bh=lJ6ThLlEC5qIfLJ3GiWGSn2UDtZQp3g1MqucF6oNwZM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BA5paVklwAKycDKIntD45YzTNMi1x9A/EpVdxXstdpHc40WBktUBLi+AvSsFF9lhvVEscdMbCXGsK0x4FWDO7mKP/jshlyTXeYw9npvPvrUsztGQxJ6KwJbYHvxhuVWQbqadiwO1WyeyIN0qbWiQlpV8suyFbJuW11Pw1t/vuIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KsEnQhy8; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KsEnQhy8" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43d70b3e159so1493532f8f.0 for ; Wed, 15 Apr 2026 01:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776242853; x=1776847653; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xhH84NXX33T2mx07NdMMkNioRpn5lPJ7BGqiQz9oSTU=; b=KsEnQhy8I/SUJIHCm33pUmPeCiNgEpk2gDeOh4ZtiOz6J7bDFOHC4vv2yE2VMOoQxB Egr/JcTbJA38vH0V5PCUF5+N3/RdlOYh9TG5/yiVg5a38K2IxLFFOHrXIE4Uzd5scBLD Q2SPGQFn/3zNcRvnVFSZhO5xMBPIPOKW3qQn8qPS+6inoz9/LU/mbwZdf2n9co5/jyva nHL4pVRmTGh77pLOiZ2zBkCGkvGQ89z19hN2dSaeTSyhfaW48G9DlDrlM7MFePpaH6Li Ma3ifDCU/GUArxzVmAS6h2uM4icUApTEDmsb44+fn99O5b4DbA+uZMqy/5+Cd5yR8FbE Tjyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776242853; x=1776847653; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xhH84NXX33T2mx07NdMMkNioRpn5lPJ7BGqiQz9oSTU=; b=UNnBC8jInxmz0lsIVA2HgsJ6Db5S7dcnuMd9d9qbcFCf/ZM3MFn7qOjkMuKNdbanBE v3JvrYX8I6YEulvv2CNljs4yY4D8khgOC1usHQS18CXEN4pfhANg9pheBpqhC1AIKpwu QLpKFAqJs3w0WtbLQTc4xsT35PhXTjg/NzkKRSTubGwIEQRJvOvsFsJ9lWuOS3MOhi1R HuHtV++Rl4Vnt140anE/vtupMcB0cZcMtuHhU242PtNnBoQZ8VXVCErpKccFcChqO0o7 IUmbuxfpD5OILlCzc63fhxOt2RFjoDnr2Sa4Eqq9A+lutahPm7gO1UQCBnJpU2+A6kBq wH3g== X-Forwarded-Encrypted: i=1; AFNElJ/Z1bl+1+yE2lenyAmlzeVwPD7RwNfPwCCiKHlJ64s7Kqr7dOTYk0u7b7FNFw7oFlbkia8Y+0Hv/l8CaVg=@vger.kernel.org X-Gm-Message-State: AOJu0YwizpXa91QPMPBmkP3HM9TXn999RQhBIUWdLbPUtFAXsIyOgWMw L7S9MS92wG+XzGBILxQowM7qlSSY9+Hl/F9ESYmziPmSC3V7PQU0FbziZk2HtmzuVvc= X-Gm-Gg: AeBDieuR01i/vWvTI4Qcos8in41bdMN29tkIP/5iHTtjVxTMBLrXRZ4UZn/ZIq1Q3jn 1P3YE7yKDxSLJQVbkNkMfEyXmToaeTvQBeYn5QCB3BIVU0Dz0u27PVYXbYdvWP+AGkKzAccASuR iUb8sOY9kideRXM4hOhG4IGZmaScdOYX/li59rlh9MUP+XpT8zyXmRnVHR6kz44mX2KeyGq8eiU 4xEgpyJmLDqOt3Sfc8X3ewkU6cCxClouV3IHmdg7Bv0SsGBz+FZjruLOlHBkFVDIXZfcg0wGA7e mtRcI4rJou1BlAfFCqJBKh3X4tJNs5ccwqMvUvyY7+ITyN0B434MXFHdBP6hJByRcA002lXI/c0 InQUX/h5fNOSAd6tuI5ubPtLZBcnTjUgfd/nMOAglJIfpObgV24DJpJ1sQJ8/3OVm/PSmi5HwwJ dPVT4Fp3sAM8igYT98ag8= X-Received: by 2002:a05:6000:40cb:b0:43d:1c39:593c with SMTP id ffacd0b85a97d-43d642b6a52mr29169874f8f.30.1776242852517; Wed, 15 Apr 2026 01:47:32 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead33d665sm3372873f8f.7.2026.04.15.01.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 01:47:31 -0700 (PDT) Date: Wed, 15 Apr 2026 11:47:28 +0300 From: Dan Carpenter To: Alexandru Hossu Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: fix missing frame length checks in OnAuthClient Message-ID: References: <20260414213959.1028301-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260414213959.1028301-1-hossu.alexandru@gmail.com> On Tue, Apr 14, 2026 at 11:39:59PM +0200, Alexandru Hossu wrote: > OnAuthClient() accesses pframe without first verifying that pkt_len is > large enough to contain a valid 802.11 management frame header: > > - get_da(pframe) reads bytes 4-9, requiring pkt_len >= 10 > - GetPrivacy(pframe) reads the FC field at bytes 0-1 > > Additionally, when pkt_len < WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_ the > unsigned subtraction passed to rtw_get_ie() wraps around, causing it > to scan well past the end of the buffer. > > Add an early check against WLAN_HDR_A3_LEN before any pframe access, > and a second check against WLAN_HDR_A3_LEN + offset + 6 after computing > offset to guard the seq/status reads and the rtw_get_ie() call. > > Suggested-by: Dan Carpenter > Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") > Cc: stable@vger.kernel.org > Signed-off-by: Alexandru Hossu > --- Looks good! Reviewed-by: Dan Carpenter regards, dan carpenter