From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF3333D512 for ; Wed, 15 Apr 2026 10:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776247632; cv=none; b=JJBZ5p6cVaazom56BcqCDGqFQdvE9xbHv85EQk5DBgbjAwSzsae/LoqauzXgBPw9tKGpf5AvVgu4cO7u/GwX3APYflJpYPz9jPI+HMV6wVH1BGVMto+OjQnDMXhqDizf1K0O8B5Gmc7WyA5GQImDgZmTeMleye5gnFY7Ly/DDaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776247632; c=relaxed/simple; bh=+EHAfEWM90jKbDIZLWcYKq95z89L20I7QxcNlHpcZdU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EOSLm1AV+xFIgtClhdL5KBZLMOQhl60h2KAkvcXCFtIYFhLWuARl/Yrfst+I8JeliaHz7gOPl2/gsn2ZofsDp/OFT/gkac5s5sIF7Pcnng0HbW8tqPh2wNURuuH6JGZKl84674INl5kTXFORYBbNWma9CQPSvw64cLi/PENRBn4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iWEAknC0; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iWEAknC0" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488ba6366a7so80726845e9.0 for ; Wed, 15 Apr 2026 03:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776247629; x=1776852429; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fwD7g53BnTePogg0UDsCJwaAtnVvF+V6jFjATkNomOw=; b=iWEAknC0owneU1HZwu5aGvGORmrK5dmYeT/qP3t7MkM7aAvO+HrfXFUic2EnRtwj4X cu0V548NfaODTuiyP0vIoIu0AUJArVABjrThUL2zFWb0Z0IK2ZJAvB8rAOWwdF4Ja/fD f5VveKgtsS61GSutHPzcDYdEMqsoLUsjWU+LDrOitI1h4SYYehxzfyV1tXHH9c3C/Ha5 PyKa1j3a/JG05tR+4sYzl5vE8eJSzUDB9DCR3cqbwIBrAo5ZkCns6Q1qrxvuPVtdLFsR jBE+/ags0vZnUKiDEshd94IuX3XykBKBk1OY8oa1S2KrhYbqIpgZeohdgq7ycQsuAqV4 PoMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776247629; x=1776852429; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fwD7g53BnTePogg0UDsCJwaAtnVvF+V6jFjATkNomOw=; b=MnW5KajoCSY9cXd3I0QGowTOFfU57P6SRxY7wwtTbugKttW7mQ2qnxm4Mlm8RVWuY9 /MOu7BOjGZzNY/GvDIrfQkCF4zMT8rYjOi2Z4IVtPnI6mrtKmsU7YRbkrv6OcL6mwIpl bx5r599yPn/0x5fsl/5KwZz3u/Is7nr3NJ3IENoFDxfhNdU/UvEW0MHGWjfshUPf4kJM xhEuHsfORuxZ8obUsnH8ajQpkW8l2dcP4g5PisMO5NRWvFiXovn1HgqIyFEiGQUag0jP m2cXnDVOftghOc30zubp2Pn9FpbC+4UG1Hi/1WE07Plz3mQibDr2kj7DeFyve5b1uW+s GtEg== X-Forwarded-Encrypted: i=1; AFNElJ+ewDCK/Vr/Oel2XEa69l6bOlO5GHW1qCmH+yshczXy8gNncZ31n6GE9BsdeK1Bar5od+6DkrUHKWR5mMw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4WrfH6Qy47w4hXWu/FMqy8mhhA/LDWlXM2fzmwYBmBxaN3KBJ xPbmt2NObIFTM5LKic3O3HNyTUBjPjG9z8zB9BP9Xd3K94JsyX4e3szw X-Gm-Gg: AeBDieuTMjtTCrVwpwwBS6iOCkn1pZ/mNWu0X1DdI27MeJuq+wJHpzYsuHo0jyvOUvO w+I9bAwR9EuXxP7oAOFHgD236DH/v3OVwwS0Z8lKk8szaXgZHL6OFBwu+rp5PAhU6CgpmYfvBNY VNUO1G+/TXVhYgLNAIvetNIzsmd4w5wsYc143QwRuIjfkQdjuO5t36FaL4dYCYJenC8+MNN8vl7 LCPU8lfdZC8HYdRukC+FpWDMW/FrYY60y+OXhr8Jku9Fvi2Qm9UoudLFI+MNjW67O7qYS09wChF CcWzeDeqIb9dIJCUFFu/GRjPxwRtSttXTYxprvKuT2e5/JaVGaoeoG65uIBeyWXTqbosVduXT7v YhopvOcX+hFvOP4DjRcbux0RYwU9HwJW5Md1bzgO8MV/Rx/3AqIAg+xr3YIa8/paC6a6S5mwRK2 I/NVCxg+3tF/5XuLeWD6k= X-Received: by 2002:a05:600c:820a:b0:488:b675:360f with SMTP id 5b1f17b1804b1-488d6889a6bmr256997945e9.27.1776247629301; Wed, 15 Apr 2026 03:07:09 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f253647fsm55232475e9.1.2026.04.15.03.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 03:07:08 -0700 (PDT) Date: Wed, 15 Apr 2026 13:07:05 +0300 From: Dan Carpenter To: luka.gejak@linux.dev Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: clean up memcpy() in rtw_check_bcn_info Message-ID: References: <20260415085638.6427-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260415085638.6427-1-luka.gejak@linux.dev> On Wed, Apr 15, 2026 at 10:56:38AM +0200, luka.gejak@linux.dev wrote: > From: Luka Gejak > > Move the ssid memcpy() inside the ie null-check to avoid calling it > with a NULL-derived pointer (p + 2) when the ie is missing. > > While the kernel handles 0-length memcpy() safely as a no-op, keeping > the call outside the check is confusing and poor practice. This > change improves code readability. > > Signed-off-by: Luka Gejak > --- > As Dan pointed out kernel handles 0-length memcpy() safely as a no-op > therefore it doesn't cause kernel oops or panics so in v2 changed commit > message to move from bugfix to cleanup and removed fixes tag. Thanks. Reviewed-by: Dan Carpenter regards, dan carpenter