From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01EDE335067 for ; Fri, 3 Apr 2026 22:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775256466; cv=none; b=UxBBprmUq7bA0VD2qDbP61CDOys4w74zGcoOX379OQap63AOcsv1SDOTePh6+SGkpoX2T+5Ke94geB5NGmkMioCVOoVoEiyYiOiGboHV3p3fB2yrrEUtHI7vGSLYGticp0VNCwhEkFooyJdzcMFIFUYFIqxA6/JFzIbs3AnKjJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775256466; c=relaxed/simple; bh=23jZLb1BbMRl4vVbPZVhrG0tF5G2ahmVNt+nZWQBrj0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=doQ6Tcuox79CDARcN5lnnGlh+G7SlPfPi61Fl4iankq+0OvtgXLTYc1I3ZEF6diqBqtwBEDhJNifsZHkXi+Lbe8UAt3VCdcsLd1CfgYAase9HMuKmLXQqszl6FNz8cUpFnGEs6Y3RFwsxGI+sRcBRcy7FRmlAf1dy9wgH99Psu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qpdsOvAb; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qpdsOvAb" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82ce0a9b3f7so1013356b3a.0 for ; Fri, 03 Apr 2026 15:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775256464; x=1775861264; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4z6d+6/MCDVIyWyvyF5t9cjT1g5478mQCP1zANwoYI0=; b=qpdsOvAb9prwkBf8sHnfkAfPCbqeS5S68zMQvfzvQfqx32SdxDgNyV1YkdSDMzre2Y 0hRlRlVQykT+rOwtTlNRTFI7Hn8M4nMKmn6eo7nvhbnTkmpKWn6L5F/o9n7z0cl2Ia3G jAUlrvc78fcTR834FewogEyRfdCKBu3f1iu/lYG0F0Re/kxdqM8EcqlXAPZMIhaTOd6A 9OW032fC5iifd675TW0F3A4pjBMM85gRtAzcBpjsa/IOAq0zip1Zd4znb/u+et0VMpjM eW4PD5cKn+DdX8raFSKhZ4GYeLHIcv0OXScoqi9WZH/5Ad8bprk8KOfvVI3yQ/JkZHD3 VFmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775256464; x=1775861264; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4z6d+6/MCDVIyWyvyF5t9cjT1g5478mQCP1zANwoYI0=; b=tDN9/QyiEP2qWrbOSLmGaR5B/nKzycPiQmuEn+cSygkyTxGOc7jYy2Ar3Bb8G4tEz0 d5tQhkhg5n5sZQ3Hv82mtHKQKBpFa9cXtrQ5HFz4qCnv+Q6OT/2kfsmS7cnmcApZTUNl xvt/PiOvDwzutqnNIicemqb6thhmtQ3Qwwl3Cnt7FSYJmAAPW4lclv8ul1dTNumCTwHo e0YTlPagbBav27aLkVYxocR2s7i75qeNKHgZr9cdGhSuYlEcYbpC8JFctH4x+9s/xQsc vizYE1NOLlgIn/cwAKn1a9F0lVSpKxUnI9cyAOMkZvHnUTYmpFPG46GlIH7oeaieLZtV JNzQ== X-Forwarded-Encrypted: i=1; AJvYcCXprY9ZTdq5rpecBOD7wN6xemDLwP4AYkgus2Xo3GaLCdBTnC1Nlwb4K+eGV7lzuY0Ia0Q/g2o59p3oHo4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywb/fh5tHNMK+iYrK9jzkKTp2v0W+Xm8f0B0ImCJx+H3cGIg3KM I66MneKJoOlujkdkjuLt5ZNre2s+SvEke76TCyC3z5vcXsxpT6KWD6q+n3XkKrZ/0g== X-Gm-Gg: AeBDievV6g5oKUx7c2C6ZvMlxZJFz6w9ivRii4YCQo+gCYDPVodG4AmkB7e64GoIT5R FI0Bi5qWiAsPsnYi+3wRlHDgw820JjmMl/aUO86skH1lDjKPZvpIbZCYJ6+L7g6/o6b2ZQWIZGJ cL7waLGW8x9ElSAkEeru8ToQkv76g0fBY0PEcbkwx89LLk18en6ux8u/7zXQKK6tDU2afeih464 ny0fLCcWfHhptwGOx5+cQDJzPhK9x0siURRijWxpuIWGT09lzn8UrXHlrFV0uVugUGln3k21fGz /1z6pv+XdBIdX3TJ+VJxCskCoyN/WXacCKyLXb5L9sVvZo57XTl9jAHahkdkL53vWN7oxEnPJux M/s1hggrPWk0Xz2Vn+xPtf6lgaOhvNQlKn07OnabDYcIdVruZxFyq2pSA3q3+V3IXHjs7wk/D53 qD7zVYQijzWtGSyt+FL14pXYc3jRTv9ygPwHCgy3xHpMAndb/I4aU17FJwBQzbvE6MuL8= X-Received: by 2002:a05:6a00:27a4:b0:82c:ebbd:9eca with SMTP id d2e1a72fcca58-82d0da3d529mr3892740b3a.11.1775256463733; Fri, 03 Apr 2026 15:47:43 -0700 (PDT) Received: from google.com (21.59.127.34.bc.googleusercontent.com. [34.127.59.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9a24039sm6887661b3a.0.2026.04.03.15.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 15:47:42 -0700 (PDT) Date: Fri, 3 Apr 2026 22:47:39 +0000 From: Benson Leung To: Jameson Thies Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, abhishekpandit@chromium.org, bleung@chromium.org, heikki.krogerus@linux.intel.com, akuchynski@chromium.org, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] usb: typec: cros_ec_ucsi: Load driver from OF and ACPI definitions Message-ID: References: <20260403223357.1896403-1-jthies@google.com> <20260403223357.1896403-3-jthies@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="g0BQnNgQsp6LXI7n" Content-Disposition: inline In-Reply-To: <20260403223357.1896403-3-jthies@google.com> --g0BQnNgQsp6LXI7n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 03, 2026 at 10:33:27PM +0000, Jameson Thies wrote: > Add support for cros_ec_ucsi to load based on "google,cros-ec-ucsi" > compatible devices and "GOOG0021" ACPI nodes. >=20 > Signed-off-by: Jameson Thies Reviewed-by: Benson Leung > --- > drivers/usb/typec/ucsi/cros_ec_ucsi.c | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/usb/typec/ucsi/cros_ec_ucsi.c b/drivers/usb/typec/uc= si/cros_ec_ucsi.c > index 6bca2dce211c..251aa7251ce6 100644 > --- a/drivers/usb/typec/ucsi/cros_ec_ucsi.c > +++ b/drivers/usb/typec/ucsi/cros_ec_ucsi.c > @@ -5,11 +5,13 @@ > * Copyright 2024 Google LLC. > */ > =20 > +#include > #include > #include > #include > #include > #include > +#include > #include > #include > #include > @@ -257,7 +259,6 @@ static void cros_ucsi_destroy(struct cros_ucsi_data *= udata) > static int cros_ucsi_probe(struct platform_device *pdev) > { > struct device *dev =3D &pdev->dev; > - struct cros_ec_dev *ec_data =3D dev_get_drvdata(dev->parent); > struct cros_ucsi_data *udata; > int ret; > =20 > @@ -265,9 +266,16 @@ static int cros_ucsi_probe(struct platform_device *p= dev) > if (!udata) > return -ENOMEM; > =20 > + /* ACPI and OF FW nodes for cros_ec_ucsi are children of the ChromeOS E= C. If the > + * cros_ec_ucsi device has an ACPI or OF FW node, its parent is the Chr= omeOS EC device. > + * Platforms without a FW node for cros_ec_ucsi may add it as a subdevi= ce of cros_ec_dev. > + */ > udata->dev =3D dev; > + if (is_acpi_device_node(dev->fwnode) || is_of_node(dev->fwnode)) > + udata->ec =3D dev_get_drvdata(dev->parent); > + else > + udata->ec =3D ((struct cros_ec_dev *)dev_get_drvdata(dev->parent))->ec= _dev; > =20 > - udata->ec =3D ec_data->ec_dev; > if (!udata->ec) > return dev_err_probe(dev, -ENODEV, "couldn't find parent EC device\n"); > =20 > @@ -348,10 +356,24 @@ static const struct platform_device_id cros_ucsi_id= [] =3D { > }; > MODULE_DEVICE_TABLE(platform, cros_ucsi_id); > =20 > +static const struct acpi_device_id cros_ec_ucsi_acpi_device_ids[] =3D { > + { "GOOG0021", 0 }, > + { } > +}; > +MODULE_DEVICE_TABLE(acpi, cros_ec_ucsi_acpi_device_ids); > + > +static const struct of_device_id cros_ucsi_of_match[] =3D { > + { .compatible =3D "google,cros-ec-ucsi", }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, cros_ucsi_of_match); > + > static struct platform_driver cros_ucsi_driver =3D { > .driver =3D { > .name =3D KBUILD_MODNAME, > .pm =3D &cros_ucsi_pm_ops, > + .acpi_match_table =3D cros_ec_ucsi_acpi_device_ids, > + .of_match_table =3D cros_ucsi_of_match, > }, > .id_table =3D cros_ucsi_id, > .probe =3D cros_ucsi_probe, > --=20 > 2.53.0.1213.gd9a14994de-goog >=20 --g0BQnNgQsp6LXI7n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCadBDiwAKCRBzbaomhzOw woFGAQCVsZvOh86t3yXOAhw5d8edARY9zTI1JOnJ37uMGnJSaQEAiaxqyGhDdjUP 8/3JD9T1+a3vPCb+6DOOeB4GNbHyrAw= =rXtP -----END PGP SIGNATURE----- --g0BQnNgQsp6LXI7n--