From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D691D2E889C for ; Fri, 3 Apr 2026 23:12:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775257936; cv=none; b=Q4u9CE/6FbLYJCcUhVZFaXjaF7W7tn0UdBb/MTg3PRYxKhrGU3VIMdQrdzwGs58rl5DZb4olRHSrtKCrYw3+w6ThbyxbmifU0qwxq0iiJwqOkyYfi52v8SemGWutWKgg7uugWBcwkOAqO4kpoEGoyRSlDGrHEyJrEhCRmZY1pZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775257936; c=relaxed/simple; bh=3WA9M4W76ecRe2C4Jnp8JN6QasjMyK6QvZXBaPxQ0xY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=dxwT89yLsJQbQAN22MGQ1ye43CgMokzo6SOZOjl24HO8yWxwy9LYasHBx2eCyAYnw5111AaA5FudRllZ9jXIQCUFEbuHPUyX+TsSY8tzMnIUTSAUeW1TA0uuNpJ35GKJVGWNSr/fMm3dTw8LcxiIu/IsBrZji2dajwqFkUiQDTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rsw/IhiR; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rsw/IhiR" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c7422397574so3216357a12.0 for ; Fri, 03 Apr 2026 16:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775257935; x=1775862735; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=qdgYiNCpCVITKt4WdfY63SIPUYiDMIfHM1afvBz0ai8=; b=rsw/IhiROOJ9nBPns6oBdS2gj6QhLqU1BgRbQvNmld95og8g3HqykF+Wy53G4o/adz /QNfJkxJhZYnzJWLjqF98Qag4Zi2WD/AJVe0xe7NlCKcMiOEl22ZELzLl42fzOXLgaG+ ihA0GBIt3JsMpM/ZY/mdFM4TXhY5Eq0kTCSIE70KsbBqRh5zGhcqlIj2NZCOTK200Qt7 Vs4BWf+Zux1GvgDK2VuV2gTkxp0s6aov96CtUdk19fHS3f2GFREnvEcavWYn3gdbdbY8 5Nn1uZGTMzh5RHo45ndSvkPzp5v0C0wRnkpiWp70qy/e7ZUJxyQUnLXOl3QaldcyK/pL eWyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775257935; x=1775862735; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qdgYiNCpCVITKt4WdfY63SIPUYiDMIfHM1afvBz0ai8=; b=bRexPu5OsF2l3mfqHj2kdKa3tEeT7a1Sb+sf0cHf5LwqWWPeA72T7EnvRLXvaJgmkr 0H+sOJrd2Wvq8flvdyPX948EfAJ82MjC7DqLmcNTldqor709JhqbTO6u2qA7+LDwp85k yRIUhqzcmaaeIuZ4APv6Dkkl9YCNuemwvpRLcLDS1VmEDGmU7BMIyHOo09rQq5iFu94e Hm5PJ3F9GSBPt1AEZQa4ejnDQ3wmO9CMA1ajdR1q25IHttysmvZ2B78O64ODWtVUDY9t 5RHmi+KHemTxGjYsd4KZ/Zl7v6++Ip5uXS4O/bVrFA2o82rfLJNCaZvicn4sv5Gvhmc4 VhRg== X-Forwarded-Encrypted: i=1; AJvYcCV8SZj1W/VIMlY6SGig15Ej91nGK8gmgtUXpUgo0UyMZBwNdtgB2xHt2Fw4D0K320fm1kYsRKnlOsNUhFU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3ldYQwUL5uBLYYqHcFecre3EFl9S/KoMlp1SggavIbBV9qC1F r5qAz81Os23TJ8z0xTvFavzcVnrrC8GQARJJ3DqVInNj8gIlPsQOuF2QObVfk+csqYB37o+6DaH GxGiGuQ== X-Received: from pfmu23.prod.google.com ([2002:aa7:8397:0:b0:829:7ce4:7fcc]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:ac82:b0:82c:daa4:ce2b with SMTP id d2e1a72fcca58-82d0dbcfa01mr4616677b3a.49.1775257934902; Fri, 03 Apr 2026 16:12:14 -0700 (PDT) Date: Fri, 3 Apr 2026 16:12:13 -0700 In-Reply-To: <66e78b59-f96c-4277-b7d7-473b68ed413f@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <545847c132da5d957cfc74ab19e849b16127aa8f.1773890510.git.baolin.wang@linux.alibaba.com> <67c670e2-c98f-490b-bbb9-2960f8175b5a@lucifer.local> <66e78b59-f96c-4277-b7d7-473b68ed413f@linux.alibaba.com> Message-ID: Subject: Re: [PATCH 6/6] mm: change to return bool for the MMU notifier's young flag check From: Sean Christopherson To: Baolin Wang Cc: "Lorenzo Stoakes (Oracle)" , akpm@linux-foundation.org, david@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, open , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Fri, Mar 20, 2026, Baolin Wang wrote: > > > -static __always_inline int kvm_age_hva_range(struct mmu_notifier *mn, > > > - unsigned long start, > > > - unsigned long end, > > > - gfn_handler_t handler, > > > - bool flush_on_ret) > > > +static __always_inline bool kvm_age_hva_range(struct mmu_notifier *mn, > > > + unsigned long start, > > > + unsigned long end, > > > + gfn_handler_t handler, > > > + bool flush_on_ret) > > > > Can we please fix this terrrible indentation while we're here :)? > > > > static __always_inline bool kvm_age_hva_range(struct mmu_notifier *mn, > > unsigned long start, unsigned long end, gfn_handler_t handler, > > bool flush_on_ret) > > > > Would be nicer, thanks! No, please keep this as-is. KVM's preferred style is exactly this (and I personally find mm's style much harder to parse).