[PATCH] xpad: Add RedOctane Games vendor id

[PATCH] xpad: Add RedOctane Games vendor id

[Sanjay Govind]

Add vendor ID for RedOctane Games to xpad

Signed-off-by: Sanjay Govind <sanjay.govind9@gmail.com>
---
 drivers/input/joystick/xpad.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index bf4accf3f581..e97ff270d978 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -585,6 +585,7 @@ static const struct usb_device_id xpad_table[] = {
 	XPAD_XBOX360_VENDOR(0x3651),		/* CRKD Controllers */
 	XPAD_XBOXONE_VENDOR(0x366c),		/* ByoWave controllers */
 	XPAD_XBOX360_VENDOR(0x37d7),		/* Flydigi Controllers */
+	XPAD_XBOX360_VENDOR(0x3958),		/* RedOctane Games Controllers */
 	XPAD_XBOX360_VENDOR(0x413d),		/* Black Shark Green Ghost Controller */
 	{ }
 };
-- 
2.53.0

Re: [PATCH] xpad: Add RedOctane Games vendor id

[Dmitry Torokhov]

On Thu, Mar 12, 2026 at 10:31:04AM +1300, Sanjay Govind wrote:
> Add vendor ID for RedOctane Games to xpad
> 
> Signed-off-by: Sanjay Govind <sanjay.govind9@gmail.com>
> ---
>  drivers/input/joystick/xpad.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index bf4accf3f581..e97ff270d978 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -585,6 +585,7 @@ static const struct usb_device_id xpad_table[] = {
>  	XPAD_XBOX360_VENDOR(0x3651),		/* CRKD Controllers */
>  	XPAD_XBOXONE_VENDOR(0x366c),		/* ByoWave controllers */
>  	XPAD_XBOX360_VENDOR(0x37d7),		/* Flydigi Controllers */
> +	XPAD_XBOX360_VENDOR(0x3958),		/* RedOctane Games Controllers */
>  	XPAD_XBOX360_VENDOR(0x413d),		/* Black Shark Green Ghost Controller */
>  	{ }
>  };

Don't we also need to add some entries to the xpad_device table?

Thanks.

-- 
Dmitry

Re: [PATCH] xpad: Add RedOctane Games vendor id

[Sanjay Govind]

On Sat, Apr 4, 2026 at 6:07 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> Don't we also need to add some entries to the xpad_device table?

It's not strictly necessary, xpad will pick the devices up with just
the vendor id, since they have the correct class, subclass and
protocol needed for matching, you only really need to put them into
xpad_device if you want to customize the name or give it different
flags, and that isn't necessary for these devices. A few of these
devices are still in development, so we don't have PIDs assigned yet.

Re: [PATCH] xpad: Add RedOctane Games vendor id

[Dmitry Torokhov]

On Sat, Apr 04, 2026 at 06:13:25PM +1300, Sanjay Govind wrote:
> On Sat, Apr 4, 2026 at 6:07 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > Don't we also need to add some entries to the xpad_device table?
> 
> It's not strictly necessary, xpad will pick the devices up with just
> the vendor id, since they have the correct class, subclass and
> protocol needed for matching, you only really need to put them into
> xpad_device if you want to customize the name or give it different
> flags, and that isn't necessary for these devices. A few of these
> devices are still in development, so we don't have PIDs assigned yet.

OK, I'll queue it to the next release then.

Thanks.

-- 
Dmitry