public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: syzbot <syzbot+0a4c46806941297fecb9@syzkaller.appspotmail.com>
Cc: io-uring@vger.kernel.org, kees@kernel.org,
	linux-kernel@vger.kernel.org, luto@amacapital.net,
	syzkaller-bugs@googlegroups.com, wad@chromium.org,
	Kusaram Devineni <kusaram@devineni.in>
Subject: Re: [syzbot] [io-uring?] WARNING in __secure_computing
Date: Sat, 4 Apr 2026 16:20:05 +0200	[thread overview]
Message-ID: <adEeFek83DrfiJOa@redhat.com> (raw)
In-Reply-To: <69953966.a70a0220.2c38d7.0111.GAE@google.com>

On 02/17, syzbot wrote:
>
> WARNING: kernel/seccomp.c:1407 at __secure_computing+0x2ae/0x2e0 kernel/seccomp.c:1407, CPU#1: syz.0.17/6077

#syz test

So signalfd_dequeue() is called by get_signal() -> task_work_run(), the work
was queued by io_uring... Thanks Kusaram.

Obviously this is not the right fix (and we should not blame io_uring), but
lets test to ensure.

Oleg.
---

diff --git a/fs/signalfd.c b/fs/signalfd.c
index dff53745e352..8819dea943f8 100644
--- a/fs/signalfd.c
+++ b/fs/signalfd.c
@@ -158,6 +158,9 @@ static ssize_t signalfd_dequeue(struct signalfd_ctx *ctx, kernel_siginfo_t *info
 	ssize_t ret;
 	DECLARE_WAITQUEUE(wait, current);
 
+	if (current->seccomp.mode == SECCOMP_MODE_FILTER + 1) // SECCOMP_MODE_DEAD
+		return -EINTR;
+
 	spin_lock_irq(&current->sighand->siglock);
 	ret = dequeue_signal(&ctx->sigmask, info, &type);
 	switch (ret) {


  parent reply	other threads:[~2026-04-04 14:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18  4:00 [syzbot] [io-uring?] WARNING in __secure_computing syzbot
2026-02-18 16:27 ` Jens Axboe
2026-02-19 18:53   ` Kees Cook
2026-02-20 13:44     ` Jens Axboe
2026-02-23 19:15       ` Jens Axboe
2026-02-24  0:08         ` Kees Cook
2026-04-04 14:20 ` Oleg Nesterov [this message]
2026-04-04 14:41   ` [syzbot] [kernel] " syzbot
2026-04-05 14:20 ` [syzbot] [io-uring?] " Oleg Nesterov
2026-04-05 14:40   ` [syzbot] [kernel] " syzbot
2026-04-05 15:10     ` Oleg Nesterov
2026-04-05 15:29       ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adEeFek83DrfiJOa@redhat.com \
    --to=oleg@redhat.com \
    --cc=io-uring@vger.kernel.org \
    --cc=kees@kernel.org \
    --cc=kusaram@devineni.in \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=syzbot+0a4c46806941297fecb9@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox