From: Lukas Wunner <lukas@wunner.de>
To: Richard Cheng <icheng@nvidia.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, jan@nvidia.com, newtonl@nvidia.com,
sreddym@nvidia.com, skomatineni@nvidia.com, vidyas@nvidia.com,
kristinc@nvidia.com, kaihengf@nvidia.com, mochs@nvidia.com
Subject: Re: [PATCH] PCI/NPEM: Set LED_HW_PLUGGABLE for hotplug-capable ports
Date: Sun, 5 Apr 2026 09:41:34 +0200 [thread overview]
Message-ID: <adISLoEPYQaKMRWt@wunner.de> (raw)
In-Reply-To: <20260402093850.23075-1-icheng@nvidia.com>
On Thu, Apr 02, 2026 at 05:38:50PM +0800, Richard Cheng wrote:
> NPEM registers LED classdevs on PCI endpoint that may be behind
> hotplug-capable ports. During hot-removal, led_classdev_unregister()
> calls led_set_brightness(LED_OFF) which PCI config on a disconnected
> device, returning -ENODEV:
>
> ```
> leds 0003:01:00.0:enclosure:ok: Setting an LED's brightness failed (-19)
> ```
>
> The LED core already suppresses this for devices with LED_HW_PLUGGABLE
> set, but NPEM never sets it. Add the flag since NPEM LEDs are on
> hot-pluggable hardware by nature.
>
> Fixes: 4e893545ef87 ("PCI/NPEM: Add Native PCIe Enclosure Management support")
> Signed-off-by: Richard Cheng <icheng@nvidia.com>
> Acked-by: Kai-Heng Feng <kaihengf@nvidia.com>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
next prev parent reply other threads:[~2026-04-05 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 9:38 [PATCH] PCI/NPEM: Set LED_HW_PLUGGABLE for hotplug-capable ports Richard Cheng
2026-04-05 7:41 ` Lukas Wunner [this message]
2026-04-06 17:35 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adISLoEPYQaKMRWt@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=icheng@nvidia.com \
--cc=jan@nvidia.com \
--cc=kaihengf@nvidia.com \
--cc=kristinc@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mochs@nvidia.com \
--cc=newtonl@nvidia.com \
--cc=skomatineni@nvidia.com \
--cc=sreddym@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox