Re: [PATCH 2/2] cdrom: gdrom: update gendisk capacity on open

Adrian McMenamin
2026-04-06T10:21:40Z

On Mon, 6 Apr 2026 at 11:00, Adrian McMenamin <adrianmcmenamin@gmail.com> wrote:
>
> Florian,
>
> On Mon, 6 Apr 2026 at 10:20, Florian Fuchs <fuchsfl@gmail.com> wrote:
>
>
> >
> > You mean, because one of the functions in the call tree of
> > gdrom_update_capacity() wants to get the mutex gdrom_mutex or s_umount?
> > I checked the locally called functions, but don't see that one tries to
> > aquire a lock.
> >
> > I don't understand the exact potential of the race condition, maybe you
> > can elaborate, where I should look.
> >
>
>
> Actually, having looked at the code path in detail too I agree that
> this won't recreate the problem the earlier patch addressed, so this
> looks good to me.

Sorry - a further thought. This rechecking for capacity is only truly
necessary if there has been a change of medium - is that right? So we
can take the result of the earlier disk_check_media_change and if that
returns true update the capacity? Is that not correct?