Re: [RESEND][PATCH v5] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip

[Aurelien Jarno <aurelien@aurel32.net>]

Hi Vincent,

On 2026-04-06 11:46, Vincent Legoll wrote:
> Hello Aurelien,
> 
> I tested this on top of next-20260403 + the USB3 patch series v8 from Han
> Gao:
> 
> $ git log --oneline | head -7
> 05054ef4ae1d mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip
> 5f56e5402644 riscv: dts: spacemit: Enable USB3.0/PCIe on OrangePi RV2
> 5b0a2f3f8fa6 riscv: dts: spacemit: Define the P1 PMIC regulators for
> OrangePi RV2
> a05128fa7d3e riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2
> 2febe6e6ee6e Add linux-next specific files for 20260403
> 8ff4869c6f24 Merge branch 'for-next' of
> https://github.com/hisilicon/linux-hisi.git
> e7d27cf6777b Merge branch 'next' of
> https://git.kernel.org/pub/scm/linux/kernel/git/devsec/tsm.git
> 
> Without your patch the board hang on reset. With the patch applied, it
> reboots but there's a WARNING, see the attached dmesg.
> 
> Tell me if there's a new iteration to test, and/or if you want me testing it
> in a different way.

Yes, as written in the original mail, this patchset depends on PIO 
support in the spacemit I2C driver:
https://lore.kernel.org/lkml/20260207-b4-k3-i2c-pio-v7-2-626942d94d91@linux.spacemit.com/

Without it, you might get this warning message and reboot is not 100% 
reliable. I still believe it's better than no reboot support at all.

Regards
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                     http://aurel32.net