From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11CDA5B21A for ; Mon, 6 Apr 2026 16:36:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775493382; cv=none; b=mZ9Fndlo431ztD/KgRr1V9ifdhnlitP8xd3p+SW048L8qvxD+JrMDGD+ibQf/mjV7gs7GSjiklYNem2r6hzEb+MCQi2FHNMpVrgGuosxrUNd22IKhzX6f9bEvlGFYTOILOrOPRt0KPMZQR2U0PmVEdzqbDfr0iFNsUJpTSA5LPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775493382; c=relaxed/simple; bh=rajS4uc0L0+t10VW0XFFtH22sRejpovKT5Dfo/1dm9M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UHv/H7v7uSxahhzl+EuPvHMOoMHAd3UDlqMaY4DS2yZrG//Zt3N3EJW4PmS5X0XQeIAatBkTC0NpFzoDIy3Ghrs3tywZ3uR+/mZOQEKV2h3Hdwa5pL8VDBR6lhdZdpAckEnAbnryGywS/Ct+1FdTs7P0atKjtgJjX2gQ8SBzZLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=GpUOx00f; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="GpUOx00f" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-35d932cc948so2278587a91.2 for ; Mon, 06 Apr 2026 09:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1775493379; x=1776098179; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=oiCiCfseGuUt36OVkBJsO+mSwQagEkjvZ4GHrhi5KdU=; b=GpUOx00fx1p7AGHO45fVjJK205Xl1LYFrUt8QOMEhCZAvJSQOQ0E90UqzCj3VtmOir gce5XjKrKNLtHqwwFU+dKNE287nf40VUmmpcWHBYodh1vL4l55oeK8HSgIWuKTpNdErI 5C0+972tiUybAP308J1Yv3E4P6JSSg+qcYadz+aiks7tKMswnhG9doF9JhVI2dA+RVmK Ll5RTqFEfZOITkm7disUBxoK/5O9C8DqDiBPYKG+XEUiONEreXsJf5rbRHRw3dp2GhCk H+vdvvaxFHauFG3safGc0cV+ctXVuml6+9a6hawBdTQ5YehTMqWZlHX9+tJ0XdS40Frn b8xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775493379; x=1776098179; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oiCiCfseGuUt36OVkBJsO+mSwQagEkjvZ4GHrhi5KdU=; b=c5NayICFPyn0uW+2vgg70kFZH2T+bVYxZXZDl5kB5X6BROgA8Y6VbmSQxx8zl1rkYu TJ+wXSnROOAdZbFLs76iPMtco+/yCOOlkNRAkYm+vCLAjlsO7rjesq7JToaKCc83HBMn fQebP2RILaHtp2yXboHiTa0LUCoFwHcfp4kO9Qk1d34W59+vxi6XY++jTcvLbCcLRP3g qd+VecpxhIzUNwTs6j25Kw5BxO8Dqn7CZ+SelC9wnJQrgnmmq0Mqb4XWM4y2y1QVOORb MQJ0s2Ke3VznW/C41UKyPc4mw5EHbq1kXGsWJKP8NiY5W70Qut7IpUuCijldeUe3WCAL LUTw== X-Forwarded-Encrypted: i=1; AJvYcCUl9zUTSeWhGpZKj8dTYod3UHXV5uTBFftwpmZGtUu8g76I1GNRKPh+tNyByrcE19NHQbzgGviA+G9WpiA=@vger.kernel.org X-Gm-Message-State: AOJu0YzKoAJHsfB5FCBPaeDYx7iHIAhYMq2ecL53cyiBSyxG/wmV83Gu wNQ0m0Iwu1nanAozHiE07Va1XDiL27x4iOc1FFjuZFQgp7Fo2YrwZIN4AptgUthbaL8= X-Gm-Gg: AeBDieuIkofLaBMYYhwu2PHJqlElbKs0/Bmm07/5qM++4daDSW4RUmSgpbrztwr2Jrl OuS5rYak1M48GRA/4eci66muGiySDTt1idmzq5UY4YyA/Oil+wPVBzDepP2MZd68lh/qB/AB22N 2bqjndAeuvt4l6AOvTae+vg1I3/lKNASjLZazh9lvmubMv+ndCv4ZE1FZ3fQHqcRvZcmnTv7fZ1 nV8ygNu4YY1s0zXThNtHhlRgp7X+Wf7MFo7Hr06/tnshFZyy7ez8Kl9x6Fgdj3JkSCzSf3Af98a 9QNbmNbdX7CJlRQ5ER1wsS4X++T9iT2rxKr9jhBlznhU3IZ+oMGBbGrZ8swNsBWROwc2RAbACuO hoIs5YpqSi4pvI6WaZYgaxkNRkeAifQqxWQ6tSba6VM+MpnQNC4xHmAuS5JdSRhQFr1WwcSiH/Y x4ZM3l X-Received: by 2002:a17:90b:1d08:b0:35d:a84d:e27e with SMTP id 98e67ed59e1d1-35de681380dmr12576218a91.6.1775493379463; Mon, 06 Apr 2026 09:36:19 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:72::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35de6a5e62dsm3935913a91.13.2026.04.06.09.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 09:36:19 -0700 (PDT) Date: Mon, 6 Apr 2026 09:36:18 -0700 From: Joe Damato To: Willem de Bruijn Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , andrew+netdev@lunn.ch, linux-kernel@vger.kernel.org, willemb@google.com, linux-kselftest@vger.kernel.org Subject: Re: [net-next v2 3/3] selftests/net: Test PACKET_AUXDATA Message-ID: Mail-Followup-To: Joe Damato , Willem de Bruijn , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , andrew+netdev@lunn.ch, linux-kernel@vger.kernel.org, willemb@google.com, linux-kselftest@vger.kernel.org References: <20260403233240.178948-1-joe@dama.to> <20260403233240.178948-4-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Apr 04, 2026 at 11:10:13AM -0400, Willem de Bruijn wrote: > Joe Damato wrote: > > Extend the packet socket selftest, adding a recvmsg path, to test > > PACKET_AUXDATA. Check basic attributes of tpacket_auxdata. > > > > Signed-off-by: Joe Damato > > > @@ -322,8 +376,11 @@ static void parse_opts(int argc, char **argv) > > { > > int c; > > > > - while ((c = getopt(argc, argv, "bcCdDgl:qt:vV")) != -1) { > > + while ((c = getopt(argc, argv, "abcCdDgl:qt:vV")) != -1) { > > switch (c) { > > + case 'a': > > + cfg_aux_data = true; > > + break; > > These are intended as independent test cases: test_auxdata, > test_drops. By using flags the flags can be combined. Are all > combinations of flags expected to work? Else maybe we should instead > have a -T "test_name", or so, to keep them mutually exclusive and > easy to reason about. > > Or just a test that two flags are not set at the same time. Sure, I can add a two line at the bottom with the existing flags checks. I don't think adding a -T "test_name" is worth the effort, though.