public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Mayuresh Chitale <mayuresh.chitale@oss.qualcomm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Shuah Khan <shuah@kernel.org>,
	kvm@vger.kernel.org,  linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: selftests: memslot_perf_test: make host wait timeout configurable
Date: Mon, 6 Apr 2026 16:01:37 -0700	[thread overview]
Message-ID: <adQ7UZVG9rQ1mOTI@google.com> (raw)
In-Reply-To: <20260402102953.2984284-1-mayuresh.chitale@oss.qualcomm.com>

On Thu, Apr 02, 2026, Mayuresh Chitale wrote:
> When memslot_perf_test is run on qemu, sometimes the RW subtest fails

For posterity, can you elaborate on exactly what "is run on qemu" means?

> @@ -900,7 +901,7 @@ static void help(char *name, struct test_args *targs)
>  {
>  	int ctr;
>  
> -	pr_info("usage: %s [-h] [-v] [-d] [-s slots] [-f first_test] [-e last_test] [-l test_length] [-r run_count]\n",
> +	pr_info("usage: %s [-h] [-v] [-d] [-s slots] [-f first_test] [-e last_test] [-l test_length] [-r run_count] [-a wait_timeout]\n",
>  		name);
>  	pr_info(" -h: print this help screen.\n");
>  	pr_info(" -v: enable verbose mode (not for benchmarking).\n");
> @@ -916,6 +917,8 @@ static void help(char *name, struct test_args *targs)
>  		targs->seconds);
>  	pr_info(" -r: specify the number of runs per test (currently: %i)\n",
>  		targs->runs);
> +	pr_info(" -a: specify the number of seconds for host wait timeout (currently: %i)\n",
> +		wait_timeout);

Why '-a'?  '-t' is available, and seems more intuitive for --timeout.

>  	pr_info("\nAvailable tests:\n");
>  	for (ctr = 0; ctr < NTESTS; ctr++)
> @@ -964,7 +967,7 @@ static bool parse_args(int argc, char *argv[],
>  	uint32_t max_mem_slots;
>  	int opt;
>  
> -	while ((opt = getopt(argc, argv, "hvdqs:f:e:l:r:")) != -1) {
> +	while ((opt = getopt(argc, argv, "hvdqs:f:e:l:r:a:")) != -1) {
>  		switch (opt) {
>  		case 'h':
>  		default:
> @@ -1007,6 +1010,9 @@ static bool parse_args(int argc, char *argv[],
>  		case 'r':
>  			targs->runs = atoi_positive("Runs per test", optarg);
>  			break;
> +		case 'a':
> +			wait_timeout = atoi_positive("Host wait timeout", optarg);
> +			break;
>  		}
>  	}
>  
> -- 
> 2.43.0
> 

  parent reply	other threads:[~2026-04-06 23:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 10:29 [PATCH] KVM: selftests: memslot_perf_test: make host wait timeout configurable Mayuresh Chitale
2026-04-02 18:20 ` Maciej S. Szmigiero
2026-04-06 23:00   ` Sean Christopherson
2026-04-07 10:21     ` Mayuresh Chitale
2026-04-07 10:23       ` Maciej S. Szmigiero
2026-04-07 10:18   ` Mayuresh Chitale
2026-04-06 23:01 ` Sean Christopherson [this message]
2026-04-07 10:24   ` Mayuresh Chitale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adQ7UZVG9rQ1mOTI@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mayuresh.chitale@oss.qualcomm.com \
    --cc=pbonzini@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox