From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2075039FCA8 for ; Mon, 6 Apr 2026 23:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775516713; cv=none; b=OcVyrrQJcibske3F/OnfLb/XcQwXHYSlqqM9npndAByIO+ieMqnGsz7yXUVEqj2dJBOOyOeJToJLDO6j98SMYZ8mJW2XETJASn0PyrFFtEURNntu6IB7XNF9gnTvAGpM9mU0RBgXILdZp+UH0UGJnSxIdvS0UxUbzWZfRJKw2jM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775516713; c=relaxed/simple; bh=ybU40crsJbgKRM+lolfywi67b9/Q/ZY7FuGF+CQZn98=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=apjK4dZwn4XaGXkF0QQ24j5TNTMO+Uskdlt2vMfrcWoH8Wk2k/Z9+HEMTM+WyBRrBlTt44qKPRWDVhS1yuWnqGZV94JC2Ptph5MLe5NjqH77jgOt7KlXGcIWAH2mI9ZY8GtO3h8jokQnn24r9wRRW4jgYfeJUfSwH5tDE7nwj98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Brf3LZJI; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Brf3LZJI" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c76dbf0fad3so1358283a12.1 for ; Mon, 06 Apr 2026 16:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775516711; x=1776121511; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=8U6D1Uqq+dz9m7XIvKQ1cp57uujuAzr1lxBVyWDa42Q=; b=Brf3LZJIkgnrYXRuWEchn3avBLwToCfvvF2UPQeYhuyJszqfK6yNelDDJyTXtgeMKw DQ6Y5xdi4xVYJFhxhFN4/YPTQ5vod0Lz1AFkOkpLsuKkFbLKHgEl/kjJlCOyWfdsaZY3 sBZU8AWmyEiQn1Tg/tbmNmRUniM1bEnjFJL1IyPl4PgwL0plROlsvBS3wG7w6pY6jpaK jw9NUAg5/+mBVHEC4P4Xy0uMR2cRuxaozvMLYHKMA2Qy7qqOf18p98jwqrg3D2Ac8Mdd gpoG6kxCiErVIa9XlP+GgyAPC+5/DvkI3yCLsWFmD/vbggSNZ/OmLtDeKigqun9J0mA9 w7pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775516711; x=1776121511; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8U6D1Uqq+dz9m7XIvKQ1cp57uujuAzr1lxBVyWDa42Q=; b=HYgtRmyrUWCoGD9tHGRiU8sPMukoYUq4cUGb7Y9KOATqX0EVCQLIQaTt43O4QdI2hP n2X3hBjlG8vNj/xYbV4UmMIB/HTMF3DmYrqRToUGxgvUfMRzOGub9mhlE26Va6D5OKMs 7EGgczjcGLOKTAsO8ZNcjRUuChno+buhqE87NtPDg6f7nlqkm/nsSyJCvzfYl4/qlrIk a3ibW3gBDX2KLA+kDUdJ4wdSxExJmAW2m/cSDVg0SDA8rW6TdI+nnxgQfRn2X7Z6tFwK IOIRl6cVVf3Ujq0GQM3a1PxTCiMGkf4dRogrj0Miuze0D5Cv/Gwz5HxaJU21ReHuvxj/ yhyg== X-Forwarded-Encrypted: i=1; AJvYcCVcu1klrYs8pDFgJVQI1SA5rANRYc3C+nKL+btv5X8+xLdfj4LCcajaoopfmxXv9/dYk0DkS1zyigUVVQ0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyqk3/MPadUgf0pr7rVMeZk5qNThJw41+5fBI/6WlKhzJK0Db5v Ku8RHJ6jiSOZHMutVtFWSqGd3Tc4C+eS+wxkTqeYoCBgXJd3x3S4dRBUXM4Rth4/fT4y1MJbRm6 DdmQbNA== X-Received: from pffk2.prod.google.com ([2002:aa7:88c2:0:b0:82c:d5a8:7271]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:ab84:b0:82c:225e:63c5 with SMTP id d2e1a72fcca58-82d0da4cdf1mr13212073b3a.18.1775516711309; Mon, 06 Apr 2026 16:05:11 -0700 (PDT) Date: Mon, 6 Apr 2026 16:05:09 -0700 In-Reply-To: <20250315030928.2373250-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250315030928.2373250-1-seanjc@google.com> Message-ID: Subject: Re: [PATCH] iommu/amd: Explicitly bail from enable_iommus_vapic() when in legacy mode From: Sean Christopherson To: Joerg Roedel , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Suravee Suthikulpanit Content-Type: text/plain; charset="us-ascii" On Fri, Mar 14, 2025, Sean Christopherson wrote: > Bail early from enable_iommus_vapic() if IOMMUs are configured for either > of the legacy modes, as it's absurdly difficult to see that > iommu_ga_log_enable() is guaranteed to fail because iommu_init_ga_log() > skips allocating the ga_log. > > Opportunistically have iommu_ga_log_enable() WARN if it's called without > IOMMUs being configured to support AVIC/vAPIC. > > Cc: Suravee Suthikulpanit > Signed-off-by: Sean Christopherson > --- > drivers/iommu/amd/init.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c > index cb536d372b12..05c568da589a 100644 > --- a/drivers/iommu/amd/init.c > +++ b/drivers/iommu/amd/init.c > @@ -931,8 +931,8 @@ static int iommu_ga_log_enable(struct amd_iommu *iommu) > > static int iommu_init_ga_log(struct amd_iommu *iommu) > { > - if (!AMD_IOMMU_GUEST_IR_VAPIC(amd_iommu_guest_ir)) > - return 0; > + if (WARN_ON_ONCE(!AMD_IOMMU_GUEST_IR_VAPIC(amd_iommu_guest_ir))) > + return -EINVAL; > > iommu->ga_log = iommu_alloc_pages(GFP_KERNEL, get_order(GA_LOG_SIZE)); > if (!iommu->ga_log) > @@ -2863,8 +2863,10 @@ static void enable_iommus_vapic(void) > return; > } > > - if (AMD_IOMMU_GUEST_IR_VAPIC(amd_iommu_guest_ir) && > - !check_feature(FEATURE_GAM_VAPIC)) { > + if (!AMD_IOMMU_GUEST_IR_VAPIC(amd_iommu_guest_ir)) > + return; > + > + if (!check_feature(FEATURE_GAM_VAPIC)) { > amd_iommu_guest_ir = AMD_IOMMU_GUEST_IR_LEGACY_GA; > return; > } > > base-commit: ea9bd29a9c0d757b3384ae3e633e6bbaddf00725 > -- Another ping. This too still applies.