From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66D4421B192 for ; Mon, 6 Apr 2026 23:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775517599; cv=none; b=IhMEi57MJlv8j5jgqGcsbSpppnLWif4JNFyXZrw7rl3kkwh6n69DkIWpA+TvpyNcpt6Ec0eoEGCI2Al4aaau6fCXxs4cUjFGw+PZfgcoLI4580kMUrGZ56w4zfbR63tGrUH1cuS/gSnOwiGi0AVwhUCo0b/SV05coMsX8PwrBqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775517599; c=relaxed/simple; bh=JSi5LjkR76txsPyakVLmmA8nchrLec+P9BgBPbcaXhU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pknSroKOfEli0fMiajvesYv/1ybWxr1JDA441q/qoX/LO+73M0agEFEpzaQlkpbPpwQbb96k2px43u7WMFTI1U74aMfWr3GNnOc5BpueEHDF/6DJR45oopiq0dQlx6b/ID4yYD228q3qAFa1Tzvr0wiZmGBMiRITiN6NSRVX2Kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=tQkRCLyg; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tQkRCLyg" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c766a95a72dso2754834a12.1 for ; Mon, 06 Apr 2026 16:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775517598; x=1776122398; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8HzzZacCRYi94tMXMTYIuvOMhPahDnXa/u6r4ttErhk=; b=tQkRCLygTCtWTb+9tw0dYYw74XmjIe2kXWwUHQd9+KRVy3vTBeUOqCmHp79OYDPZiJ zgugG5bH2dcOKz4W55Cc4+/i73O/VcOx7wLrWa8ITWr8TKp3JwA6ZhXv+U7ehXIE+4yN qDdAkiiFLLPgdBBg+c6c5c684RDb/BRLp/B9TOlKzWhpzS10H7cV3DWiDu5bu3pOtovg EBSZT9qZgQVr9un9UkPtpjkihAbFPydQXxilwf491YbZYqGBhtVFL+QSIKfvQDjX7nby aL+qQ/HPUs03/n9Qd25J0X6v1nLddloqLzOyU2CC+h7dpjZVaQK1VN3N1DXsTvFXs0Bq RZkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775517598; x=1776122398; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8HzzZacCRYi94tMXMTYIuvOMhPahDnXa/u6r4ttErhk=; b=NwEHb/ugnT8V6ACs8Thi0xHxD4HW88STx21rIl66qIQn8fG18vSrL74jLm81Zu24Bo /5OucxZICqoT9mouKVlRqrDZCc7/7NuBU8irRWfrG0nJsPYga5cFQPGLhzuyEV1ih+iJ qK7sVOrgdO+ek4ueKG/V57xgPuINI/HyfptrB8xk0mi7vcGVoAU2+G6mzNBt1YqLLVW9 w/7dVo/CG7c5asq71S1wXUGawIRLZtTqsAtOZlO6Ow226nXnEkglH3//PL7R6bYBBWb+ s2DAGULl9aNrqMLvXRSCj9THB8oMe38CIIcENYMIB1sLttyvDrOz3xXAKxhGrUq25Re7 4uBg== X-Forwarded-Encrypted: i=1; AJvYcCWHsvHHVtQ5jyrY5s5J+UWLHo+CSerEgabqrUM7eW3CEb+TJVCb6Gjt9PRt6hj8kz7dtaIhibhiBMDLw34=@vger.kernel.org X-Gm-Message-State: AOJu0YxijkwJpG2vY+LhwZn71ntS/zaHt6Tj1zgf9tlpm98WZ/hVrZeX lYOjoDy4SB1edCcXHcyaWqHLibGTzsOneArMYxnq5PDD8tyHTp3Xjk+YJm92z2GVjw== X-Gm-Gg: AeBDies/oL20mxWPFjkipuW/N1Vz+gZq/Xv5CjzJzUOMt2Qo4/2GPTjTos1+xnzWPGp YCf2KrXY+saKfjYTFNIWlPWk3W6SmIOu80okparV8OtDRpL+4sMEx0J6LVRfqnCPYWQb5HJn8HP XG0sIkfWgx1z7WayYb3eNkIzQYwIgSwO7iVAZNH3ijGkn/O0UYb5qPeXtMLWMazxsXRZ5C9eIZ7 I12JxKwqgT9zesLOpHSmeFDl+Zkbqt7eX93dXwbNn2neATbQ1YUkPz87WLAkIXZZ4cGfmTRKDfO l2vDL2GpfEW5oIafv0h+DIkO1ZCZg9Nlpfb3tOsa+7Q9fbwBDI9Vkmc+fGo7upcPM0slEB8wwNQ lMp44xJ5Kg1zN0vbUqwtLGfkfxEs1/NL+wKTOY/ZID25wOqIjdTHPZEPOT/DX0E7ordcqM98i4V o9DNRHQ0RzfyD6ErrLMyF6Z3LgYL5ZIjwymP3PWk/0lCprD6Nnjc5LTsluGfkvvg== X-Received: by 2002:a05:6a20:12d1:b0:39b:8ed1:eb4f with SMTP id adf61e73a8af0-39f2eec3ca8mr14985907637.24.1775517597360; Mon, 06 Apr 2026 16:19:57 -0700 (PDT) Received: from google.com (239.23.105.34.bc.googleusercontent.com. [34.105.23.239]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76c65995a9sm12981866a12.27.2026.04.06.16.19.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:19:56 -0700 (PDT) Date: Mon, 6 Apr 2026 23:19:52 +0000 From: David Matlack To: Rubin Du Cc: Alex Williamson , Shuah Khan , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 2/4] selftests/vfio: Add generic PCI command register helpers Message-ID: References: <20260403234444.350867-1-rubind@nvidia.com> <20260403234444.350867-3-rubind@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260403234444.350867-3-rubind@nvidia.com> On 2026-04-03 04:44 PM, Rubin Du wrote: > diff --git a/tools/testing/selftests/vfio/lib/include/libvfio/vfio_pci_device.h b/tools/testing/selftests/vfio/lib/include/libvfio/vfio_pci_device.h > index 2858885a89bb..e5e290eed510 100644 > --- a/tools/testing/selftests/vfio/lib/include/libvfio/vfio_pci_device.h > +++ b/tools/testing/selftests/vfio/lib/include/libvfio/vfio_pci_device.h > @@ -65,6 +65,16 @@ void vfio_pci_config_access(struct vfio_pci_device *device, bool write, > #define vfio_pci_config_writew(_d, _o, _v) vfio_pci_config_write(_d, _o, _v, u16) > #define vfio_pci_config_writel(_d, _o, _v) vfio_pci_config_write(_d, _o, _v, u32) > > +#define vfio_pci_cmd_set(_device, _bits) do { \ > + u16 __cmd = vfio_pci_config_readw((_device), PCI_COMMAND); \ > + vfio_pci_config_writew((_device), PCI_COMMAND, __cmd | (_bits));\ > +} while (0) > + > +#define vfio_pci_cmd_clear(_device, _bits) do { \ > + u16 __cmd = vfio_pci_config_readw((_device), PCI_COMMAND); \ > + vfio_pci_config_writew((_device), PCI_COMMAND, __cmd & ~(_bits));\ > +} while (0) Whoops, missed this in my previous email. These should be static inline instead of macros.