From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC9B33876BD for ; Mon, 6 Apr 2026 21:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775510604; cv=none; b=H0J0TAJivAHi/5/G+wVuy4V5Ce6LKwie+jQfDQ25Ar9gpYyRv+fcij6Hg+BVRw5Goetuq3KuTjqJ4A7CCO5ERBW/mmU7ACbkyASD8t6bOIP4z0nHDT5UHkSAOBEJBGYxbuiWTWjuH9yumS1nZvjollxIRLyCTAmu5Y+1+1uV4+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775510604; c=relaxed/simple; bh=tX3o9f7nD1vUlJVRpS/dXcDlEK/tjAUp+SSuZzHNZTA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V6h6UrI0yfkKVEI+sjPHQMVownoHcY6owRsjw7Qvfb2axJ4owr+ZHnWMzA/1nwYlU7hPl46XJBTvSRdO4l0CpiMzgTkWo6McIvkYcYEN69Op6HB1Noj6I7xq/7/J8m8Tc/fPmlwdevzsVhGA88mb5bmvCmOG0AREcuqK4xfgAXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qa+ULOD4; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qa+ULOD4" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-38df11810abso16271861fa.1 for ; Mon, 06 Apr 2026 14:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775510601; x=1776115401; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=q6xJ/zDoOR7Os811YjMwToE+cggB6rQ02aG/lrQ8U/U=; b=Qa+ULOD4apRCX2U9feio841ira50zG5lvaMQ8vd9xjKNxMPPrhLLOEj2crUIVggrTw Xh8XM/aJn6L0v03N8eqUsWOMi1WnxpWubEJd3aHAZEPUwrTe+/iT6Z6nxIcEjbX6NGFF 3jf10NoMzqpW8ypVyrC+hqp2Ht5C4WU0mDVNl5cqFNO8jhq7N2GUG7hfbe+MvsYNMZ0v WZYBpQ6aWv5D+4T96qqTQ3a2Xd7w4OCD1OIyLfg3qtYqUFy6Oj2ti4UywSR69MSWnOdK TJKatJiP4MN0hQnZA6jLhCoT6OAkky5/1Ja+s4zjPEjgiToiwqmB3L4YqiTVS+c6WSgS gbOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775510601; x=1776115401; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q6xJ/zDoOR7Os811YjMwToE+cggB6rQ02aG/lrQ8U/U=; b=D/+DumiTk83zYCm46AkKyLj7wV8f0K3rvSYHQ1l/tntfvMhxUZ76noU31hCHFttlWu PlUYmSBp5S6dj1uhzER4FYHXsbk7LV0OKZzc+VlwVNJxxbda/KlidqdfqdVvxFILRfIV bd4/5kq8jHhUsHrrMb9lQ9E1Io1owYQYcuev6LN/RSVDSvi0nGnJMq3RkuaAdwEpEcg3 S3mQAmx5qK136eilO6JTvXix4nKjuA5LjjHtOie2zSq7RImZMbJiUTJd/RJXBObmRAFs tZVorFwTjgsATpbFdA2WVIq4heTYpvaSdDcP6z01IKNESxVEZgLu47T6WxYANss+6Wre PVOw== X-Forwarded-Encrypted: i=1; AJvYcCXAY44giBjtppKZcjfTBczwglFzV55mIa9vda0IrDl/3w5kZ8E2BtoQCy3+aLGNutoG2fvFAxrpVtgEz5M=@vger.kernel.org X-Gm-Message-State: AOJu0YyAKokKUGwTWHpPUzOSRxBmJOyIpuCH0BmFOW02oLWKpUola7fO /9QGpOg+hLk6ytic+M8um3QdYCyTbZ1y0J0kyWcTRzt2vLFX46imsmqN X-Gm-Gg: AeBDieswB+nzCrkTgRf6H5gWeP1HvreBFnD71CIQBIc6eabSV3R8bOKI6qqXRBGu67d SA7ghQBLBBLuoCQmUX8BtZJDv2MY2TxZNpRBeafVZLcsA/rgb1I0T0iLtmTPOz5q3pXDQZ9/XZ5 /3mYU1kEtP0ysTg4DhouozOXmAfDcRc0ABSpYk5Ak+5fzn/LSWEUTqw6Zks3tZGZxQTxdu+yoSl xGymKSN6g9HvNQSQ7Cyv3tyudf6VzYxjMWIxwAoS/4+TpPDNaQbW2H2bxbgOaOsjUv2gnw7muUN 9sPMMLSSgyea5EJLXk+yWP2B0FjHPE2/bt5AoEezjohfB+iWLmOv1K4VZvmNiwr6ZkpQjwOdR07 flnQx9hi7/PIzL2pW7/N23TCuY7TKw3v0f62eNiiUgCYaJpeYD56cn5gv7jXSroZSzUtddtpm+S WEv3EUisOxUS7kUW7oka40kx90fUM= X-Received: by 2002:a05:651c:1a0a:b0:38a:3498:e2f5 with SMTP id 38308e7fff4ca-38cd6e4f078mr57915391fa.15.1775510600748; Mon, 06 Apr 2026 14:23:20 -0700 (PDT) Received: from localhost ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38cd1fffb53sm32700151fa.16.2026.04.06.14.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 14:23:20 -0700 (PDT) Date: Tue, 7 Apr 2026 00:23:19 +0300 From: Andrey Skvortsov To: Dan Carpenter Cc: Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] media: cedrus: Fix missing cleanup in error path Message-ID: Mail-Followup-To: Andrey Skvortsov , Dan Carpenter , Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260401191441.1217646-1-andrej.skvortzov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Hi, On 26-04-02 16:09, Dan Carpenter wrote: > On Wed, Apr 01, 2026 at 10:14:40PM +0300, Andrey Skvortsov wrote: > > From: Samuel Holland > > > > From: Samuel Holland > > > > According to the documentation struct v4l2_fh has to be cleaned up with > > v4l2_fh_exit() before being freed. [1] > > > > 1. https://docs.kernel.org/driver-api/media/v4l2-fh.html > > > > I wish the commit message would say what the use visible effect of the > bug is. I looked at it and I don't think this patch hurts but I also > didn't necessarily see a that the original code had a user visible bug. > > I read the documentation but it wasn't as unambiguous as I'd prefer. > Thank you for the review. Currently there is no visible bug. v4l2_fh_exit() in this case only destroys mutex. But it may change in the future, when v4l2_fh_init/v4l2_fh_exit will be changed. I think the change maybe useful in this regard. I'll describe this in the commit message in v2 and resend it separately from the patch 2, that fixes actual problem. So this change may be skipped, if maintainers think it's not worth to apply. -- Best regards, Andrey Skvortsov