From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E81D738C425 for ; Mon, 6 Apr 2026 23:55:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519711; cv=none; b=PILku6XkMANIfsnx9QdmaYwTrSco+Sx30dMz7SETn+TVVwz2/rK3teUhstj3fgLllxUZoypDL5ZThDbuUNL61wWZ2d+JW5kFTJ/+bRTUdQO2if0RDMv0N/afCoTALaD7aZpjqPtBOcnRQNxyze1ghbGq191hRk0VwSjj3H2weSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519711; c=relaxed/simple; bh=84an9p8C4RVxD3NXmRlh5HGIQzqLyxY/fvfESRAomG8=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:References; b=HPrWfCekanPjLS1sok5+jCXbV4bSZYdP3134/ptSbBz64k6GvB79fXz4CsscLZ1vnYRJ0GovhJqxOQVmXYf/QHUb7uny25zWrDZhMsQgDz7AbLBP7awaO0RstQ467jENLgksjFZUsLHYywgFbqFHhCalrOnoOZJBjasEsQbTDP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=orb.net; spf=pass smtp.mailfrom=orb.net; dkim=pass (2048-bit key) header.d=orb-net.20251104.gappssmtp.com header.i=@orb-net.20251104.gappssmtp.com header.b=AsCvZ1W+; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=orb.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orb.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orb-net.20251104.gappssmtp.com header.i=@orb-net.20251104.gappssmtp.com header.b="AsCvZ1W+" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2aaf59c4f7cso20136175ad.1 for ; Mon, 06 Apr 2026 16:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orb-net.20251104.gappssmtp.com; s=20251104; t=1775519709; x=1776124509; darn=vger.kernel.org; h=references:in-reply-to:content-disposition:mime-version:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=928edzxFlqN/Z48RQN0M8E84sJTAtb1fJmgV5h9KVWw=; b=AsCvZ1W+taCh5bUiKsRvx42N1vM/2pkWkvMd7Zs92eu95FtCqk3kJki67nZkZ/wCyI DZjX3xzSLR/xNJAQcqUjAIijw3p6+BUbvfulPHBvuGEM4lr2Q6EiW/nMZBpH1IninBuZ 9Sn1F9L44I0nKlyfQlrwdrikHt4sYcRER+VMSP28z35wP0zI/vqTHZzYacz6IHtr5lmK ykUNC/zmDwKS5PyZNGHoAknGk1ABMHkQnmM5rzfcvJ3ivQFupiytVFqhSFwzpogau6ja Ul+g6Vvob6nAZ+94dlGF0d56uC+4rK8EKw8Yos7+au9aDQ5maSVoEM6oX3qhTGj81Y80 oB+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775519709; x=1776124509; h=references:in-reply-to:content-disposition:mime-version:message-id :subject:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=928edzxFlqN/Z48RQN0M8E84sJTAtb1fJmgV5h9KVWw=; b=B1BS3tB/HtSF0LQ2Zr3YJj9ArSILQ8EyASnj6BNC6nAHc31xCoYEpXeqBfnDLHmSI4 XoLlxin3PxTTKuOk8zm+Gh77Lak20wzJt6pLwvaS88RtV5PgzZd56tZi86k7/fV10LHd FGc/2rQNosW3Jr8P/xX3axaZVknv9uC4L0idf3GkXCY2xJCteyOUxNneDb7w2dEQDXNN 9Gr6TGp9sXlFOzvzMso3dNagl1wGBG/R0Px81PD0ETKS1VzdhdRX0hO3PHhCHBLOpAyz pDZiCxcmuT9UWSE6C/Z8Af8eqIOGldPupeDS9h8avrsLOzJ2PYOEBkkUPb1AYg9Cmky/ /zjw== X-Forwarded-Encrypted: i=1; AJvYcCUPOdmJO82+B70qs7e1WqQikkRvGtxvPuY2Y7q4BepiOflIUfYWfQ17MsCdFPMtvuIAXDaMnRmFOyQsMKE=@vger.kernel.org X-Gm-Message-State: AOJu0YyhQzMQK8Nq/7ukb8rrFJQhDYzcsKEcoiC1p17PYvemGOx3RPl2 SRQufyNEaqR5lwZJ19+G2GDQXDN1goJhZI8OzdSzN8FcZU6cHKebGtpYQuJtJxHpYHCoiafeZKs GL6I/CQU= X-Gm-Gg: AeBDievHJUf0cGbZE/Jl8Ewyx6DWVJvsr4XAh7fHiMtE9LNqBP3La/xDros3todTuEq 3OLRgzzlvzwHB0FModFHeK79i7L70Rla9XrvgSQVvV+MgxO5oelvAcCE69yShEFB/rOTP4m67N9 ZNdtkaoiCLskdAyqp4waLC8UQ9pMF/KAF1vxW6pMfdT/p6bw3PUTi9N+gp2Cb+7tyi8oBy6b2m4 Ah5AT7pT0NPdIpEEJNoFqq+er7K91/JckhVuDBdv8fXKi/q+OMjSbDx14zTtYclYjVuS09QD4OD XlPt4Y69jmlDDnvDAKQkJmMT8tQ/5TWnUFpan+iisOqtpGMBpVqajGFIWprrI473XddECNY63Xt ZbBPvNWvixJlAHFZWyDTzUDyiEh+DSaZ7d68DyB9R69iKburCblIoVp2T0SvaBtD1Cpx2TDnvnQ WoTKL7lLjVkWXHFmYef60mNGgbFeYKVOCXWTGDpZNNYKr2xJ2msekPPWZi6JukPBGdWYTPmawG X-Received: by 2002:a17:903:2f08:b0:2b0:67fa:dbf8 with SMTP id d9443c01a7336-2b2817e97b9mr152039645ad.41.1775519709263; Mon, 06 Apr 2026 16:55:09 -0700 (PDT) Received: from claude-dev ([50.125.94.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2749cbc58sm155836415ad.78.2026.04.06.16.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:55:08 -0700 (PDT) Date: Mon, 6 Apr 2026 23:55:07 +0000 From: Daniel Bozeman To: shawn.lin@rock-chips.com, finley.xiao@rock-chips.com, jonas@kwiboo.se, ulf.hansson@linaro.org, heiko@sntech.de, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] pmdomain/rockchip: skip QoS operations for idle-only domains Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <693c6c27-6ff2-4ab0-994f-3821e5ffcec8@kwiboo.se> References: <20260331180223.1682283-1-daniel@orb.net> <5c8732a3-6cc9-5d02-f56b-fc7ba29c7ce0@rock-chips.com> <693c6c27-6ff2-4ab0-994f-3821e5ffcec8@kwiboo.se> Hi Jonas, Thanks for digging into this and identifying the GENPD_FLAG_NO_STAY_ON connection. I tested on your next-20260403-rk3528 branch (7.0-rc6) with the NanoPi Zero2. Your conditional NO_STAY_ON patch alone results in a NULL pointer dereference crash in run_timer_softirq during boot: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 CPU: 3 PID: 0 Comm: swapper/3 pc : run_timer_softirq+0x258/0x2c4 Call trace: run_timer_softirq+0x258/0x2c4 handle_softirqs+0x18c/0x1d0 __do_softirq+0x10/0x18 ... do_idle+0x94/0xa0 The crash is caused by the EPROBE_DEFER teardown in rockchip_pm_domain_probe(). When PD_GPU's clock lookup returns -EPROBE_DEFER, the entire controller probe fails and tears down all successfully registered domains. This corrupts timer state and crashes in run_timer_softirq on the next tick I think. Adding the following on top of your fix results in a clean boot with USB working: for_each_available_child_of_node_scoped(np, node) { error = rockchip_pm_add_one_domain(pmu, node); if (error) { if (error == -EPROBE_DEFER) { dev_dbg(dev, "skipped node %pOFn, ...\n", node); continue; } ... This skips domains that defer and continues registering the rest. Skipped domains have NULL entries in the provider, causing their consumers to defer until the clock dependency is available. I also tested on 6.12 with backported RK3528 support (OpenWrt). There, GENPD_FLAG_NO_STAY_ON does not exist, but marking idle-only domains with GENPD_FLAG_ALWAYS_ON prevents the genpd_power_off crash. The EPROBE_DEFER fix is needed there as well -- without it, the probe teardown/retry produces a timer warning in __run_timers. Test results on NanoPi Zero2: 7.0-rc6 (next-20260403-rk3528): - Your NO_STAY_ON fix only: crash in run_timer_softirq - Your NO_STAY_ON fix + EPROBE_DEFER skip: clean boot, USB works 6.12 with backported RK3528 support (OpenWrt): - GENPD_FLAG_ALWAYS_ON only: boots with __run_timers warning - GENPD_FLAG_ALWAYS_ON + EPROBE_DEFER skip: clean boot