public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: John Pavlick <jspavlick@posteo.net>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Marcin Nita <marcin.nita@leolabs.pl>
Subject: Re: [PATCH v2] net: sfp: add quirks for GPON ONT SFP sticks
Date: Tue, 7 Apr 2026 09:18:32 +0100	[thread overview]
Message-ID: <adS92LVr5_rnBzMv@shell.armlinux.org.uk> (raw)
In-Reply-To: <20260406121716.69854-1-jspavlick@posteo.net>

On Mon, Apr 06, 2026 at 12:17:21PM +0000, John Pavlick wrote:
> Several GPON ONT SFP sticks based on Realtek RTL960x report
> 1000BASE-LX at 1300MBd in their EEPROM but can operate at 2500base-X.
> On hosts with serdes fixed at 2.5Gbase-X (e.g. Banana Pi R3 / MT7986),
> the kernel rejects them with 'no common interface modes'.
> 
> Add quirks for:
> - Hisense-Leox LXT-010S-H
> - Hisense ZNID-GPON-2311NA
> - HSGQ HSGQ-XPON-Stick
> 
> Each quirk advertises 2500base-X and ignores TX_FAULT during the
> module's ~40s Linux boot time.
> 
> Tested on Banana Pi R3 (MT7986) with OpenWrt 25.12.1, confirmed
> 2.5Gbps link and full throughput with flow offloading.
> 
> Suggested-by: Marcin Nita <marcin.nita@leolabs.pl>
> Signed-off-by: John Pavlick <jspavlick@posteo.net>
> ---
> Changes in v2:
>   - Add Suggested-by tag for Marcin Nita <marcin.nita@leolabs.pl>, who
>     suggested investigating sfp.c quirks as a solution rather than
>     attempting to edit the EEPROM data directly on the module.

Please read the maintainer-netdev documentation, particularly on
submisison of patches. You need to specify the tree and also avoid
resending within 24 ours.

Patch looks fine.

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

      reply	other threads:[~2026-04-07  8:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-06 12:17 [PATCH v2] net: sfp: add quirks for GPON ONT SFP sticks John Pavlick
2026-04-07  8:18 ` Russell King (Oracle) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adS92LVr5_rnBzMv@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=jspavlick@posteo.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.nita@leolabs.pl \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox