From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E017B348898 for ; Tue, 7 Apr 2026 05:12:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775538743; cv=none; b=r/Zs8tZ4mtoWXgTVNzAg5ItTxAIMeGeG2r28ST9NIasUA2ZYiGIA3nPvdAPn+B1CAgswTjsGwwE82WKPQz5hquTF++Ig5fy22AUCKz1gC/ua6Q2iYaRlqc7b/XiH3GgSd1RlFm+DHBj0wjcyl9myIztgh5OZnKnphSMVBlou45s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775538743; c=relaxed/simple; bh=NvIgwFBoRmnGdZdeZvaypcoTTtxYs4s8WUzw1wl4B+A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dq4SVQf4z46t/Gf3THdmHkxsvputsvUs05ZzFJ33scg8NcgjF8tuTGaTenYIUrWVo9klBOKAmeoYsZtv+EnJ/FZVzPSahKbRlIzAGDHiZc60IFlYVVnoYYGDbWbqLexHXtYiYYNWmlq6Pjuz3qmuGVnBzLw9xrxcARFvSJhjx3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fJcLPyZx; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fJcLPyZx" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-2b4520f6b32so5112799eec.0 for ; Mon, 06 Apr 2026 22:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775538741; x=1776143541; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fryNqpmXT/hLyfHB5KpmBEVnPCa51Kg7pCyMCICY3II=; b=fJcLPyZxlwAX4b7y52oYK/ITLe26bOjEb7s1g1VKE0+2F0sbuHN7IWxlpuDWOqDGmx pGnULHQRZ2MuCc17NzBTXxUE5gBYT3EWet7jgdCcVILYNZyHHRGMoXuyDaoTPVdUfv6Z O5zfK6q7yXy8L+/baB14DMxvk0Csfc1AFQtyH5yowuBjDlvyXvXYK/N+Pg1hbCahuLrq qGGyN3bSn2HY4sfikfIuJhYQbWZhy3qYeterzuA+SahAiOxONY6bqrGHGNla4guNKzn8 kNp2wSu++OMcmuWmkUmZgidq5axBKf+BbzSpSWnXdAs20BFOVrHmnBqd7zKGh1JyjxiJ DuTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775538741; x=1776143541; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fryNqpmXT/hLyfHB5KpmBEVnPCa51Kg7pCyMCICY3II=; b=P3qmUzyXV8FPAHpj1+9LwPi42MEOFB9xDeWdJ6C7SllUBeOW4A/z6V2ZU+qEOLKRm8 fOSjpnVXj2kO21zp6Eb6KmKBov07n1QY/vaV6wFVBXDMXlVL2QzklQLlsE7yEwyXCYMy e3Z3ix1jWivImB2vlJG7Yd464iHHp5ukcotUZAKYrIlpXMLVexp2QBhblma2YEEl16VE LO3OkbwGOTjVZTKalMI03NC0WGIBu7y6DUZet6LWaTYJU4thbYXIPzeanMQBYe3a3Vzb WRYT695n4jPIfcPEXrq3Bxg3JwJM8uZicOg+rk+NlW9qMMinonZjJLMFFvzcLoE6qRuH OX6A== X-Forwarded-Encrypted: i=1; AJvYcCXzhF/jpVhRBWNvuWnprXyeQsLh6K3psCeqekYbG+PtXz6zx4byHOcTXP2T9/XTjEAluclMmYCBgwaVnlw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxu2ROWVsjd+zd7pmdMOGYo81evTRYPROc1DFQeEbC9YNRBrKud aISuQ+ENcfyzPc8qafsbCj0QUChDh2aI/7cAmc8lIIduHHX2jPB2ThEG X-Gm-Gg: AeBDieu/J4PXNC+3qoerFc8jBSaUJJuYzNXHX0MwPrP9kcGXnjpUPuPwUGtkQI2fh+k rHfOXyMXlT3YD/W5ppmQw0Bz3qHIUKZKIrzq55lGeEMlv8lR+iMqVy4s+CDWv8NwcYGWfpJLk7X +YriLta0oegCjqZh9obEfZIHKq/PFe6j35dESD4+Xw7GsVQzPmThGz0ceIpAHfeq5Ix0IBdO0zx TKSPoF/R9oWlH+gdYahXyaRrdX+d6xKG05+xWOJ0Naj7oTUN+E80RX2pBNbS2dCTmms45CmlmPL jXiCYrcaMe1ufIzdyXW701cNQvMwjfKRc55bhqLcmYH9YN9i1PPpPy9VUGoemf0udnN/b3xjXbS TPM9U0KXSN8QLtiUxo+Am02MhxwhV3e+TGGRYhgv8eUsYTHmfJTUQzWyuVKEO72eiw5UQgiR7gi gipW7pCOZUmaaUUqTEwgtRTHFsOMz+vQf34qexuSgj0LRhmE/3wFPc+SjlGKLP0z+9NXnxv8hRQ rs= X-Received: by 2002:a05:7300:571e:b0:2c3:9406:d574 with SMTP id 5a478bee46e88-2cbf99ef349mr7235195eec.4.1775538740798; Mon, 06 Apr 2026 22:12:20 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:dd71:7176:b4e4:a7a5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca7c20c151sm15834673eec.19.2026.04.06.22.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 22:12:20 -0700 (PDT) Date: Mon, 6 Apr 2026 22:12:17 -0700 From: Dmitry Torokhov To: Pengpeng Hou Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kees@kernel.org Subject: Re: [PATCH v2] Input: gf2k: skip invalid hat lookup values Message-ID: References: <20260323074541.93413-1-pengpeng@iscas.ac.cn> <20260407120001.1-gf2k-v2-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407120001.1-gf2k-v2-pengpeng@iscas.ac.cn> On Tue, Apr 07, 2026 at 09:56:52AM +0800, Pengpeng Hou wrote: > gf2k_read() decodes the hat position from a 4-bit field and uses it > directly to index gf2k_hat_to_axis[]. The lookup table only has nine > entries, so malformed packets can read past the end of the fixed table. > > Skip hat reporting when the decoded value falls outside the lookup > table instead of forcing it to the neutral position. This keeps the > fix local and avoids reporting a made-up axis state for malformed > packets. > > Signed-off-by: Pengpeng Hou Applied, thank you. -- Dmitry