From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8720F34EEEE for ; Tue, 7 Apr 2026 05:12:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775538751; cv=none; b=Tc1mOJLZVpjAISeUvMUdp3kPAesmUDBjspf/1dtQ1cR5hw6Km3wi87bqT3/SJMQwlxToBeaEj+H/vF5/xBTTCXftKS7iAhXknlJ0LmluiGfNoT/FXhesr2Gt21v6KXI6pGqh6RzzeaDuPfNW1cyyd/7+hsGwALNu7wUVQZy0Cz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775538751; c=relaxed/simple; bh=3yhpx7HD5OMFHH7Yvf2pE9Z/a3eaoD+f0oluE21YBqk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RlxkebKROstZPxtALphQjxk5guaBmtpTkMxuOhU5IUslYcTBZ04Mn2X9RuJJPZ9P3Y3I8cfe6KNyzVIKrx/IJ1KQ9qUistOHgekEUABp3esyeLGe2IHasM/uCFw9Tc1E14G1V0O/u3ob/e1dGw+QyoUzwAqNfigpXfkQ6GiZKLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L1+XjndI; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L1+XjndI" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-1279eced0b9so5326362c88.0 for ; Mon, 06 Apr 2026 22:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775538749; x=1776143549; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AT8awfUYL3Ueog4ZWDVYyrhcHmBHrI80IMobe7yuldU=; b=L1+XjndIaUTVUoKNglORtzNUBdI8of0G/r5/BYKSPLFdRzQCaPM6IuKBcc3Mr8f6OY zWfaLeVs5kjvofRSk8p1HRYWmzI20BTjHRUgsJbnpaxw7hLKQk7PjEnn56U+puXRlLSF nOsNA0s/RCzCO9jeZVljisEJyZlISYbKBoiqQG/5KAo25W3FvXwG+BJ+3Z6Lx7N0waOM TxzxuhV7SoV/R5wvnsB5u7wWNWNpXnF9hCZiLKWWy5JYKjRWEHf4UPykuHk+cvb/hu8g Tf2AaR1Qq7ssmV/Y6OZ1V5ZWsbHz7iLNWvTdjxmcHDBl/LdK4bk2s8oEb3uAo4Dm2n/k H8NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775538749; x=1776143549; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AT8awfUYL3Ueog4ZWDVYyrhcHmBHrI80IMobe7yuldU=; b=Pico/MByDGrXMj5+flebYDeiG6wE1XNCRybtTExnJRKZ1IXGDulmwLyJdAo0BcDKvE GYX0jX7tfkB5OLSzFPfjhzYM4dEVg+a9SrpFZoYoQhCTjHiHbMPefvf6h9X0OARIcBRI 7wkBwIghed8lrENQTW0U7xlHbz4Txr74D8JdmobJKlNH7G+XwCwd9BPisRGnpjqwCsqE Q6gbLj0o/UUaYUVE+0yFVo8v7qa06lXdguXbUaUtAkHnN1sslVusrIyleJGYVYW9bzT2 fBRRG4ZvML+5U6WcGJPNdCDF8sET1yMybhrAFzz5Y2KtjdFUu3RY9Nu687IoFvP3enGZ I9YQ== X-Forwarded-Encrypted: i=1; AJvYcCVyeSYAowg4HfDAGQHY+4NK0gIQXOLs4XGtSk4X+IncG3tPVtunNNNu7HzMKybxyLy3QFU2NaIETp3I2iI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywoy/EaS6FCbBQORUGS8qfje3KeSHD3elQ/B6ABW0QQryx8uebW V22+M44rs6fGTEfxd4tG7gbkt7MjhX1MDPPDvRb4+Rp82D8Pq4KzdphC X-Gm-Gg: AeBDietrTYAUb1qt4upE5i7GfjDVzphJXrPv5NmISZm3aAupHzwmPYx1w554nNHoIJz Yzyd3SefJUp+oNR6JkhtUC5E4SddBb7egH/teTwx+2smrlSnwVjFUZ63quzPNT7ZHoc63CEQAMG VmrxiFfLAOWYW0ncpSsdS0Ve9vL1MXBSjaClyS0PP8iwIRiemqYHJdm0oOH/Nm+ulvr0Fg+y2wv ZzLTLcejjlYNAjxfZr/yO3u6OmO60PoD86UIshdBoFkUcCn1E4PCFFC6lLCP541uKnZnHZKn1g3 aVO1bE038JzMgyTVIeaKJG6Qe3NkrAFmt9wzy+pb6ZWnb2TZcz8pm1T3BO0ePvHec/102/ddWvk kpiibvOg6JqY6ylglgrEWljsbycGtt14hoQOf7XYVCDL3+oQYsaVuC6LjO74nE6BFf6L2CUVf0v 7BGKzG5rni4/epFDsuzSSfa76Y/ioQ4kOHbG2XzHsLuttqzp9RRzm5XMI1VIOZMg9N X-Received: by 2002:a05:7022:b9d:b0:11b:99a2:9082 with SMTP id a92af1059eb24-12bfb707941mr6463592c88.15.1775538749505; Mon, 06 Apr 2026 22:12:29 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:dd71:7176:b4e4:a7a5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca78df5ec7sm14710514eec.3.2026.04.06.22.12.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 22:12:28 -0700 (PDT) Date: Mon, 6 Apr 2026 22:12:26 -0700 From: Dmitry Torokhov To: Pengpeng Hou Cc: andriy.shevchenko@linux.intel.com, kees@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Input: aiptek: validate raw macro indices before updating state Message-ID: References: <20260323070311.42849-1-pengpeng@iscas.ac.cn> <20260329001711.88076-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260329001711.88076-1-pengpeng@iscas.ac.cn> On Sun, Mar 29, 2026 at 08:17:11AM +0800, Pengpeng Hou wrote: > aiptek_irq() derives macro key indices directly from tablet reports and > then uses them to index macroKeyEvents[]. Report types 4 and 5 also save > the derived value in aiptek->lastMacro and later use that state to > release the previous key. > > Validate the raw macro index once before it enters that state machine, so > lastMacro only ever stores an in-range macro key. Keep direct bounds > checks for report type 6, which reads the macro number from the packet > body and uses it immediately. > > Signed-off-by: Pengpeng Hou Applied, thank you. -- Dmitry