From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 344DA265606 for ; Tue, 7 Apr 2026 05:17:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775539030; cv=none; b=XGg9vg9zvt0PWCfroK+swX4x/pvGii7f7StdpqLrQjZl8cabC6YnIpX5xs4ofY8wtFnnZqouIPJkh0MCEKiMdmX66mb38IGdEpi6y2DBtPgbAkKL+tQOJBAUJuKntf432PnormhwKetuiQFxf0WJwe6gfiZAGTwnRTyiVP0P/d8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775539030; c=relaxed/simple; bh=EzrJm1ocb4GjEbBKyMY8dfyMAs/0t1KoFn58M5u1oNY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pImmWN6E5HgFzPyCpIS6n0cJgLiSJqybk5M12zzdv3GWTy6zFd0dNVjUnp1mDRS8IcpQRDTaEUKGzdbiP2CMa1HOCTBNfm/RvncTRG3aaxi5Z7lhNcsUeTIyzusBSgU1HK1PmM0UX2GIFqlWwBQwriQtxL35tot2L7kCn3H/QY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=qQ9j0XJj; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qQ9j0XJj" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Sbbf/Es9EHf9oX0aipQYxujSayx6etDkff7GWf6Q9iQ=; b=qQ9j0XJjyOLeAHkRBk4e2Y3Szx 4KLycOyh8bozBXuDczTFZ8JewByuDN5K0HiE3r9jwX7N0N5R4ZS0bitKKIvBDRPUFbk2cSBBjLsuV hfDJCezNtVvZSmcmmX9taZ6QjFslpcA4NiTS5ydDqs9xNO+Kd3hHP0q6Aiw4KRwRNEX3SfdLO5XqP Xr2cXMDGwmQFta0McxXA1p5JnAQM3xYsiyCInPCALH+3w0wDM0qLCYJmMn3bCE1YgDCnLYH6/OLzn EpepWdbJxLIpNUbo1i5KdusfPK7QyfWL6HaS1k93ZByjjhVpCam4CgyMHGDCvQT7EG56kPz1ddiXL kzO8up/Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1w9yoF-00000005uE2-02Qt; Tue, 07 Apr 2026 05:17:07 +0000 Date: Mon, 6 Apr 2026 22:17:06 -0700 From: Christoph Hellwig To: Jaegeuk Kim Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] f2fs: do not support mmap write for large folio Message-ID: References: <20260406154940.2407853-1-jaegeuk@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260406154940.2407853-1-jaegeuk@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Mon, Apr 06, 2026 at 03:49:40PM +0000, Jaegeuk Kim wrote: > Let's check mmmap writes onto the large folio. Why? And how is this not breaking applications? > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index 2c4880f24b54..edfc3a374c40 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -82,7 +82,7 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf) > int err = 0; > vm_fault_t ret; > > - if (unlikely(IS_IMMUTABLE(inode))) > + if (mapping_large_folio_support(inode->i_mapping)) > return VM_FAULT_SIGBUS; > > if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) { > -- > 2.53.0.1213.gd9a14994de-goog > > ---end quoted text---