Re: [PATCH v2 2/3] perf config: Make symbol_conf::addr2line_disable_warn configurable

Namhyung Kim
2026-04-07T07:31:14Z

On Tue, Apr 07, 2026 at 08:58:54AM +0200, Thomas Richter wrote:
> On 4/3/26 04:12, Namhyung Kim wrote:
> > On Thu, Apr 02, 2026 at 10:01:58AM +0200, Thomas Richter wrote:
> >> Make symbol_conf::addr2line_disable_warn configurable by reading
> >> the perfconfig file. Use section core and addr2line-disable-warn =
> >> value.
> >
> > I think it's better to have it under "report" or something. But it
> > seems we already have one in the "core" section.
> >
>
> ...snip...
>
> It was added to the core section of the perf-config file by this patch:
>
>
> commit 701677b95764 ("perf srcline: Add a timeout to reading from addr2line")
>
> submitted by Ian Rogers in 2023. That is the reason why I left it in this section for
> backward compatability.
> We could also move it to the annotate::* section. What do you prefer?

I think we should keep it under "core" to be compatible.

Thanks,
Namhyung

>
> I will add the other remarks in the new patch v3.
> --
> Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
> --
> IBM Deutschland Research & Development GmbH
>
> Vorsitzender des Aufsichtsrats: Wolfgang Wendt
>
> Geschäftsführung: David Faller
>
> Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294