From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D513121256C for ; Tue, 7 Apr 2026 08:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775551114; cv=none; b=HYjZL0j6S4Kn2VXUGeB97jhu4CyaTbc8yYEezXX6kkS35GtlTWmKP/+sg1WQp1SMNGv4uVDir2zuZ+VZMqa3PWw+JvAkGclNlFyQ0V2DequorR1b7zNJyMPAU64H7ErAOAQPrZbQyJ5olvGUMxhGNkVn/KTeXwaqJPrWESCep4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775551114; c=relaxed/simple; bh=TIqAwjU4p9/Fjo55FqfesuPnIvzREogR4DdDD++Ha3Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Klu4rIxQMpPjThDNwrvMjr+bgvWQQcXu/+iyvRJI0kaMHJZAzZNf/4UgxSC5l+ejSlUWI9qRHPszQx5RhOV0fsoGIDQRv9mxpSKFaOxh0CWORSpi+5CdURSskubmhAyZvUM9prAp7BqLZTzxfhXfDOwb4rIh4pvfGNcA63Qneow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Av5Oge3U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Av5Oge3U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0F10C116C6; Tue, 7 Apr 2026 08:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775551114; bh=TIqAwjU4p9/Fjo55FqfesuPnIvzREogR4DdDD++Ha3Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Av5Oge3UETJyIIcmTYUA487LmfI8kVI0LKPw0cYKj0WbFsIMzwU/k60JYoWrm8sh0 OoCHkEGhENBpeL6GE6d9W8sDK8B6aod5DOorbOMVJ1Av8WGTQow2O7ISuDz3VDU1Ui 8jsmDjmHDI3OXTB+GtaBw0qAx2WRAEsWyItTCTHz5lrMVS8eCFOk2Q8oEnct0tCSxU xvMeYXZdBDxJCQVCLa2J1GzDkgpbwt1NJc5OWmjCMuk/O8JaKQd5Kp4SIAAGsSI5Tn WBkt4O5m6zVKEU+lPukCg57Li9SHgz9x1YFAaldShbWLA52ShhGqovp1d5kUemMCBq ED3+0AKuPUCAQ== Date: Tue, 7 Apr 2026 09:38:19 +0100 From: "Lorenzo Stoakes (Oracle)" To: Andrew Morton Cc: Nico Pache , "David Hildenbrand (Arm)" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, aarcange@redhat.com, anshuman.khandual@arm.com, apopple@nvidia.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, byungchul@sk.com, catalin.marinas@arm.com, cl@gentwo.org, corbet@lwn.net, dave.hansen@linux.intel.com, dev.jain@arm.com, gourry@gourry.net, hannes@cmpxchg.org, hughd@google.com, jackmanb@google.com, jack@suse.cz, jannh@google.com, jglisse@google.com, joshua.hahnjy@gmail.com, kas@kernel.org, lance.yang@linux.dev, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, mathieu.desnoyers@efficios.com, matthew.brost@intel.com, mhiramat@kernel.org, mhocko@suse.com, peterx@redhat.com, pfalcato@suse.de, rakie.kim@sk.com, raquini@redhat.com, rdunlap@infradead.org, richard.weiyang@gmail.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, ryan.roberts@arm.com, shivankg@amd.com, sunnanyong@huawei.com, surenb@google.com, thomas.hellstrom@linux.intel.com, tiwai@suse.de, usamaarif642@gmail.com, vbabka@suse.cz, vishal.moola@gmail.com, wangkefeng.wang@huawei.com, will@kernel.org, willy@infradead.org, yang@os.amperecomputing.com, ying.huang@linux.alibaba.com, ziy@nvidia.com, zokeefe@google.com Subject: Re: [PATCH mm-unstable v4 5/5] mm/khugepaged: unify khugepaged and madv_collapse with collapse_single_pmd() Message-ID: References: <7760c811-e100-4d40-9217-0813c28314be@lucifer.local> <0223d45b-e8b4-49a7-882b-477250d0c14d@kernel.org> <26fcec86-ee78-4f5c-8ca5-0e6230699cfd@kernel.org> <440d6b8a-d299-43eb-83b5-6625f9468e5e@lucifer.local> <37132e09-9c03-4afc-bc73-4bca416c5343@kernel.org> <9d5a4703-a15e-4be6-926b-af2d98db40c0@kernel.org> <87b83f7b-f0b1-4184-93a0-3b4b574c813b@lucifer.local> <20260401133145.90b094a7b87bdceb0013b5af@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260401133145.90b094a7b87bdceb0013b5af@linux-foundation.org> On Wed, Apr 01, 2026 at 01:31:45PM -0700, Andrew Morton wrote: > On Wed, 1 Apr 2026 09:14:35 +0100 "Lorenzo Stoakes (Oracle)" wrote: > > > From: "Lorenzo Stoakes (Oracle)" > > Date: Tue, 31 Mar 2026 13:11:18 +0100 > > Subject: [PATCH] mm/khugepaged: fix issue with tracking lock > > > > We are incorrectly treating lock_dropped to track both whether the lock is > > currently held and whether or not the lock was ever dropped. > > > > Update this change to account for this. > > > > Signed-off-by: Lorenzo Stoakes (Oracle) > > Not sure if I should add this? > > Should it have > > Fixes: 330f3758a3bc ("mm/khugepaged: unify khugepaged and madv_collapse > with collapse_single_pmd()")? (Sorry only just noticed this) I mean we do need this patch, if you plan to do this as a fix follow up then should have a fixed tag, but I do worry about bisection hazard by leaving this as-is. We definitely either need this patch folded in or as a fix that gets sent alongside the change. Thanks, Lorenzo