public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <ljs@kernel.org>
To: Chris Mason <clm@meta.com>
Cc: Roman Gushchin <roman.gushchin@linux.dev>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	 Theodore Ts'o <tytso@mit.edu>,
	Guenter Roeck <linux@roeck-us.net>,
	 Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	SeongJae Park <sj@kernel.org>,
	elkin@google.com,  Christian Brauner <brauner@kernel.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	 Sasha Levin <sashal@kernel.org>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	 Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Sean Christopherson <seanjc@google.com>,
	 Ian Rogers <irogers@google.com>
Subject: Re: Introduce Sashiko (agentic review of Linux kernel changes)
Date: Tue, 7 Apr 2026 11:52:16 +0100	[thread overview]
Message-ID: <adThhWAPxzsAZRbb@lucifer> (raw)
In-Reply-To: <16be2275-dcbb-4b0b-951a-83a23f61a1dc@meta.com>

On Wed, Mar 18, 2026 at 02:50:42PM -0400, Chris Mason wrote:
> On 3/18/26 2:33 PM, Roman Gushchin wrote:
> > "Lorenzo Stoakes (Oracle)" <ljs@kernel.org> writes:
> >>>
> >>> Finally, some subsystems have a good prompts coverage and some don't. It
> >>> doesn't have to be lengthy documentation (and it might actually be
> >>> counter-productive), but having a small list of things to look at - some
> >>> high-level concepts which are hard to grasp from the code, etc. - can
> >>> help a lot with both bug discovery and false positives.
> >>
> >> I guess best contributed to Chris's review-prompts repo right?
> >
> > Both works for me now, we'll figure out with Chris how to sync our
> > prompts. The small problem is that we're using various models, tools and
> > review protocols and barely can test each other's setup. And it's all
> > very fragile, so it's not exactly trivial.
> > But we'll figure out something soon.
> >
> > In general we need to carefully separate instructions (like which tools
> > to use, which prompts to load etc) from factual data. Then we can easily
> > use the factual data with various tooling around.
>
> I'm really excited to see Roman's work go live, and we've been talking
> about different ways to collaborate for a while.  I don't really have
> answers today other than just trying to iterate and do what works, but I
> wanted to reply that I'm fully supportive.

Ack, yes I'm very grateful for Roman's work, I think it's just a question of
figuring out how to fit things into our workflow effectively :)

Going to be a (possibly) bumpy ride but in general LLMs are _very good_ at this
kind of thing (code review, diagnostics), so it's an appropriate use of them and
in general I really feel we can catch a lot more bugs a lot sooner this way.

So, obviously modulo expressed concerns and details of how we do things, I'm
very much excited by and in favour of using AI for this kind of thing.

>
> -chris
>

Cheers, Lorenzo

  reply	other threads:[~2026-04-07 10:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 15:31 Introduce Sashiko (agentic review of Linux kernel changes) Roman Gushchin
2026-03-18 12:03 ` Lorenzo Stoakes (Oracle)
2026-03-18 18:33   ` Roman Gushchin
2026-03-18 18:50     ` Lorenzo Stoakes (Oracle)
2026-03-19 22:33       ` Roman Gushchin
2026-04-02 22:57         ` Sean Christopherson
2026-04-03  1:48           ` Roman Gushchin
2026-04-03  7:47             ` Lorenzo Stoakes (Oracle)
2026-04-03 12:11               ` Theodore Tso
2026-04-03 12:23                 ` Lorenzo Stoakes (Oracle)
2026-04-03 12:34                   ` Chris Mason
2026-04-03 14:02                     ` Lorenzo Stoakes (Oracle)
2026-04-03 16:58                       ` Chris Mason
2026-03-18 18:50     ` Chris Mason
2026-04-07 10:52       ` Lorenzo Stoakes [this message]
2026-03-18 15:00 ` SeongJae Park
2026-03-18 18:43   ` Roman Gushchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adThhWAPxzsAZRbb@lucifer \
    --to=ljs@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=brauner@kernel.org \
    --cc=clm@meta.com \
    --cc=dvyukov@google.com \
    --cc=elkin@google.com \
    --cc=irogers@google.com \
    --cc=konstantin@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=roman.gushchin@linux.dev \
    --cc=sashal@kernel.org \
    --cc=seanjc@google.com \
    --cc=shakeel.butt@linux.dev \
    --cc=sj@kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox