From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76CA122F01 for ; Tue, 7 Apr 2026 10:52:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775559143; cv=none; b=Wy1KINUsJH82QvduBBy6ZA2kTZj3p4VwYnupTY0Rm/OB9qRBy7w90KsOUAjIDFBBZyA0YAWBQmlJJQgzNPfxe3UxrfVC2Y69bFQ9MgqQ9+9hsIMCv+XL00ayVlKTXkZfrBYwzhOFZ+3vOgrC+M4v3i+8Bo+grAqGGr4STFFoXUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775559143; c=relaxed/simple; bh=8v63IeVHCl1dOge1LNJhDqzXdJEcZCuQ2ltOAcJAI2A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L84SCcOyJKg2qkOIQco1XQVF3sGS8HHLMuNlsh8W1mAetTZve0jnfsQDxo0Wp7tOJBH4ycn4J3d0EQG7ZAdQ6sRHZ7uR88Jmc+RRa3y4Fntza0sSBQ5KN3EwvhtUVFqcoim5pdtBOwub122DcbFzrXCGL6Zv2De+WOK7tMRY6+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LqGWhX7x; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LqGWhX7x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CEDBC116C6; Tue, 7 Apr 2026 10:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775559143; bh=8v63IeVHCl1dOge1LNJhDqzXdJEcZCuQ2ltOAcJAI2A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LqGWhX7xr4+Tho1LOQ9PBZdUPZpoY2NENzxoEFeqiYxaCynABUhnj9ZvWjxXt49Uv B8eU58VF/XfvFqbGeh7UHqwn7IMe5CF62jTHsOifxl2kTAxBnows/QSO5R1NR/5gOf eiuv7pcBVRFZaipWvBwhKiALIg0CKyoGYdSCCWAHPtFHxsG179vnZyzBXimarCSZTe kHYZZcD9acOlmOnehAEhwz0SV1rmH1UNd6b07Zm1bSxlATu0sPF10u8VpeUp2r309d u9sb2GTD5b88RDuQk9U2kMaCIN+12nmOB8sloFMImQZ6N+nSupz2IzxxdoMxW26lv+ GdheX+R6wm1tw== Date: Tue, 7 Apr 2026 11:52:16 +0100 From: Lorenzo Stoakes To: Chris Mason Cc: Roman Gushchin , linux-kernel , Andrew Morton , Theodore Ts'o , Guenter Roeck , Konstantin Ryabitsev , SeongJae Park , elkin@google.com, Christian Brauner , Dmitry Vyukov , Sasha Levin , Shakeel Butt , Lorenzo Stoakes , Sean Christopherson , Ian Rogers Subject: Re: Introduce Sashiko (agentic review of Linux kernel changes) Message-ID: References: <7ia4o6kmpj5s.fsf@castle.c.googlers.com> <39e6b4d2-8a30-4eaa-908d-5d11b746f8d5@lucifer.local> <87v7etugwd.fsf@linux.dev> <16be2275-dcbb-4b0b-951a-83a23f61a1dc@meta.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16be2275-dcbb-4b0b-951a-83a23f61a1dc@meta.com> On Wed, Mar 18, 2026 at 02:50:42PM -0400, Chris Mason wrote: > On 3/18/26 2:33 PM, Roman Gushchin wrote: > > "Lorenzo Stoakes (Oracle)" writes: > >>> > >>> Finally, some subsystems have a good prompts coverage and some don't. It > >>> doesn't have to be lengthy documentation (and it might actually be > >>> counter-productive), but having a small list of things to look at - some > >>> high-level concepts which are hard to grasp from the code, etc. - can > >>> help a lot with both bug discovery and false positives. > >> > >> I guess best contributed to Chris's review-prompts repo right? > > > > Both works for me now, we'll figure out with Chris how to sync our > > prompts. The small problem is that we're using various models, tools and > > review protocols and barely can test each other's setup. And it's all > > very fragile, so it's not exactly trivial. > > But we'll figure out something soon. > > > > In general we need to carefully separate instructions (like which tools > > to use, which prompts to load etc) from factual data. Then we can easily > > use the factual data with various tooling around. > > I'm really excited to see Roman's work go live, and we've been talking > about different ways to collaborate for a while. I don't really have > answers today other than just trying to iterate and do what works, but I > wanted to reply that I'm fully supportive. Ack, yes I'm very grateful for Roman's work, I think it's just a question of figuring out how to fit things into our workflow effectively :) Going to be a (possibly) bumpy ride but in general LLMs are _very good_ at this kind of thing (code review, diagnostics), so it's an appropriate use of them and in general I really feel we can catch a lot more bugs a lot sooner this way. So, obviously modulo expressed concerns and details of how we do things, I'm very much excited by and in favour of using AI for this kind of thing. > > -chris > Cheers, Lorenzo