From: Michal Hocko <mhocko@suse.com>
To: Jianyue Wu <wujianyue000@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
hannes@cmpxchg.org, david@kernel.org, zhengqi.arch@bytedance.com,
shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com,
chrisl@kernel.org, kasong@tencent.com, shikemeng@huaweicloud.com,
nphamcs@gmail.com, baohua@kernel.org, bhe@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: move folio LRU helpers out of swap
Date: Tue, 7 Apr 2026 13:20:58 +0200 [thread overview]
Message-ID: <adTomi7uPYJebAMD@tiehlicka> (raw)
In-Reply-To: <20260407110002.204755-1-wujianyue000@gmail.com>
On Tue 07-04-26 19:00:02, Jianyue Wu wrote:
> All allocated folios are added into lru lists for later reclaim whether
> they are file or anonymous folios. However those folio lru operation codes
> are put in mm/swap.c which is not so appropriate. Because swap code is
> only for anonymous folios.
>
> Here move folio lru helpers out of mm/swap.c and put them into file for
> their own.
>
> This is cleanup, no functional change involved.
>
> Signed-off-by: Jianyue Wu <wujianyue000@gmail.com>
> ---
> MAINTAINERS | 2 +
> include/linux/mm.h | 2 +
> include/linux/swap.h | 38 --
> mm/Makefile | 2 +-
> mm/folio_lru.c | 1074 ++++++++++++++++++++++++++++++++++++++++++
> mm/folio_lru.h | 53 +++
> mm/swap.c | 1064 +----------------------------------------
All that big churn is really worth it? Are there any other reasons than
"not so appropriate"?
Really if this is not a part of a much bigger plan then NAK.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2026-04-07 11:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 11:00 [PATCH] mm: move folio LRU helpers out of swap Jianyue Wu
2026-04-07 11:20 ` Michal Hocko [this message]
2026-04-07 12:31 ` Jianyue Wu
2026-04-07 12:46 ` Michal Hocko
2026-04-07 11:42 ` David Hildenbrand (Arm)
2026-04-07 12:33 ` Jianyue Wu
2026-04-07 13:40 ` Matthew Wilcox
2026-04-08 1:09 ` Barry Song
2026-04-07 14:22 ` Johannes Weiner
2026-04-08 0:41 ` Jianyue Wu
2026-04-08 2:27 ` Barry Song
2026-04-08 1:38 ` Baoquan He
2026-04-08 2:20 ` Barry Song
2026-04-08 2:49 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adTomi7uPYJebAMD@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=bhe@redhat.com \
--cc=chrisl@kernel.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=nphamcs@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=shikemeng@huaweicloud.com \
--cc=wujianyue000@gmail.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox