From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 165913A873B for ; Tue, 7 Apr 2026 11:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775560863; cv=none; b=DY/gbnR2IuX8luW+HqEfgPX+fqxj3Q0rmhn1jbDkIzV8R0VXsuCrkGx4mY5fF/HmOuOzdxQ9cH6aYYRqcly7fbED+PmlVkFb3Qhxr5bZPoBJ6pUJ2Mb56XW6WOCiSykA4cqVoNIfSytyZpFQFlHl7mEDdJI9DsoNq+tcs/4TzO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775560863; c=relaxed/simple; bh=Ekfiy1ueaHvLVh3gnqwZab9NzqjhTUKsCpdjDi8v8RQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bp3U2ZcjptMa6VxqTva9iM23LlKegsPImpmScBTU1xbTBeIKKc7M2lcYWd8Gbg+m26lqJzIsFmN2lmxhy6zNKEgl4KU4DuEhjOxDwS96PxY/oEnZ9bSdDzU5pn02i5hYoZIlo1HSQXFu2i2tqnLfLob3mQv8jm52xUP+kkMl8d4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=avjTCL8w; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="avjTCL8w" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43d02a71526so2858080f8f.3 for ; Tue, 07 Apr 2026 04:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1775560860; x=1776165660; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ak6Ow6/QaSx3d2ftagO0ADIntVVPX4rdI7D8NXhmkrw=; b=avjTCL8wAf7ORjQlJ8kzsVtBOGVJ0WRG106ReLeqgZkDV6CKDx+DokYqTKOyhhFHyy /PAiqjOirsfSO9ddPP+IC3vYZq3T+MhOJ96J3ISMgEOtgSRi78jZxF11N99i9xqIah+a EtW2+izwvK+L4fbuw86glJb6qBH2VntQJIwux9kJlBwcS3yQXIdj8HwjgdYcbuqgqkia l00wG1yInT501MbU814NANo01/CBVOREnEcH1t4UDYCuVf+SXJjPECT2TKUNvv6GQc7x a6Ua0HYVAysp7C3aAVMfpGjCgtGliNLIBBl6/Wv7CTTbaZLUQJBbz5Ne+raWH5nh3/Eu upNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775560860; x=1776165660; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ak6Ow6/QaSx3d2ftagO0ADIntVVPX4rdI7D8NXhmkrw=; b=mP1BTbrKuLAhH7LVpXXSV7LiA/jmIsCi6VLrR7GBH5xGF0kDUHNBysS+6aBewl7eOp UGTt45+fX5cl9E+XEFt+JvW5N9xbP2nuYIWLAIqmHCB98TogX3doC1jGzM8B2zYn2lQr GPGiDpGzthKuVtRKO+cH1fJWjuXoCPwuTWKQJHoguR+6HZQPPk0UWGLnCp+vF91Kafnc Un4bDVnHDZcMOGw5f0/qrnDI6Hpl24CAXVPq4/a4z8xftmZn3yv37nhak987OV8i+rkj QuPb9RUcafDn1a7/22bZvhbFi+7Vm/xtCk8KL3HW3KsQvVLySCPOWYjFzbE8jujiJviy B2kw== X-Forwarded-Encrypted: i=1; AJvYcCX/3eJZmNOb/mCLRqvPMezc2mehLpJ50M0kYD50hpzgY5EeoojIMPIPIhxmqFOzzj56sKSfiCraTY4YNc4=@vger.kernel.org X-Gm-Message-State: AOJu0YzTRcsXVxoeibYMLpuvhYg5rMePjFP7Ugxs5GhWwASngKPojR9S kjQ63paS1ke7Y2Rb9Wiky6IRtsQxYxA5RriO6JL97Jy3b+gYwFT+owl2VvGAc9IMAlo= X-Gm-Gg: AeBDiev4hRU2LQtbiQsfAd6mQfg0tMvQk2Qt7twt5u/WiURzO2dCXfPYtNylBMZnrDD 0cpBk4gtVGhwl6Uo78dKFGhWjZFQsPlAQp7c2bcxzLLYeEfwLxL5KNymtfB1cFHKIAolRzDtrYS 2rBbTxxpeN/mSXSW4DftXnqmd+uHPtqKgRPwxAimbfFcKPdN3AFCSLhpafBcrGrSJiFsCn5s6LR JJBBTYQndlG3mxLrFVC7X2OD7qk322kAyLxWojcySoI91vOERr7G5SINyw/cTP9cgRJjUZ4k8qY sgfrcp4DsALpphWgyeg3NozWN9WPqI8kXW8lli+w+zpINHi8ux89U+h8slphWZQP/oXhgMbyIg1 1aEQmoIS9ZvhlIZt4uRQhrqi6a4hKRTMbh6y0OA23HeiNIUfPWmyhihiG802ncEFq4tDOOsmsGb 8CK5IkBUW/1YFX4Bq/k5lSLU36XaVw3vmnQoKCRK4We+jtRng= X-Received: by 2002:a05:6000:1842:b0:43c:ef4f:79e4 with SMTP id ffacd0b85a97d-43d292ff4dbmr22067547f8f.37.1775560860126; Tue, 07 Apr 2026 04:21:00 -0700 (PDT) Received: from localhost (109-81-88-253.rct.o2.cz. [109.81.88.253]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4e1c27sm47135247f8f.26.2026.04.07.04.20.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 04:20:59 -0700 (PDT) Date: Tue, 7 Apr 2026 13:20:58 +0200 From: Michal Hocko To: Jianyue Wu Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hannes@cmpxchg.org, david@kernel.org, zhengqi.arch@bytedance.com, shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com, chrisl@kernel.org, kasong@tencent.com, shikemeng@huaweicloud.com, nphamcs@gmail.com, baohua@kernel.org, bhe@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: move folio LRU helpers out of swap Message-ID: References: <20260407110002.204755-1-wujianyue000@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407110002.204755-1-wujianyue000@gmail.com> On Tue 07-04-26 19:00:02, Jianyue Wu wrote: > All allocated folios are added into lru lists for later reclaim whether > they are file or anonymous folios. However those folio lru operation codes > are put in mm/swap.c which is not so appropriate. Because swap code is > only for anonymous folios. > > Here move folio lru helpers out of mm/swap.c and put them into file for > their own. > > This is cleanup, no functional change involved. > > Signed-off-by: Jianyue Wu > --- > MAINTAINERS | 2 + > include/linux/mm.h | 2 + > include/linux/swap.h | 38 -- > mm/Makefile | 2 +- > mm/folio_lru.c | 1074 ++++++++++++++++++++++++++++++++++++++++++ > mm/folio_lru.h | 53 +++ > mm/swap.c | 1064 +---------------------------------------- All that big churn is really worth it? Are there any other reasons than "not so appropriate"? Really if this is not a part of a much bigger plan then NAK. -- Michal Hocko SUSE Labs