From: Yury Norov <ynorov@nvidia.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Yury Norov <yury.norov@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v1 1/1] bitops: Update kernel-doc for sign_extendXX()
Date: Tue, 7 Apr 2026 12:58:15 -0400 [thread overview]
Message-ID: <adU3p88-eBnPHaLY@yury> (raw)
In-Reply-To: <20260407151431.1793779-1-andriy.shevchenko@linux.intel.com>
On Tue, Apr 07, 2026 at 05:14:31PM +0200, Andy Shevchenko wrote:
> The sign_extendXX() lack of Return section and have other style
> issues. Address that by updating kernel-doc accordingly.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied, thanks.
> ---
> include/linux/bitops.h | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/bitops.h b/include/linux/bitops.h
> index 1fe46703792f..657eab2725ce 100644
> --- a/include/linux/bitops.h
> +++ b/include/linux/bitops.h
> @@ -179,9 +179,11 @@ static inline __u8 ror8(__u8 word, unsigned int shift)
> /**
> * sign_extend32 - sign extend a 32-bit value using specified bit as sign-bit
> * @value: value to sign extend
> - * @index: 0 based bit index (0<=index<32) to sign bit
> + * @index: 0 based bit index (0 <= index < 32) to sign bit
> *
> * This is safe to use for 16- and 8-bit types as well.
> + *
> + * Return: 32-bit sign extended value
> */
> static __always_inline __s32 sign_extend32(__u32 value, int index)
> {
> @@ -192,7 +194,11 @@ static __always_inline __s32 sign_extend32(__u32 value, int index)
> /**
> * sign_extend64 - sign extend a 64-bit value using specified bit as sign-bit
> * @value: value to sign extend
> - * @index: 0 based bit index (0<=index<64) to sign bit
> + * @index: 0 based bit index (0 <= index < 64) to sign bit
> + *
> + * This is safe to use for 32-, 16- and 8-bit types as well.
> + *
> + * Return: 64-bit sign extended value
> */
> static __always_inline __s64 sign_extend64(__u64 value, int index)
> {
> --
> 2.50.1
prev parent reply other threads:[~2026-04-07 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 15:14 [PATCH v1 1/1] bitops: Update kernel-doc for sign_extendXX() Andy Shevchenko
2026-04-07 16:58 ` Yury Norov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adU3p88-eBnPHaLY@yury \
--to=ynorov@nvidia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox