From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010067.outbound.protection.outlook.com [52.101.46.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79DAC3AB269 for ; Tue, 7 Apr 2026 16:58:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.67 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775581101; cv=fail; b=kHCJ/DnJX68juqty7N2xyCCf0XBoWi70PEZAKB2KMbOosYZGBfDjeKhP3BTZcLkEk/exrJTMNpfUhk32NfBplldxcFWUS5dpPs0omXCTGDyiUBnTu5PPXACzv3Iaext6zOe8cAb1gUTL3gt3Hoai1AmLZTZ5ghjFL3qTA0brawA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775581101; c=relaxed/simple; bh=glET9wWNCQTtzpUIzVpaXzORQFdez2Gb392qJO/cYcQ=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=H56Y7dWwXZZ07FnMg/3OsN0ShHh0jszj6+8TntqMZWd0xsmo7pEHyVrIGdPYKEcDaW33+ZlSj3+hs12r722UhgX9dL/g05py71RZllKZtU5HUMdLiLTQz/06eeXAQc1szoctyhr90rO5SdexMVsc5rkugCgVSoCi8atYyQO2U7k= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Hahs9/vP; arc=fail smtp.client-ip=52.101.46.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Hahs9/vP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QD9fkSuVmVaBFBTV0rHuHqfESn387oCR68aLWKTdmFuoRR3dMuXaktrXfiYH+Q/JlIBkXpTQlI9hkvbmIhTHawOiKTZpYxUnNuQBcPjeyUwjPGdaXlBosp3FFYRLeGJIqOlqS9cVnM2Bvshwx4wXawhdetTg1rxxoKxnri4c4zNV4SSsJPXki6Q6wOgQ6ib/B8mwcCAave9q8X0mD9yA8zT4fWD9n/icpOaByRsC+cZq0FLPzybpHn+iegqpzcDORaczz/1Di9RYPwkS9SBdoDs/hxE/EmJSYeyJGr4js8t7OwnLFPi0e+x5qG9eNbYRvABRjeeNOi0ur0TZMQBzew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QMg7A1bWUv/YYKfVPg9q9vS0U+m9aaqTPUxDqmbi0HI=; b=ibFwpLb984rYFOGyhPBt0zp8rv6H3UeaKMXcuP1u8B0CQK8hdTZmBIGB1yi00+WSsWGe5Yka2t9p+ru8Q4KkioZ46xxZ1EjyVjhcQltM6TnXZGm0J1T1PBDK1rdDOGFX3iQSgxw7N6P7r1hAymfFoQ7P3VULZY+UOGRjO8DbN3nwUrHT01glnwJPbbnUAO65T/ezwzBNK5PNMPjHuyXmf+McgWexSwdwSK9eF2NhaJe9nqlzSlAS5TdZQKV0Eg0cYEQn/zJv7W8X+kBU3zGjqBJS0mUoi9BoPHFU1IDbNoYSEVKTTcIe7Cvx/I1ebTw0iPOABgGswOIbN7IomIjHWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QMg7A1bWUv/YYKfVPg9q9vS0U+m9aaqTPUxDqmbi0HI=; b=Hahs9/vPHD0hXc5g0UmZ/KE7vf7h5kOU8B3l6Qk7rF4ZMpxzc4NZ6+vdNBk9mE+Mx7vaTRpPA6QH19pDoZ7abyHRGuyl9jaiQ90dmtj5jl8zLJqv3dUFz/WDNZfBzP2iKPzcmovf/YTF0+8OghORXaWRELhpOxQvO6oyvswVlPIwWxMa4NVVxsKQMG+EKhUZwf/kO46H3OPCMZ5qN+KMBc4dz/G5QuXwj++ZNrMAStYoD0GlDHbl17kXTUfR/v7fWHtQh8TVCUsKa2qg+8JZ5CddkL+9zbLVFOD0t0lXw+xcbXT80AZ0G5P7nSFc2HWWDuTmS9Xx78Vzram0eRciTQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by CH2PR12MB4262.namprd12.prod.outlook.com (2603:10b6:610:af::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.16; Tue, 7 Apr 2026 16:58:17 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9769.018; Tue, 7 Apr 2026 16:58:17 +0000 Date: Tue, 7 Apr 2026 12:58:15 -0400 From: Yury Norov To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Yury Norov , Rasmus Villemoes Subject: Re: [PATCH v1 1/1] bitops: Update kernel-doc for sign_extendXX() Message-ID: References: <20260407151431.1793779-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407151431.1793779-1-andriy.shevchenko@linux.intel.com> X-ClientProxiedBy: CH2PR14CA0024.namprd14.prod.outlook.com (2603:10b6:610:60::34) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|CH2PR12MB4262:EE_ X-MS-Office365-Filtering-Correlation-Id: f971b8a0-9b8d-47fc-a78a-08de94c6dd5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|10070799003|376014|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: xIEMe3GDZVLfDKUNF0e2AdtdOiQgc4ARSByYqAmsjpvWgz/mUdVu5A3TUAOei2jYsFRcgJin8muS6hbVnvAkvfANjIdzz7RUWFAh1DHBzP9UnA+EHTGu+9uS5HAC2ldVYjhylPsmJsYyKg52nkLl532/D1BRQvTuooS6AGrpQfgKJvBY+GERfCn2q+7HSz0ZzyWknEWHiYBavDQV39do0lvtPqP9cpWdutEF9dPhm2bQCl+uetoXy4dz4aOWOfOd4WAYM5SNp9rAkFpnoRjIpx45t9IXwLYBcMlgKVjP6cUMUf44J7xIOY5jdvZ5UuZcl6aT3YR2ZzFSAg9GkdOvh1fyBRmslqRzsG1Qkw1FQOks30YKyOyQJUVUBJC5uTpQrrDYft2RKKXcki2g0B6iqT8I8mv56B774P0sG9xd4ZJURs7jRg44x276WCQpe2ZYz9ibt4B6pNruwIVy3ajtfczu7YW4pOFBiLmod9e/81JztA/ykjvxmymWorLyBDdGMT8g9sHOulYa8xJO5lumdromP3yjtqgEUYhzSgoJ2rs/ABZc6Y8POJmXIujzAmgHAbjDpj8YHCs0wgdnXdpgGt80tOvNq+yHTUXGQHg+zZgSbHuEHFmjVbECVFjaGEYZo2r+NHuEVABkD8UenpCPVxdzdZUHRrNcRdyNxdcD+T8STv7IuZZ9Z7rbr0fPSQJsJTdTBpe1LuhD7rS8xedwnaIENCxRZkgLqx+SIRippwo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(10070799003)(376014)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V8Kx/n91p8jAfiBQ5dDitzm5L3cXJbOpJlIUsg8CqlCeglNpiE28f2OsFYRp?= =?us-ascii?Q?ndfwdhLZ/6O5K8p5VTeR1MuBYs73ZHFQb6+Zo4etXWahc3w2JZFNqYeYRLeI?= =?us-ascii?Q?aOlYg+qqTgl+m22KkQkZNq61JaSinQ78wBKRpnIKARAwfwAjheTS9ILL3mY6?= =?us-ascii?Q?a4Xs6apo+QrPlqWeHB9nsVu+DIi5pbN3uRVOEH6TPeu5vWc+Gpx3Z0/XPqoR?= =?us-ascii?Q?6I2eNChQebOq7m5zSuzVhSDwSAEdgpLcGOryzVG/e5rXHKhg87kmTA1yqv3l?= =?us-ascii?Q?ouMSGs+UDliQ6GtcKMuoL32CLjtvHDjoacj8/RoNKFbrDXcf0PriK7EN7hVg?= =?us-ascii?Q?hTSklSl/SyCCV42pg4DTPYtcyAmnTbplJ0wyBY0bbsGIS0XtSh8zwDKZyNsd?= =?us-ascii?Q?p6WbuG0QtbEv3Uoi9IQlkx4utwGNWWA/f5bugmNIWitidPWBUI9P0CY+ffYg?= =?us-ascii?Q?EvfWO493lJ3bAIJIAasOo9MwKcRp9EIOFv/eGo74VAHPVg7EGJLvVT+tKzBa?= =?us-ascii?Q?jEAVpt/V5c3+0XEO9clTbEU5G84LdP4u3akyqK5qFXO/w7d450SH3Zc2XDau?= =?us-ascii?Q?f1oMVKd5PpBlg8vc147BRLekdeTkOaL29AyVCEDPMrqUkIdV0FVW/z+4dj9m?= =?us-ascii?Q?g5d3sQJhtErfZzVDTuuI+mFf5ZC/XHr6WRGFPJcpTTiUr9ncRWlgfu46KKAe?= =?us-ascii?Q?3f17OoVksExLec8QF9Rs9zrI5tZrGZXvl7pG67SrrLMbdNnwOaQ3Aken+XVR?= =?us-ascii?Q?D5Cw7CybcKp0yQzo37us6uTSK8pXLHJwhE90t434YFtInccjfR2nsiMZO/mg?= =?us-ascii?Q?MeYWJ0qpLJe4x+ReJe9RVUEuapvl39QtS2+2ED/zOVpeVFhhIQ9WXi+CXK7X?= =?us-ascii?Q?GMCU+2XfcyuJYOFtu49XcZ5MziiIaRvkSZefXX3n4WF/ls11cuEiv1dPurVb?= =?us-ascii?Q?FXcR1PrT2H3r97ZQQjhsX77ESP9tKVUgs9uXx3vl3kVza1ZZfh1YNtymRLR+?= =?us-ascii?Q?Mfb7hqSK2BiZDHH0bNAgidUFIqBgsqTZ8mtlBfVwu0cJgXcVzxQdliHLo4tJ?= =?us-ascii?Q?Nd+ZhCOLptjmwv7SYdl6chpoZV/lKujDmk/Iwi2IP2+YyIBHAILVOI2RDcsx?= =?us-ascii?Q?V5vqp8SyRDsmxYoeMjU0KsZf9hw5Laoyn+Nd1agQ4n9LT77GtgdR6kVaCXIQ?= =?us-ascii?Q?9u+NMEpS6kwetgN+GzD9csNUD1a/wI8dmJ+l1ajhI36Gwu+EsDrx7jebZrem?= =?us-ascii?Q?oTfKS56kV2OzPpvITrdqIN/op4oY6VLxMPxaYA9oB7X1SoSh9GL1NeeQTcQY?= =?us-ascii?Q?3JXsLg5do0M+we2clj/dWx2MYR9ZvVbgsoilsvp2gs0c1rbwX7GCzIFelyvY?= =?us-ascii?Q?e3d02dcdOkKWCZ1WrqdzxlWNz0nvAZFJRzYk9RKuz359/mL//ZlWi5QvFUn+?= =?us-ascii?Q?EJVE5VZP4HnnbHuaq3jCv8KDGWxZeprB9Ma3CHOwArQNOVOMH10i4uc3Ayy5?= =?us-ascii?Q?U7c7Tl02sLk99XxnxIjIR4zOkDWma+f6i+wOrjF/V/ymTCfgydMCb3dYNBcd?= =?us-ascii?Q?FsQ7mxvpqiQD+sksWWxh4PhMGmKjHjBHSOUz95isEdm7askd9BFO2FHWmC13?= =?us-ascii?Q?RjoeW/SYd9Xy0PEg9ofKVKrGvvqvH8Qzdl2uIPnnXD77tDrCZ8nPSu4QOcqC?= =?us-ascii?Q?H1aZrXBuQ5TThdDgD/S/pJbswOJRZQB9hFSSj/j4Ucd+uQW/XVSV+4LRT4HC?= =?us-ascii?Q?05sRRSEgYz+274WjPnDb3GQw0LeBAQ9OtRJA5QHSmnzFqnITWYXf?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f971b8a0-9b8d-47fc-a78a-08de94c6dd5e X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2026 16:58:17.3001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w3ymmbRN0+HiF8aqmR+DsKwaU2zzjMPNnC7YT6MtbM4qo5PUQN8Mhn9dvcxCp6ALAF8ZoGAJO/WC176/aLcaUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4262 On Tue, Apr 07, 2026 at 05:14:31PM +0200, Andy Shevchenko wrote: > The sign_extendXX() lack of Return section and have other style > issues. Address that by updating kernel-doc accordingly. > > Signed-off-by: Andy Shevchenko Applied, thanks. > --- > include/linux/bitops.h | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/include/linux/bitops.h b/include/linux/bitops.h > index 1fe46703792f..657eab2725ce 100644 > --- a/include/linux/bitops.h > +++ b/include/linux/bitops.h > @@ -179,9 +179,11 @@ static inline __u8 ror8(__u8 word, unsigned int shift) > /** > * sign_extend32 - sign extend a 32-bit value using specified bit as sign-bit > * @value: value to sign extend > - * @index: 0 based bit index (0<=index<32) to sign bit > + * @index: 0 based bit index (0 <= index < 32) to sign bit > * > * This is safe to use for 16- and 8-bit types as well. > + * > + * Return: 32-bit sign extended value > */ > static __always_inline __s32 sign_extend32(__u32 value, int index) > { > @@ -192,7 +194,11 @@ static __always_inline __s32 sign_extend32(__u32 value, int index) > /** > * sign_extend64 - sign extend a 64-bit value using specified bit as sign-bit > * @value: value to sign extend > - * @index: 0 based bit index (0<=index<64) to sign bit > + * @index: 0 based bit index (0 <= index < 64) to sign bit > + * > + * This is safe to use for 32-, 16- and 8-bit types as well. > + * > + * Return: 64-bit sign extended value > */ > static __always_inline __s64 sign_extend64(__u64 value, int index) > { > -- > 2.50.1