From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81F983B7B9D for ; Tue, 7 Apr 2026 14:14:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571270; cv=none; b=WSrNVW4kcrlKc79LPFdZokhDj/ttlVcR4OguiGm6fWuxbfSfcsghapd+0YCGhs8WRuoYQKx9/Xh8oYvLoOA+gaSQzsFgWhe8Cs2KjKkVniBN1j6m7Zw4XUMLiS7Bk6eDVY/8tO0wWCB+kBgd2UimORUg5O8OBO6kD/xX5axw0XM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571270; c=relaxed/simple; bh=3tI7/jx4Y5z0V5LAnMLGq10PpBmliraNeBEmVGyPWSI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mGKGVLzGvEm0yF5daMZ5V0DU4JfYAjamVbbge2nyVjaM7IMI6M/ROPS1rZOc1N6B7/2fu+qVcCG07kSLlCrpSOKEMUya1bBFlq2K8QcK3McHm0rDFnDxhBlBK/FYyRumFAaAnG5vaVViJsa4vX4gqEIhOD/FdLJZO6PD+jtUUX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=V0JhHIOp; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="V0JhHIOp" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-82cebbdbdccso2668800b3a.1 for ; Tue, 07 Apr 2026 07:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1775571269; x=1776176069; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=thGyqMiwlE5+c6ypfzy1Ks6sEV0q0JJTzYztY0TA27s=; b=V0JhHIOpxaGWQNGtOwWdvnVrdseFsVJYU+Tn4ZGVChfp3MVzjDMXoBYvK3mGbiQb57 jGkZQH7Kwvw0VAqW31BgGDgF2LQDnXakuP19XfoyT5W/wUU09rnpieboqIqI0c3WNUaR MXvDY4FmQo9tmJVpKLvPEoBenW98egjXwdsuY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775571269; x=1776176069; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=thGyqMiwlE5+c6ypfzy1Ks6sEV0q0JJTzYztY0TA27s=; b=ebcoCmegGVYvT8QGdLxz+lHe6CiqA9g+zPPE+oGz/7OgFx/L1x6T/L1vZhHVn8hAcF vlopdcXVmAKi+cUXT/O4U3GWFIvnf6yj2FvxHdrGi/2jwKtoThjbvl9l1KvPRmWg76vO 9fWbrmCUeFj7yiIsP1cz1CW5Iyu8VkbmmQmWIa81ycRyccuMYZIjkx1RwZVQp4EBms+6 BKkeA8OkQbKavH4gUHxC8GlUkBPoHs9sTNpELAAUXzSa+cRtdXQThJ4LHpZPonmOqElo iqCCD1HpG24BurTlp43Mm5KwtFSzwLf7Eeg4ijLZDn8Y7gTvPh+hjhFqXHq3TdPjJSSQ FsUQ== X-Forwarded-Encrypted: i=1; AJvYcCVv83WAibE1f5FdgShBw6vrobJPoiDreloV3BhWyh/bTugj6m7KTmqmMvH86b5aZZpZg1BC9R95qDDSFFk=@vger.kernel.org X-Gm-Message-State: AOJu0YyEjP19BxV9nqe3oSaw2TA0po/SDDqyRKrXP7F2RDkL07YScNp0 6Px+JdwVSPuqsdVm23SuOjg8xyMyfnHIJzaFUlvMq+RWg1BKFsHcFZlbUtXK9F7bUg== X-Gm-Gg: AeBDievuGmumrAJOzuoLFzBDNNF5pr3HV21UCTZUsPOTN9eWYhV3UmjLldcWzMDy8af newWCzV2fia2L4YH/3dj5ukEPId1ogSDyu/SX3sRETYX7/diAYkhbqhmwa2ot2ubu3hdjmz+0+0 npr0cxluwbte8+/SgbYaaw8RwURXx1IVOaMt+w/0OR+U19p1yIK4aNeaYm+CwSBtuVV3szVvMqn Kw9bK9FuyJ7W5m1kLpdk/fcsSn+b0geOSqkns+A6Q/FxucKypck3/f590/oRFVbH338nOe2Tkhu S09wJidYAQWsiZH/XwoNPz93aHua6MnTOCFWhCysHl/Tad4tN1c1yH4bES4pwhaNblDbn002VYi PB9W1YzFgDW2HDCigxKYwVq9Uz0mQoLDAc1B+U6VgeXnS0Pnlm32splJKTkwQ7h5DkmjonKCWoO p8cg2ivamb1cjhFBDsZjgpx1Ao2oFNBQ37TThZztSMv+NaO3/8RBXT+BCN8CWluXE= X-Received: by 2002:a05:6a00:2e93:b0:823:1bc7:ffd8 with SMTP id d2e1a72fcca58-82d0db3f54amr14697795b3a.9.1775571268754; Tue, 07 Apr 2026 07:14:28 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:f201:1700:5280:dbe9]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82d11cd2ce2sm16925566b3a.6.2026.04.07.07.14.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 07:14:28 -0700 (PDT) Date: Tue, 7 Apr 2026 23:14:24 +0900 From: Sergey Senozhatsky To: Andrew Stellman Cc: Minchan Kim , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] zram: add init_done() guard to algorithm_params_store() Message-ID: References: <20260407123836.6341-1-astellman@stellman-greene.com> <20260407123836.6341-5-astellman@stellman-greene.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407123836.6341-5-astellman@stellman-greene.com> On (26/04/07 08:38), Andrew Stellman wrote: > @@ -1772,6 +1772,12 @@ static ssize_t algorithm_params_store(struct device *dev, > if (prio < ZRAM_PRIMARY_COMP || prio >= ZRAM_MAX_COMPS) > return -EINVAL; > > + guard(rwsem_write)(&zram->dev_lock); > + if (init_done(zram)) { > + pr_info("Can't change algorithm params for initialized device\n"); > + return -EBUSY; > + } > + > ret = comp_params_store(zram, prio, level, dict_path, &deflate_params); > return ret ? ret : len; > } This is already fixed.