From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79F293921ED for ; Tue, 7 Apr 2026 14:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571295; cv=none; b=Xc18fPJxl6+Jy67UrloQ9o1FNmmujbfrKNhJhPDLaON3rWyeZbRZtbHwzVwxm7wkauvNWhcdjKT8G74BJJxDDxs9NVv3KQ/JOcHa03epnwt4vIAgcugVgC3t1c+GgcVS/eH+2WiS6btkbyqxA0ezzlRfVYwQeTPqedHmXetvcc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571295; c=relaxed/simple; bh=Hk34POJ0zMaz6vL2PHOeLfejjVxDULuekgbk4saenok=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ABFT0h1HwXWWQkHQinNzm1NkpTwbeTZgap69zn825hYEPG9rCbzLyjU4+VspXAcSmfVnPvqxuYyZDlDV819xapyaG6qHvHnFT7bh64dEGjAf96TLjvqfkmRqCTQwAgvQYmRMeKL2YVrbAYW6Agq3dUfJLpkMThB3jTOof8qVLws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Vkz+p0Eo; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Vkz+p0Eo" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2b2469e5117so26861575ad.1 for ; Tue, 07 Apr 2026 07:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1775571294; x=1776176094; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ioLwfel/eE5EdLXo5+kNfocQ2u4I6IVVdp6FFXGx9fc=; b=Vkz+p0EoFaYWpg7r6fPSTf6Atgm8T4xYbsPMEMOmYSPfD0j86WZESgbV/M+7wCH8sY 0z14/5NPEQr8LHSNt81m35OEJ3GRJe4vJjVrwADPOk/7w6x4lwG3u816mqWWPbMzvmoX LcVZtY3QyQpvyssdRJBCDNO3qoupliWCccCTA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775571294; x=1776176094; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ioLwfel/eE5EdLXo5+kNfocQ2u4I6IVVdp6FFXGx9fc=; b=qhBF0o1MBwHgZEiQHeAB5HaCqc2j1Y7irIBxLz+ZasLGUy8wgg1jhi7YHbvK9PBZQ2 VEFORxwGDenMi85qi20iew+7x5vbraxaX8MDEs5EzQf2zsqIWRIqshARmUDcetP+zzJw YDzMH+vNlPLkdHgnhKZyZ886OIxSSDJ6Wun+2BxHmZkYV8/DvzUFXjLlHb/GJ6h9clNH 9A4oD0CLytcjS+djgCj9twaUinHKCMzcgsdmwHgezeFQiDXpvibpwgvhDps9Ze0j1IYl at8tWJsXWRG6/Lp0L2JKOs81IvVjKxkAQS3LAL4HpiK/BOyyAn75VhLtNhBzZ037oYAQ 7etA== X-Forwarded-Encrypted: i=1; AJvYcCVXmsVxkv1PnEUSWo1yr809d6Tc/xWQbX7Zi85JmT1NWciqFjd1hpxx5znmwQSVKJ3xRynCvc8OzRFIlU4=@vger.kernel.org X-Gm-Message-State: AOJu0YwEDb4MYL85PQHx5sMi1lz48AcJOUnWHCYdQtzTq4ATh21dB7sI 9qovA3aeDXFnTvjyUwxtlhkd97waOozbgrQjUF7we15Y8ZQ5ynrN1u76ks4ANem/1zhNtRrQf8u PIQE= X-Gm-Gg: AeBDieu7crnZy279ojfqqKaM6Ifm/+5/cO5tAaNXvGX+kUnrp5aEnpabNOErppHkG9H ChCGYrKSAEmSVm4VQBMEujmGOF7D0V+sSwDkNhZ6DZVMTB1S56Mre1mJhPzL4eOVht4vQBeOdN8 ZNRXk6DOdigKIWhGrZJr9Ds70PxXGmR1ta3C4NoKRYlqug1echZYWen3ReXU67RgPSJoJAjnFHv OOUIjlng4DTwCN+BPZII7p32gSF01RyF+grJKu3hgXnfAEuUREB55oT3WvBJmBvWsvUYIxR/Qis fsdoj4nn9wrpj3uWM8IkOIiQjsS6xUo7TdU0OAZmbpnvi9QR2T9pjf7zQEZ1vsZGmhsWptC3E0w XUw5Ow7JewfqRuI+R9bApmHW4KcAa10nyHpMHdBd9v7vIaaiMSooqP79zmJuLKrxE0ss8vNzozO Gu0FOdbpM60kRsilxlAmfA4zcxMOReti44VcTdMBLaJM2eoipNc9BS/kSNkCVBEC0= X-Received: by 2002:a17:902:d506:b0:2b0:b7c6:4ae7 with SMTP id d9443c01a7336-2b277d64ad1mr181711515ad.1.1775571293840; Tue, 07 Apr 2026 07:14:53 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:f201:1700:5280:dbe9]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2749cbcafsm174261495ad.77.2026.04.07.07.14.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 07:14:53 -0700 (PDT) Date: Tue, 7 Apr 2026 23:14:50 +0900 From: Sergey Senozhatsky To: Andrew Stellman Cc: Minchan Kim , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] zram: call bio_endio() on early return in zram_bio_discard() Message-ID: References: <20260407123836.6341-1-astellman@stellman-greene.com> <20260407123836.6341-3-astellman@stellman-greene.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407123836.6341-3-astellman@stellman-greene.com> On (26/04/07 08:38), Andrew Stellman wrote: > drivers/block/zram/zram_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index f41f1ca..8ea2a12 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -2701,8 +2701,10 @@ static void zram_bio_discard(struct zram *zram, struct bio *bio) > * skipping this logical block is appropriate here. > */ > if (offset) { > - if (n <= (PAGE_SIZE - offset)) > + if (n <= (PAGE_SIZE - offset)) { > + bio_endio(bio); > return; > + } > > n -= (PAGE_SIZE - offset); > index++; This is already fixed.