From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18FD6134CF for ; Tue, 7 Apr 2026 14:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571326; cv=none; b=J2EV9AJzzbo5ak5Q6hVGZ28p2lDTetqGbMobGv2iyvyQ6jHd6ldFcT+0UlNHpll+CFyELIyyzjCLf7cPfTe+ICGjd4ylUo21+IJmD294P4BnxWDrzkDJSi8hgRHNEVRbAAAjBX7Evg06sD//vuSU2CwsiykuUdgC0L2JSrYfFIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571326; c=relaxed/simple; bh=10BCNKFdMJ+QhFxPa0ugZqGYBGXOPJ6TFgx7MepYrGY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kyQp8Jd9KRZ3UYRz5uDGrf5ESJa6WOXAu1WLqsuj1zBup2buAmC7SK+k09hDUgpGxcBjGeENOLLKNTSDN1YgNTu5t8jMsThzl81OPh/JuC5uMvQk/Xr4XtSPhhqJ68J6G8V4eiSUU1HlnHxR99lSMthZqZi0VFuTUZHO9XibL3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=O0TrQjbk; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="O0TrQjbk" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2aaf59c4f7cso23533755ad.1 for ; Tue, 07 Apr 2026 07:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1775571324; x=1776176124; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MoaHdLbvRSpENl6/7Nt2U6qxtbcKulH2Z4vWlo4caD0=; b=O0TrQjbkGpCdNRf3ts7rQzwHUDhHlXMvXwayaoaUkRoD7Ext9YHB/vWQ+TgaHP9vQI d3xZKXxXnWNuyVquch08D1DPj20rcsNcQIKN5OW6hj/eVvowj0eDDl3VZ9AwliVVlhGu IQvZAxV0pFF4pdlvOf5CSxtBeOJvSS2TEvumg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775571324; x=1776176124; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MoaHdLbvRSpENl6/7Nt2U6qxtbcKulH2Z4vWlo4caD0=; b=WIzjfbC0B+bQ4wrM/xAIEHpCiYUtWHyxLwqGx4xMzlHyWtTSQSL2TrpSPTdEtnyC9/ SzBxe1y9p0N2XM0HBwI6pillV+/pXQOL2dHNRHR1M+QPK26kkMJ1KpJw9YHl59kHzLhB bugJIprtmhmVyPAos151EfgER2m5Dm+qa27aIgCuBxrQhc9Ro/iFrSiokr7R6vra5yrC Gil6wTJZh9gvagw67M6C+RB0itA4eD6BUQs2LdilIs2bnMXSI40EcwNVF+etHqPFpTMz mXWsZLnvFqe9avgwH0EwGd3Rcoe8JCawsp7A7r6c9usWtLnmayKDi1c/RBMPD4Gk8ZIG pJBQ== X-Forwarded-Encrypted: i=1; AJvYcCVkDnP6GDGZ1aUhmb6qgH4tmJC9Hzi4CX+j4z/uDZOczJHyURm42esw3lRlFiQjknqm+2beK0gVLWdBLmw=@vger.kernel.org X-Gm-Message-State: AOJu0YxXIRojumRAwomUnzhCVvtWOeKkCFL3J8ky+AVXDlN8YWXfTL7N ium+0npMPgKpSn1Uhg9M+ue0ju2hPA84NF+cqnImwZ7/vhWLrEkRYdCUO325GzBlug== X-Gm-Gg: AeBDiev+GYe9ZqXwGUMOb5ZfvoktmRXyEzv3Lk+4C+VUkLG2Fr+QmqVDe7rk42PKqWB xS5VG7BALD+XXKQ9SXFl3G9tOcpef8g9XIInLldZyQW+KZ7xANRRHuTcuso+b+Mq3hl4ITE3CdH iEC7hVWhdykw2jRlIi/dZxxI8dfxKHyjKsYPInANQ7uZOJBWZcnvC5xOYvipFNgW5csG5+FRGQi TpiNFozfhZfiNJMcq3j7Eq4+WwpnydiYQD1qxsO2C7FCmXc3/t1ekOzspFxWYMFQNZIBFtgoUWG OAiJqmlSFjkVh2ef22+0smKytFqDVQdtUrnGt91z3YMqMKqWtxoMWGc4WMxyqbBN0WSCIp/VMkJ C7pad50QLOEjAhQ7AsYiQymZfeTa3lNp5vdjuhW5fm6K/63MY0/FtsJzu2PbrQ09V5fm3Lrjze8 zA6hYimM9aNBRD1BRExrOlHDV6kTbAxJpCMvN+cIs6SSWPMQKHy2bOT9EzUOEOP4FLlNjXBzcUm g== X-Received: by 2002:a17:903:3b84:b0:2b0:6e60:9582 with SMTP id d9443c01a7336-2b2816dc813mr175580935ad.18.1775571324359; Tue, 07 Apr 2026 07:15:24 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:f201:1700:5280:dbe9]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27477c54bsm228587665ad.27.2026.04.07.07.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 07:15:23 -0700 (PDT) Date: Tue, 7 Apr 2026 23:15:20 +0900 From: Sergey Senozhatsky To: Andrew Stellman Cc: Minchan Kim , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] zram: complete parent bio on allocation failure in read_from_bdev_async() Message-ID: References: <20260407123836.6341-1-astellman@stellman-greene.com> <20260407123836.6341-2-astellman@stellman-greene.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407123836.6341-2-astellman@stellman-greene.com> On (26/04/07 08:38), Andrew Stellman wrote: > drivers/block/zram/zram_drv.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index af67937..f41f1ca 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -1437,12 +1437,17 @@ static void read_from_bdev_async(struct zram *zram, struct page *page, > struct bio *bio; > > req = kmalloc_obj(*req, GFP_NOIO); > - if (!req) > + if (!req) { > + parent->bi_status = BLK_STS_IOERR; > + bio_endio(parent); > return; > + } > > bio = bio_alloc(zram->bdev, 1, parent->bi_opf, GFP_NOIO); > if (!bio) { > kfree(req); > + parent->bi_status = BLK_STS_IOERR; > + bio_endio(parent); > return; > } This is already fixed.