From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6585387564 for ; Tue, 7 Apr 2026 14:18:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571518; cv=none; b=JTZlbsUtyqUIEwD+gHswMAqw2t6V3CWXn3Eefs199FXTzH+2ihspm0TmN8gC6QhaG7Qk1w1bInSalDgeuOkgMVOX4o4nrYmDir7PQKej7DYs6Ss0IKBhyGAHhxkz4AAhEn3vGUG7Z3sVbYtPBIxH3f8Zds0eQFutlWD+d3wQHLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571518; c=relaxed/simple; bh=FAbxKfIKlm5K4GityliR8DzwZwKcLwcKBzxInJTfvao=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K/LvOKxMooj6bFgrTclwgxRLar+yIsU3KDOWuSRjKhqtQP3FT5H3wrFZPAlqc3kVjox2yd/3Hud/6OzmamButpBCKQ70xoEAs9Bsnpg7cVSjpy/aIiNfBosVy+KZFcm5+zerV9N1CJ9LiTYVIV5k0Cq3zjF6DLfDFTwH11Ne71o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=P7q5ykER; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="P7q5ykER" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2aaf43014d0so35793925ad.2 for ; Tue, 07 Apr 2026 07:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1775571515; x=1776176315; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ybhOV7M59qcS0inoG4eOisgOE5yHzgiG7+ak5uhQEpU=; b=P7q5ykERiSd52/HAPjiFOzPg9TRVJG6ZfH3Z2bhoa+SGwiGNi8eLDE9gEpkPX4KhV5 VD0NpbUDjst7Pjx+09/TTpHg123t7gKKYtxQVOnyqARBIixr3wtPHhHE4hB8giKTHFXb 8Ev1h/A609+55slg2+V2AxR+GiRHZCv3G1A+Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775571515; x=1776176315; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ybhOV7M59qcS0inoG4eOisgOE5yHzgiG7+ak5uhQEpU=; b=ruZgMSl+krs4g9Ttx470/VoL3lGCZMVl0Y5i8iyyculeMVw9YnavJfyejTrU6gFcRC pGBBTO3D0C3Hytk2ywH3l3+enQoISDUKV3yPXI/q6JlZRezkweOMIaiU2j7V7izcYTLa jRm5v6u4cDMP0qGb4f9FeWx0RTdEgNjQlsI+iT5pakyEVx/hyQfkkOm5rsaXBDSAh6QX wQt5iX7/qJ+GTd4XVQj4ek9kwoYAJ+mczLtj9o29wQblSOgg3vtCDN9Ftzikov1LOrjQ EiEPD429Zd+7QiYpbUu0/4McXUkV1TvNjqrSBqACCrmapDbX9nR7Cr3xjIvGkySCh858 dAIA== X-Forwarded-Encrypted: i=1; AJvYcCXsJx6zQWghULK9Sql12mSbZZilntlxPCtpLn4i4Pnwfn77hSVbtpcLKoO6svsw5Zgg87Yoqx9y4NUKvY8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7AFh9xxb4ba5syLnmzd54YCf1EsrUi1p7ToTqoQBIbAkEAE8T g4M4dBHV6A4IFY51N604R9+v66/AJe1ouO1x/+xm+o5bFk9qzBXIfoCyNegVs3P4PQ== X-Gm-Gg: AeBDiesx3reYtRJAjczAx9b1PCCnftWsObkVlG0iFdgU2uxXRylIFqTLi1JSiTOi3st oSLbkEDVCM7WLUT1j07ZY5oqzCNP2hfCxgXCwoUj8QnNiZBjEnV/I0Ge//jWFcMABg/DNvGeHUe t9gre456oar9c4kXR9PmmvXnb8/FoiSvf52zJHTUIMyvft1lZ2YdYULgR4lnxV40voSrN0Cr0hf +hDPe/7/WM7vYsj8kg48pWd+3QzqEUZ6/si8qNKEfxWADIwntVyCmsGVmGiPFES3IAxXQyktCjU TyeSOHgXVigRqXH4hhVW0FiiCw1DHUcMQcjDf7TVIdOTitYYQL+sgpdmBJkwy0Tpc5v1mpntXy9 eGREpLwzeFFQZefhmM/D1lM2eBcNG0xXcgP/vL+mZm0MkHfzjybd4G8vnKYy3ZlLBRuog2DKdu7 ob2eIBJRnuBAWmjXf3Yd4eB8mZYYUt4HW7aHhocly+8Z+JME0CM+8u2syKvokTp1w= X-Received: by 2002:a17:902:f54d:b0:2b2:4e1a:aff9 with SMTP id d9443c01a7336-2b281997e1fmr179021915ad.44.1775571514844; Tue, 07 Apr 2026 07:18:34 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:f201:1700:5280:dbe9]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2745c480dsm226333295ad.0.2026.04.07.07.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 07:18:33 -0700 (PDT) Date: Tue, 7 Apr 2026 23:18:31 +0900 From: Sergey Senozhatsky To: Andrew Stellman Cc: Minchan Kim , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] zram: reject unrecognized type= values in recompress_store() Message-ID: References: <20260407123836.6341-1-astellman@stellman-greene.com> <20260407123836.6341-4-astellman@stellman-greene.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407123836.6341-4-astellman@stellman-greene.com> On (26/04/07 08:38), Andrew Stellman wrote: > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index 8ea2a12..67dea80 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -2555,10 +2555,12 @@ static ssize_t recompress_store(struct device *dev, > if (!strcmp(param, "type")) { > if (!strcmp(val, "idle")) > mode = RECOMPRESS_IDLE; > - if (!strcmp(val, "huge")) > + else if (!strcmp(val, "huge")) > mode = RECOMPRESS_HUGE; > - if (!strcmp(val, "huge_idle")) > + else if (!strcmp(val, "huge_idle")) > mode = RECOMPRESS_IDLE | RECOMPRESS_HUGE; > + else > + return -EINVAL; > continue; > } Let's do it like this: --- @@ -2552,6 +2552,9 @@ static ssize_t recompress_store(struct device *dev, mode = RECOMPRESS_HUGE; if (!strcmp(val, "huge_idle")) mode = RECOMPRESS_IDLE | RECOMPRESS_HUGE; + + if (!mode) + return -EINVAL; continue; }