From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 267DA3B9D98 for ; Tue, 7 Apr 2026 14:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571737; cv=none; b=gtrvP9yY8o99cBfNNPWiQZBljW2WE6AENHoCL24FOBez5UryC+Ny3IBfE0HCljydguTFSQRreRnz8hUg1+Sx+cV91iUCEGSJnQQv9okkQbxx9F9F0FQIbnFeiEGKs4ttqIGNUpmXm3/3/zNOtn0QAB+0nKYtjRzSfqt0KNS6NA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571737; c=relaxed/simple; bh=o1P0gjakWASjJripl8bLKBkikWHO1vI/dlXEldSh2VI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z3NDkxsaYzU/0KzsRxpg/9EiXoiTEauVluCoh97kjHbaPnUheBOB0Ky3DX1Khtqtr15frfLpLIrfNNUDOZsnwWwtjaTnkRb1EQKWuJNbPEHoE6Tq+ZKe5w537lS7aW61xzRZRl0yL8UWoCQ6PNBN1tKcAwqpo5spvJr1kHO2Yak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=nzrUnwUH; arc=none smtp.client-ip=209.85.222.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="nzrUnwUH" Received: by mail-ua1-f44.google.com with SMTP id a1e0cc1a2514c-953a2634777so1418743241.3 for ; Tue, 07 Apr 2026 07:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1775571732; x=1776176532; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o1P0gjakWASjJripl8bLKBkikWHO1vI/dlXEldSh2VI=; b=nzrUnwUHsmMTY+sV7GClfIcDNEiI2hxFyw6VUSjvso4eTj5YaKlOEzgxlwRkjff8lj siGu13poyfXKlg/qy5dBpxxq9SA8nwDvJgwsN1jvrncnJuASYJPzXGbv0/+4pe5uGUTw b29yN5iJtnfpvWpi/42QVAMeol79Ik99xmnuINxuYycx+JTBbi+06wHczfj90ZhC8M7h kge+ahIa/gQS0sb575ka7FpRtMnpFZ/Kpv+/hTierKQnv4S5b6bRYJiOQ4IQ+SeaW/wx S/vDkyF6nWxQ23CSn1iRPRqr1n5oJauYxATyO/5t+voumk8hHqHGs2vv+fL0eUmuQAMn HgrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775571732; x=1776176532; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o1P0gjakWASjJripl8bLKBkikWHO1vI/dlXEldSh2VI=; b=nyagQxsHtdiiP5W429hIMGhb46YbfDuKqN9GVprMmBDFq8q20w8prc02pSyEGbL1oW sowazUtpwFtBFIuNcANnhRTfM+8FUEcrSRmDM4H5JzKr2wDm0tpUeRZwgJv0ijqWnHki 2w9o3nbbQIZlfNAZugLfFlFt5GdzuZHW4pwC6jQ1Xp9Ot0zGcmdK5uzIPjHzeZxRwFeG FmzoQeBAS/Bew1FyIe3REA1at6a0isVAasmjfSn1Gt5BP8Yhs+gEQ51921BWIdgP/sau kL7jSp0nySJBXZXkxviR22QCMol0ySJB6c2DEJ0AweL+50miSbZtNP6QwZbJwDAaCk/u WvxA== X-Forwarded-Encrypted: i=1; AJvYcCULFxgRicoZAV9abuX8SPEU3ya1N57EHk5CCYLkVXuSnROoz/h5x+Q0BmKX1z7WKkuxrqKvSgIwt06g/Ng=@vger.kernel.org X-Gm-Message-State: AOJu0Yz74nPiNZGapehyFwPZqJoQLarEQ80idIdADfYMffIhQ6LFrEGX RgXjyCWQRXVjfKVJBgwIq6jnb/YTB5anre6iM2CAESsG/RKw8tXUuDOPEuTczhsoX2o= X-Gm-Gg: AeBDiescUNhwCtqQbyhrF5+hTtrH0vcI5rOa+nO/Y3wi4VjFi3oV6/glLg6GWQBzchE apVZgVrTCOQGlDSPjNo+NhlHA4kOSgKYdzCR9UZecs7Mq9NW5ZH94zJgW3L4XJ4WDiC26ABy+4R h9FpztwvJ6xGcAdiTA38okFbKYhQoNeDAYBP5+guGWBQbdtrjfZKbNnwFC/2tmAeZ/PJmauFOM+ L4ACEOHh+9JEIbdLyDhJ09wA5f69oHr6fuBiZJfMJu6F8iPPRae3HV9odqmwp0M+AVHqnwrHtzy +YdkCV8uJzpY8IQzDlt7weMNIdUTbamVUVlX8M2qSW5m4A6tIB0UoCJc8pYcztU8hYKUCGslVb7 xXGjEGHNieeQOSzZ2vMcce1e1gWyc+Hg3GstsMt2OeycfodCRnu4hwCxpQKVbFP4OMc2I3IQW4a jFKKnc0L8qSto6K6g5aHRdSg== X-Received: by 2002:a05:6102:6895:b0:5fd:f744:660e with SMTP id ada2fe7eead31-605a5129e8dmr5103172137.28.1775571732427; Tue, 07 Apr 2026 07:22:12 -0700 (PDT) Received: from localhost ([2603:7000:c00:3a00:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8a596915794sm147000106d6.30.2026.04.07.07.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 07:22:11 -0700 (PDT) Date: Tue, 7 Apr 2026 10:22:03 -0400 From: Johannes Weiner To: Jianyue Wu Cc: linux-mm@kvack.org, akpm@linux-foundation.org, david@kernel.org, mhocko@suse.com, zhengqi.arch@bytedance.com, shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com, chrisl@kernel.org, kasong@tencent.com, shikemeng@huaweicloud.com, nphamcs@gmail.com, baohua@kernel.org, bhe@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: move folio LRU helpers out of swap Message-ID: References: <20260407110002.204755-1-wujianyue000@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407110002.204755-1-wujianyue000@gmail.com> On Tue, Apr 07, 2026 at 07:00:02PM +0800, Jianyue Wu wrote: > All allocated folios are added into lru lists for later reclaim whether > they are file or anonymous folios. However those folio lru operation codes > are put in mm/swap.c which is not so appropriate. Because swap code is > only for anonymous folios. Ironically, the only thing that doesn't fit in this file is the swap stuff. The page_cluster & sysctl should be static in swap_state.c. The rest seems thematically relatively clean - infrastructure for managing folio lifetime. swap.c is not the best name for it, but short of finding a very clear improvement I'd just leave it alone.