From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FD003C661A for ; Tue, 7 Apr 2026 16:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775579059; cv=none; b=AAigrvhQltvRScxdrhpOrKtTXz5jXId+ZThzrQGMPPP81Q7rZdziIY8rj4RJcmgm+gXa3YiZZivZvIf7LVKQO1VDZNFQrKVs9SdhUVhynpekTIRTp2y8vgv28RE1hWwnYG2jWuA3AFRvfu4IrpuhVcKp7M3O2N/FNYLbTyKL56s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775579059; c=relaxed/simple; bh=s+B0zQq1Nw9f5HnC7IN8XejNsibwFPs8kWwZliQ5+0Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IsPZ+NZqqk/gpw8LfN6o82tAfOkFljroou1ld04H/uyQSotP8VT6WAdAD6rsuFQMzp4edqW0eczD4OD4X/x1btKOdp2ykgrlo37G3FJni2SABuoRyInosXUdd+oI7mTUxZ1wunj2+6P9D6TIwH60u2kZdq2hE+KGJH38hkLPzpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=N3y6/t2t; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=F0dOqWa6; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="N3y6/t2t"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="F0dOqWa6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775579057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s+B0zQq1Nw9f5HnC7IN8XejNsibwFPs8kWwZliQ5+0Q=; b=N3y6/t2tD8od+9DHEOxIH6+crqez0e1gw5zLSZrv4844z4fjikjBvxK8UahbUdkE1x1h8Q JKaAoPP9Nd0rJPev0PxBtPqcPXL8EkpdcFaCTWpyTWxx+kWJYhJGVfG0Hlj7yYY/2nQaMr Slunzd7e1TdxpJWuNzkWDf1zrzULB6g= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-WGDpG6_SPuWw0pfpDIZfcg-1; Tue, 07 Apr 2026 12:24:15 -0400 X-MC-Unique: WGDpG6_SPuWw0pfpDIZfcg-1 X-Mimecast-MFC-AGG-ID: WGDpG6_SPuWw0pfpDIZfcg_1775579055 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-488bd1ee9e7so6967205e9.1 for ; Tue, 07 Apr 2026 09:24:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775579054; x=1776183854; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=s+B0zQq1Nw9f5HnC7IN8XejNsibwFPs8kWwZliQ5+0Q=; b=F0dOqWa68hvq1b6GqGUJspT/UnsoKX2qPPWMDnrnlgDu5G0klSecMReVPwXzUKOPlh dB2Zdg0wkFXPXnLUTxxNleX5afsLmfgxBHOvvzEEIaOAhJYfDY5zbgkUyoWy2sqD7b0M DMXegUSEM6tWtQiUe4EMmww68irm3gy8TRrTXgFLwNkeaW/9idBSEtHOQW6Ou5oosG9x rJcApJH3OiEjaSb8MfPREadtKNNOpnTLYTrX6qXuvKJF1cCj4VB2wOU9zlcc0rs7o+qe 48DwO1fgjw26eqvN3Nvs4D/5OYFCWBvlvZnf7SRSvqrGQaCKSZQr5tImRegA6gE+YN2H 3Tog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775579054; x=1776183854; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s+B0zQq1Nw9f5HnC7IN8XejNsibwFPs8kWwZliQ5+0Q=; b=smsze2lQvMI08E0PjKQI/mNo/h4gZysN6IS/AjPj1u4zHU3s/yUB46Uvc2aOxXyiW4 dVLtaoDawpB44vck0TOAr/kEf97nyvfHoxIFIJXo+4HFGvVG317chO4fdGKgwS9mTPPg VmGgRsuAgt7GKewJli8arxT0JJjbqjbfKAmJEMi3R2eQuW7mJXCpDocNwl9z2j1q/fz2 F5GLSi2WZUkpEWRAuuLTtLZDLdzKXur7pkWyBkETSZv78BLdI9H6Wbd7ZeKLpOM0Apd1 DCJSDu2P1FIzytHl1IMNQobn1QKK72FoJh9U/vWT0q5/BW+Z5VTnF2vI4ePTrv/yscqc +ADw== X-Forwarded-Encrypted: i=1; AJvYcCXRNh+8vPe5+b0ZW6z5iMDK2MYH7xPtKBFRNnNmuOQeZLgXqgMbeyG++KcAJBz2MSdJssSNUCjCV3O3kkM=@vger.kernel.org X-Gm-Message-State: AOJu0YwSHfeodv+OIsO+dM4b9HlRfUjS20xP670j+aF6U+rY2GKm7bzH OOl6bTeDEZXPPFvWjhdZ95z6KrgshN3VBznVAyYMi/cmKZKEsspDLknMLhi3cnk0TwAWfTqBRjQ LIhOXIoDsCiwyuiN9ZMyvG0wuep3qYYCzEx5rcp7WIMNT5LIcVTc06kwsjpGTXiXMKA== X-Gm-Gg: AeBDiesIL+DybqtBa0loS7sGZKPQWqIMjCIDAZ80pDelRa/iBTUbtmCkzo6qCqpaZJe LS2Rbru4DGHldssjqMt5soh+bvcl1IlJ0gxbW52it91GXTjTly0hFyOko0oKledX5H2wma5EDmp Z93CNhtUU5BK11BQprhQMXuiX9azEG/CIA0h/zyixGvTdfZqvPW3hbroiugVBZHBQqJ4SGSpW20 cUdU374bKRKZubsWV9hGN2xdK8BhJUyOGkfAHar9a9shZgWYLjayL5/8omOjSUpfPfxsL2sjasB gQTYEXD4NFavM6cIXmQyJULBulMz/AvXhoitC3ltFZTaFTQbeeI9CChi8w/7JIksHIWo0YJdMAE 53cUxA+1bfrXgRMyTuqHexnMOuxI= X-Received: by 2002:a05:600c:1e1c:b0:487:1fc:14f9 with SMTP id 5b1f17b1804b1-4889978da83mr251016075e9.15.1775579054537; Tue, 07 Apr 2026 09:24:14 -0700 (PDT) X-Received: by 2002:a05:600c:1e1c:b0:487:1fc:14f9 with SMTP id 5b1f17b1804b1-4889978da83mr251015655e9.15.1775579054035; Tue, 07 Apr 2026 09:24:14 -0700 (PDT) Received: from leonardi-redhat ([176.206.19.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e80a616sm1043018385e9.2.2026.04.07.09.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 09:24:13 -0700 (PDT) Date: Tue, 7 Apr 2026 18:24:09 +0200 From: Luigi Leonardi To: Arseniy Krasnov Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] vsock/virtio: remove unnecessary call to `virtio_transport_get_ops` Message-ID: References: <20260407-remove_parameter-v1-1-e9729360a2be@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Tue, Apr 07, 2026 at 07:16:24PM +0300, Arseniy Krasnov wrote: > > >07.04.2026 17:31, Luigi Leonardi wrote: > >> `virtio_transport_send_pkt_info` gets all the transport information >> from the parameter `t_ops`. There is no need to call >> `virtio_transport_get_ops()`. > >Hm, one more suggestion, but not in this patch: may be we can also remove 'struct vsock_sock *vsk' argument >from 'virtio_transport_send_pkt_info()', because it is also included in 'virtio_vsock_pkt_info *info' ? > Yep, good catch! Thanks, Luigi