From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0926C35CB60 for ; Tue, 7 Apr 2026 20:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775592129; cv=none; b=O3S72rm4+57GP2jI70GvmRoE3DD2vL0xRaEe8OlmCKXEYtvNiKiW9F0S0JxD4AZP5pVJ2ClEoxo9MPaPPBbZ4nYKCAy8CwUd/AcMb83t95Y3NqLIjfVs62rHEl46BzdNWLcaJkQ07GG+OH3BhKOP4iYhXLtaXnT/UGDg6j+jIjI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775592129; c=relaxed/simple; bh=hJtN8K1NO+1GlGmjmYQ1CDezEvY+K0yC5MUDZO/1Nm4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pR8kn/FNIWotgWdY7JnXJF5YBpbvQoFM5/N09ATYovRVN72yoDas+OLmUKIafy+RMi0bI5KbcQ0ewsuHnSw+Q2Wv9ATcNRp3eXNtIv+r+0JWhBTEgfcr9YHeCobdW9HUp/SOvEgA0i0DDEau6/IWK9aHUPlaO360ATsd724qZVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=F874Wtgb; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=FqWx5VeI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F874Wtgb"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="FqWx5VeI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775592127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nwpk7x3/OYthLLbkTiH6r3E3G4VZBvtoK/r2DsOIAbs=; b=F874WtgbBPF7F1AEBKjxSHcuRnRoAGz1HpQBBrTe60Omy5e0m33bm9bXXs3EokqmlGZGx9 Fyy2KNSBbEauZCkRfgu75TeEMTDJI9DlsdUNVw837bBYJZPG/b3XwpVyEGxgEaMGW6mrRj sXnNhHouwIc8ZLXvp3g5Ly1sUk2N1i4= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-467-PUP413WGMY2HeS20NAQPwQ-1; Tue, 07 Apr 2026 16:02:05 -0400 X-MC-Unique: PUP413WGMY2HeS20NAQPwQ-1 X-Mimecast-MFC-AGG-ID: PUP413WGMY2HeS20NAQPwQ_1775592125 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50d8c192b3fso102501241cf.1 for ; Tue, 07 Apr 2026 13:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775592125; x=1776196925; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Nwpk7x3/OYthLLbkTiH6r3E3G4VZBvtoK/r2DsOIAbs=; b=FqWx5VeIOfWSE4/QZPtqixPyXmZl9IrlsvnRZ//NWBlMIXudBruVWDjKNnhSokOEdK +EdW+rCv2s5wFVVgeWnp169ci6NoZTPnwRptjRR3yrLm6v88iPCZk8ofdlfPJFdTU07F 6CD95+uOmTziiZsm57uj0+JdcD/VgTI1JYA7EOv5DWe/Wsb5QTdOfl7DmQe0nkTHT+nA ibDLeu6uriUa3ANx+VrRuB5ET91gwoPj+u/wKqjPwMQmYz/ilCxG33eAuARwQshXzhez oYaarivonjgfYRVuk+0uXvpK6NNeIGN0ptwnFDbZMaSMex2Uq+hvsVIjCS1lmbTfYP0x LKuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775592125; x=1776196925; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Nwpk7x3/OYthLLbkTiH6r3E3G4VZBvtoK/r2DsOIAbs=; b=bDCxN/zJInR84T25WO4vWqMYbvwNtMK32F1WVtLCJsFVsafF/AQSX14FVJvZEjmRrL wTtZcLnmVkr5XHSv5K3kzEx8m8gBh8Ufoqh4JuztqpQQ05RJ/ehvjDeufNUoWICA/+L0 M42/tVDqEYc0wqMkPoiyXb2v4SwnnQwiRuXvuR12oU4mwArExEZHzlbl34uKrcCgCv+o JxabwNaaPKN9yFP4/5FQMaguYZlBcaxg8v3UvlZ8AzwFQQLhOK3Mg+LSciHuzkGXgApo +il1uazeRSXV9Rl4gQzdpi1Wn6w/MeArij+YPrkXNrhm2eeez79caxW163STtCFYqauN Ag3A== X-Forwarded-Encrypted: i=1; AJvYcCVtkEiMnf0V6DVSZj9q3Y0NYWMTO09fg9U+h1IRBSQp7ciuJSyDpI/0G69+G+DAWNfDgFnvRn1v/0zzv9U=@vger.kernel.org X-Gm-Message-State: AOJu0YyoWSA/+xRWF3M9lPK2fo9mqeXPFeNiZ4FuyYqWMY/luBOpjPp4 TnUjYmDsbqqndkoer1LQS8ZZE31dkYwYav7dn+kO7HMHQXJVH6u18bQZWsFA073bBC6nQIgxwiW QYoSvh4+OoyJST9eyzAMKQ4dUomDzagxEVSJMIs+PDQPhETmbVtyda3+fhP7z84nxSx7J34OWbw == X-Gm-Gg: AeBDietVUQIoaem1+PGUCKaGbwDLCEQGrHTL9gQPGt2yHJd0W7WVj4INaFyl0R9Nj00 0QI90N8+Iwy+wByPmgDHByA5T9PhmMx7j8FFYr+GBRgvg1m2kpPgx2ZPvZMqve00Xdr1VPLdWrI +sMScvg2xKBkPfxFfsoNQfS4FcI5uPviXdS37GY3x8Y7c7HbcNd83sLtq1dGEqCin4q6TPMmLL2 jZ1AMDQ6y2XPw/tMOeaMn4KfjXk8sTBNHfYfPveYHN5O4EIEsJNJeKcicGvw/jiMc4vgqFzc/nz 2LxwdarwyCIEhxor2oOFutfGNaBBUQJbNGrVPRut6GwjMIufWsbR5lO5dT4GfvhIVmBt1udlcZP y1bz9T5LvXvc/QfdCSNA= X-Received: by 2002:ac8:7d16:0:b0:50d:66b6:1564 with SMTP id d75a77b69052e-50d66b61c27mr270620041cf.14.1775592125157; Tue, 07 Apr 2026 13:02:05 -0700 (PDT) X-Received: by 2002:ac8:7d16:0:b0:50d:66b6:1564 with SMTP id d75a77b69052e-50d66b61c27mr270619401cf.14.1775592124495; Tue, 07 Apr 2026 13:02:04 -0700 (PDT) Received: from redhat.com ([2600:382:772d:3619:ed0:4a9c:acd6:3fc9]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50d4b32b59csm177586281cf.13.2026.04.07.13.02.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 13:02:03 -0700 (PDT) Date: Tue, 7 Apr 2026 16:02:01 -0400 From: Brian Masney To: Johan Hovold Cc: Stephen Boyd , Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sebastian Reichel Subject: Re: [PATCH] clk: rk808: fix OF node reference imbalance Message-ID: References: <20260407095027.2625516-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407095027.2625516-1-johan@kernel.org> User-Agent: Mutt/2.3.0 (2026-01-25) On Tue, Apr 07, 2026 at 11:50:27AM +0200, Johan Hovold wrote: > The driver reuses the OF node of the parent multi-function device but > fails to take another reference to balance the one dropped by the > platform bus code when unbinding the MFD and deregistering the child > devices. > > Fix this by using the intended helper for reusing OF nodes. > > Fixes: 2dc51ca822e4 ("clk: RK808: Reduce 'struct rk808' usage") > Cc: stable@vger.kernel.org # 6.5 > Cc: Sebastian Reichel > Signed-off-by: Johan Hovold Reviewed-by: Brian Masney