From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DF931C3F31 for ; Wed, 8 Apr 2026 02:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.13 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775615180; cv=fail; b=haz0jhHWuMkj1xpwUG5PRl2zOjDWKn8wqIbl9S5x9KeEXBAd0GOOnYYu+CoTvFmpP4n/iprc5shkNCJVlQzTUfcq4fLaVtlMC/Ot4Oqki25BWE+vyhrNHxzxH4wjTODrA2Yr6DyA9BdtQ0zBT4d1AWkTltpDWgQNRqqNXK9frHM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775615180; c=relaxed/simple; bh=qknDka9yvkSsygtQzu8xJBrL7CoURHAIr3SQ3ty8n+k=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=jk+WWCNq0FfzrlenbNsHnD54jg0RVZ9wxew/Az0uRI8KwSNJwhd69z2UTA7pDjz3vl/0Z4gUXosKkU2Ck2ZZNyG1F0t2Wyst15TIEa+XyYRe3coexKor3gfojw34Iqb5p5FnQUpkNFnse7XJdZ8fNsQpFw+GSMrnKf/HoCsBP2c= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OCoG5sQi; arc=fail smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OCoG5sQi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775615179; x=1807151179; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=qknDka9yvkSsygtQzu8xJBrL7CoURHAIr3SQ3ty8n+k=; b=OCoG5sQidDPa69uOZUchVtrGODy8ZdXZZd6iXryUEOGjiRcA5vwZ5ouQ BINuD4z5deztdprFQzCUZBrWjBoPoZ6zKi+2SvtbvBvL2pqkyCtCnlpN+ rCDvzcgavnsH40DfWryET17815iFQ0Cf2utu6eeLBog4oSfA2MBa2NCo+ CZEYMgQdR0sN5iOEum0QW8gXQ+dD/GvN96noj5nrI3fP20/d6QCcUKt9E 0AdhnRl5rz6yQ3pWgvc9se7OoOksbpSwMjDYLX4YzWrlZmJi65GZm3M5/ bukzSKu9KwS3fi64ZdJ8E4t1P6wthk8+2mV7c8Ug8tbiLsVFkHEPSifpG g==; X-CSE-ConnectionGUID: lS+fcw/eQeOtx53Ago3hig== X-CSE-MsgGUID: g5GEaMeJSLydbi0hXDxF1g== X-IronPort-AV: E=McAfee;i="6800,10657,11752"; a="87664396" X-IronPort-AV: E=Sophos;i="6.23,166,1770624000"; d="scan'208";a="87664396" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2026 19:26:17 -0700 X-CSE-ConnectionGUID: twZta4xKRzynZlyU48K7cQ== X-CSE-MsgGUID: Zq2I2I+tQYWN49K9MHX6WA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,166,1770624000"; d="scan'208";a="266316095" Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by orviesa001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2026 19:26:17 -0700 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 7 Apr 2026 19:26:16 -0700 Received: from fmsedg903.ED.cps.intel.com (10.1.192.145) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 7 Apr 2026 19:26:16 -0700 Received: from BN1PR04CU002.outbound.protection.outlook.com (52.101.56.67) by edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 7 Apr 2026 19:26:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vIrb05qgApQcQn/M2rahjj4glVIJl7ASAxl1bXynSoGxvmdIV3dLP3wNTU2FZaSpUsOl7ocJxRt+i0EKPwnUVJvnMvVRiAx6zDaoXeghl4QrLE0CXV4afRNn1JCIULllhhD2pOl1uVeFT5QvxszJbO+bd7JH75JCwH9b4Fxkx+XqmbDVYZykspTMHT56tnqfuX1zv0op4iCmFJcEBRonw82HrgVOkspqqmSH1NXVgnm8VBaqLIzEbtTR7c8apc4oQw5tQl+wBiEIHLpcERgyuqvcg0oSSgl29E6CNluBFsowG3KgSasEAjybOXr735HNkwy4ya+Q1UIliVEh/f/kvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QJ5WowFL5Njuoo0bZ9PMwHCNJ507rQT4jBLdICKM7gI=; b=JyivXuqIemX0glY0aC28ys1G6KTA6txJF/hp3DwyWhNhwbvfIg1JlUMLIpAfOCpdL58PY0eNYNVddekIvnOvChCNgGsoF2Z2HTKRlHHetf+p24aS+YPhnIkGmXAzxT4W3kSiMlXcQRrLXnouHdQc04bi4Kl07BzVCsAVtTLLY0JuLOQiSr9ZFuImP6UR73ChTX+yD+IPbLVCQykUFi9YstasOHo8sm1wr5LovcMPWDnfUBTkjKJcVid8+D61yDxlqTGeqsRpO/qkQngGmB15HIAA7NorKVPCNm6ZE4DBhLtchZaQDHNnw+f71k8HSjLwq8VwVwwSkSCBDDOa5S/l1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CH3PR11MB8660.namprd11.prod.outlook.com (2603:10b6:610:1ce::13) by CO1PR11MB4963.namprd11.prod.outlook.com (2603:10b6:303:91::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.20; Wed, 8 Apr 2026 02:26:13 +0000 Received: from CH3PR11MB8660.namprd11.prod.outlook.com ([fe80::fdc2:40ba:101d:40bf]) by CH3PR11MB8660.namprd11.prod.outlook.com ([fe80::fdc2:40ba:101d:40bf%3]) with mapi id 15.20.9769.018; Wed, 8 Apr 2026 02:26:13 +0000 Date: Wed, 8 Apr 2026 10:26:03 +0800 From: Chao Gao To: Russ Weight , CC: Dan Williams , , , , Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: Re: [PATCH 0/3] firmware_loader: Fix shutdown ordering and reference counting Message-ID: References: <20260331214726.903274-1-dan.j.williams@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: SI2PR01CA0043.apcprd01.prod.exchangelabs.com (2603:1096:4:193::12) To CH3PR11MB8660.namprd11.prod.outlook.com (2603:10b6:610:1ce::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR11MB8660:EE_|CO1PR11MB4963:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e3c8365-1aba-4ba8-3a1f-08de95163434 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 7wuM41rq+6EvTolUDA1DwEseN6AY0bwTFzG5aJCY2f8rt/WqGU2/MQqQQLKoR89Qrp/srDqaLQPWe17JmEtBC2kpZMyqBATBiCDTl+bL6PL/w+Jsgtf47EsKcvOAmR1EVoHNejOAkB24DkyjvNYsC0sBZ1Krg1BYQiennvvuC4z2iN0nd0/uaFIGYZVDpLFtv7WlSFOGUshqR3i7JGX3UteKqCJHPzr8a444s9glIVxOWI/APDF6Pp4LprWN6Fv8d4aB+PW/C6EGkS0nfVKeRCOSe1I87IUQjwslu/7aVaAXyecsFVphBjzMYUuMMYIdG+okManbFpHrBduVHJDp0E8fn5squ7nN8w9MB+8Ih3olIhTBBnocWH2lbJqDlJwGYs6ZcRPyrYmVftCjz28M6VtVjcXLvA3Og2+Y/n4RZ+TkN34AoVrrNfLXmDu0xVW+hnp48y3/Pkz779+YZWIm6I+2lST6RZTUded3IbYYCbXoiqMccn32cZtXxeN6kjo7XvN7PIyUyVFptVdwo3QfPwOco2rRk1q33Ut3nL6L5iM2nwrMDdANjKpRZ8/0qfZoACPyW02DP8H21O1pyZ/VEZ0zPeFNfUkabyQiE4yxNt+s0A6DKZtxG03U0CkYWxI3QtbQ6jT7w390enbOhMZxnh/Zwjhoj5fn1bVqeiaCvFhS30kSlXs5t9mMuzMYOjN5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR11MB8660.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDMwNnNSeUprcmovZk5WdWJiMDJJTncrejNPNGNUS0xpeDR6WUdCRkZGVjhK?= =?utf-8?B?d0k0NHBBWE5qRlFWenQ5Tkc1Rm9qVnJiVkdNMkI0WSs4RzJlQ2t5RkRGdTlx?= =?utf-8?B?VUZJWU1NWFZTMitpNHozdmIydVB5OTlEZjZBL3JmWE1MMlFoUHIwWlVXeUcr?= =?utf-8?B?bUJmSkN5dFhTSkJQb0F2eFVRN05qWjh0emNiaDEwRkcrazJyd1E2VE5Wem13?= =?utf-8?B?Qno5THZNdExxblR1b2p6N1FvNUF3MlhCazhUc1JISmE0RVJCNnYxUjcwUUlB?= =?utf-8?B?TnpGS2NVM2pUSjhPNnJYYjNPdUtDNXF6ZzNzNDU1U3pkRGpUMDhBOGhGMzc5?= =?utf-8?B?OTBCNXRBNWJKRllxcVlxWlFqRmFkQ0dLUUVFc1Z0VFJHZ3AxRm9DQWhNSzNm?= =?utf-8?B?UXNsOU9BbnQwcnpzanNZbXZZT3UyN0R1MXg1SWVacklnZ2lYcTVxUlFkRlpH?= =?utf-8?B?anBWSk42TU5nNXBmOGdqOTU0Mjg4VDg3cHN1ZFB3Nk5pS29DOThKV1psdU15?= =?utf-8?B?TXd0UU9GZWtlM1F3ODlSbXZWbVowL1lZYmQrM0xXYzRBeTRUTE53RkQ1VDJh?= =?utf-8?B?QXJVVjNnQWFEN0ZwcFdhNW5UM1Q4Ym5NMW5KZ3lROUZjNG95eitHcmNuRWdk?= =?utf-8?B?TkdaTmtRUDd4Z3I4RWZocWVPMmVKNnpDUkxlU3A3ekNISzNQV3ZlU3pCSWJr?= =?utf-8?B?bVhkek1lZ2VMYXVOSzAwZmdyM0MxTDlaMkJvakhzeiszYUJWYk5PYWU0N1Yx?= =?utf-8?B?QzJFbTlHd09RUSsrVHZKdStaeGY4b3JweWxEWi9qbk9kUm0vMmRsRlJqV0Vy?= =?utf-8?B?MXlGWjJnMlp3bFVoTlBSOU14SVNNdExTdERNRWRwcndyQ2pCZ0VwZTR2ZWo4?= =?utf-8?B?L0ZjUmtnWG1MZDZ2REtZcW4zUUxtNW1SNFM4dzVOTXk4djZzUUJRWVU3REhp?= =?utf-8?B?Wms0cXlkd09JTys2RlVwaFkzangrN3JPR0prRkc4cjJoYkhEck95WSt0TGhU?= =?utf-8?B?V2FjaExibFpkMjlmMnZ2UzBwSldya0F0aGR5d2Yvb0lHTWtES1IwYVgzNEk5?= =?utf-8?B?RHFHVUF4L0JWME55NXVCSTFwc1NESnp3U24vYS9kYVUrTnN6OEpBa21lZU11?= =?utf-8?B?ZTlJeFF4d3ZDb3NNMVRjRWloT3dQZjBaVHBPUFNDdkozK3hmSGRrZjBGNEZh?= =?utf-8?B?VWx5VXUyVzRBRm1ZSjJLZWVHS0JyUFhpTUxENlhndlZnU3ZQS1NIK1N0QlpX?= =?utf-8?B?TnRVYSt1RDk1S0VQdUgyYjhaaVUzU3J1MC9RM3pRUSt0RXRsZG05Q05iVjVT?= =?utf-8?B?eHh4ZW1tTGtGZ0EyUkxuWEVZb1lnZ1A1Y0w5MjVEbTk1cnNRK0t4Q3ZzZ1pO?= =?utf-8?B?Y24rVHF5Nm8wYnMxTi9yUk1zVzRlNDR2R0hLaW1EUTgxWXNmRE1kRjZQSHl3?= =?utf-8?B?Z28rRjVvdzF5eDd2UjJMUXFxbVJrWTF5THk5QytRcFpNaWRFaTloQzhQUkFp?= =?utf-8?B?c292aVBxWHZNcEpMTmdrYVI5RC9XVzZkRk4vaXFVTVBNaHg0VkdwN0o1cVY1?= =?utf-8?B?blpqS2FEWitTbEprNlF5ZDVUSVdSOHY0NWpIMklNanIxa1dRNzNEM29oRGtw?= =?utf-8?B?RCtnRklrUGlrNlpUd1M5QkZMbWlwTDNsbDkzYW5sOHdSQzFNVEhhbTJReE9a?= =?utf-8?B?dEYyU2lOUjV3WDFQRjdIeUlFRTlMdmczTW9QNE5qN3lZVGZqdnZWOU1RYlp1?= =?utf-8?B?T3R4NmgzamM0Uy9ZRlprVXlBVVVGaERhcU95YmYrTkNLYzhnMjlzcjVRZUl5?= =?utf-8?B?RUpPWGtnRFFpdFkvc21tczNmQjFDejZDMjM0WlNzN1l3YTZ4VnBwNGpleUcy?= =?utf-8?B?U01HakJlU2NDVVhBeUxBOXVnaU8xbHdUV2psVHFZOGZ6R1YwcHdKYkVlV0U1?= =?utf-8?B?eURMS2h2ZjhKYjBwUXVyM0JmNnI3aVBOb0tvRHJkQTdyZSs3TmlYbU9FSzFQ?= =?utf-8?B?c3ZoeEo1dkZoZDdpVWV2TFR3UlVJZ1dFQk5IU1VhOE9EZHJ1QUxjaXZiUWhR?= =?utf-8?B?R0txeGIzRnNjOVI2cThjSUFoV0J4VFhydkZVdTRTZkx1bXhXVTIxeUE3S0Vz?= =?utf-8?B?WENBVmlRVzJrVE9HSUQzcXFiNUFGVHY2Y3lEL1YyQjhHUjFQb25SZXlRa21x?= =?utf-8?B?ZTUyVnZPazBoR1hKSzBVdCtvcjVJSEJDcnlCWTdsS283UExyV2FQNTZrenlD?= =?utf-8?B?YjhHSDE4N3hXL0xOUlBrYnhFaWdmeUJDbWRSTTlIQ1kvaTArc2o4MjlXZkFI?= =?utf-8?B?WWhNLzh3STA4elJJdWEzdzdRNXo2VjQ1VENmYzFRMzFZOFlyY0oxdz09?= X-Exchange-RoutingPolicyChecked: DptaMWs6k0Tr58otM72PVVxCrOUkyOTHhn8bDZ3WhPOa75W/RGMmbRmHsK+F+2nuV+QF5PZSRrQLppIavhMGMVnNv9C75qCtVRxAInom8a4vJYsCm++AJJObNN4rnsZdVjDbPIwt/vgi2vEiJYj5V5ulFL0l6r9qpfUvK+axjNZC+z7JkRYsU0b20IzYrgOkCWUzPOHWS3NrtRQk6SjBJuEM2IiYUNcgKQO58hrx7+UlOAaOBOBR41u1YbR06GLAYAI0kWquvAUk2df5kubuzK2zna9WNGwVuc1/5VAfk2eLGg1lwoZGgS7T2Te4uF3Fcu/JVLFRPHLnK6fqx6uxnQ== X-MS-Exchange-CrossTenant-Network-Message-Id: 9e3c8365-1aba-4ba8-3a1f-08de95163434 X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2026 02:26:13.4775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U704fRCI7VOQsLpg2ynA7p2TYlP98VbOdnJBLsGdqJLm2ceFPeEoBzGWzeexGqPDHZajnLfLH3rPsKDaDYvSLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4963 X-OriginatorOrg: intel.com On Tue, Apr 07, 2026 at 01:24:03PM -0600, Russ Weight wrote: >On Tue, Mar 31, 2026 at 02:47:23PM -0700, Dan Williams wrote: >> Chao Gao raised a module reference circular dependency report resulting >> from *correct* usage of the firmware_upload_register() API [1]. The >> module reference count is not necessary nor sufficient for protecting >> against racing unregister against in-flight requests. After that is >> fixed, a couple more cleanups fall out. >> >> [1]: https://sashiko.dev/#/patchset/20260326084448.29947-1-chao.gao%40intel.com?patch=10705 >> >> >> Dan Williams (3): >> firmware_loader: Stop pinning modules on registration >> firmware_loader: Stop pinning parent device per workqueue invocation >> treewide: firmware_loader: Drop the unused @module argument >> >> .../driver-api/firmware/fw_upload.rst | 2 +- >> include/linux/firmware.h | 15 +++--- >> drivers/base/firmware_loader/sysfs_upload.c | 48 ++++++++----------- >> drivers/cxl/core/memdev.c | 4 +- >> drivers/firmware/microchip/mpfs-auto-update.c | 2 +- >> drivers/fpga/intel-m10-bmc-sec-update.c | 4 +- >> drivers/greybus/gb-beagleplay.c | 2 +- >> drivers/media/i2c/thp7312.c | 2 +- >> drivers/net/pse-pd/pd692x0.c | 4 +- >> lib/test_firmware.c | 3 +- >> 10 files changed, 38 insertions(+), 48 deletions(-) >> >> >> base-commit: f338e77383789c0cae23ca3d48adcc5e9e137e3c > >Hi Dan, > >Thanks for making these changes! Overall, the changes look good to >me. However, when I apply these changes to the specified base-commit >and attempt to build, I'm getting these errors: (+Dan's new email) Yes, I noticed that Sashiko reported them. > >drivers/base/firmware_loader/sysfs_upload.c:229:24: warning: unused variable ‘fw_dev’ [-Wunused-variable] > 229 | struct device *fw_dev = &fw_sysfs->dev; > | ^~~~~~ This can be fixed by applying the following diff to patch 2: diff --git a/drivers/base/firmware_loader/sysfs_upload.c b/drivers/base/firmware_loader/sysfs_upload.c index e0cf4c55b520..4ce64411f656 100644 --- a/drivers/base/firmware_loader/sysfs_upload.c +++ b/drivers/base/firmware_loader/sysfs_upload.c @@ -226,7 +226,6 @@ static void fw_upload_main(struct work_struct *work) int fw_upload_start(struct fw_sysfs *fw_sysfs) { struct fw_priv *fw_priv = fw_sysfs->fw_priv; - struct device *fw_dev = &fw_sysfs->dev; struct fw_upload_priv *fwlp; if (!fw_sysfs->fw_upload_priv) >drivers/base/firmware_loader/sysfs_upload.c: In function ‘firmware_upload_register’: >drivers/base/firmware_loader/sysfs_upload.c:323:34: error: ‘module’ undeclared (first use in this function) > 323 | fw_upload_priv->module = module; > | ^~~~~~ the @module field should be removed in patch 3: diff --git a/drivers/base/firmware_loader/sysfs_upload.c b/drivers/base/firmware_loader/sysfs_upload.c index 4ce64411f656..ee4d78443e3b 100644 --- a/drivers/base/firmware_loader/sysfs_upload.c +++ b/drivers/base/firmware_loader/sysfs_upload.c @@ -319,7 +319,6 @@ struct fw_upload *firmware_upload_register(struct device *parent, fw_upload_priv->fw_upload = fw_upload; fw_upload_priv->ops = ops; mutex_init(&fw_upload_priv->lock); - fw_upload_priv->module = module; fw_upload_priv->name = name; fw_upload_priv->err_code = 0; fw_upload_priv->progress = FW_UPLOAD_PROG_IDLE; diff --git a/drivers/base/firmware_loader/sysfs_upload.h b/drivers/base/firmware_loader/sysfs_upload.h index 31931ff7808a..dc7ccdceb96f 100644 --- a/drivers/base/firmware_loader/sysfs_upload.h +++ b/drivers/base/firmware_loader/sysfs_upload.h @@ -26,7 +26,6 @@ enum fw_upload_prog { struct fw_upload_priv { struct fw_upload *fw_upload; - struct module *module; const char *name; const struct fw_upload_ops *ops; struct mutex lock; /* protect data structure contents */