From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98F4737B02E for ; Tue, 7 Apr 2026 22:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775602693; cv=none; b=Das1LeS+DImpv7VceTnq5ubP8GSViKgRwKM2x1W9qrzoJ/ygiuck8Be2O2lrGGrYFHVIK8mrnC3GpjoySUJUVXf4EZYVxt7m6a90gYvMoAtKflfmZm6rg8iJ1rOJai3pxAa4tzBeCCuyGCjTVc1a4am5GOoulMYnmDn+g5iXZT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775602693; c=relaxed/simple; bh=37xMryUjFIJ4OPQ3axPGjItRm6RjQqDybQiLZIPuX44=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lmm4F9YlopB4405+WQnZg+e7bfnqDcEWy5JgXMOHnkV7ycuhPSgTN/mS/9R2j7ycyzU0366lwm6l9YBTkURwsWmUJ5jX39Q6Mut4VR0uKTHhXdspOHdf/6qaT6IHeiA3g04S5fCrhisQLpk/Qtzr2mJNs2M3mrTEzy80Yb2IUvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s2OIJWI7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s2OIJWI7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00A7EC116C6; Tue, 7 Apr 2026 22:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775602693; bh=37xMryUjFIJ4OPQ3axPGjItRm6RjQqDybQiLZIPuX44=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s2OIJWI7cUQMuhxlgnIVevRFIb1sCVmdJyn84HJfsIDG6A1rjKn/t6SwHr3hu5znj FqlH/jmE/CLkMrarpjLnxET2A6q6u/+J7NQrJo871hN4bvdX7rSSpWkW8eEsVQKvqf U8VaRavbM/jbeSIcTKZ9r0gvGEj8ZlekZiQkxmC2fh3qP1sACxjLyfRBV4KW8kcFmp +8ZwPFcN770mpRKVdOkbHLfaEvDpuTY1Xv1Fpt1fdY9yA3SpJhUo9Lulv0Np3VmR79 DwOt+kULTaafbpefBACpVwEnJLkhNDt3ecrrcT4uNDQ29Awmx7q9hI2XgoRxSM38GA XXi+CjrhrUBbA== Date: Tue, 7 Apr 2026 22:58:11 +0000 From: Jaegeuk Kim To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] f2fs: do not support mmap write for large folio Message-ID: References: <20260406154940.2407853-1-jaegeuk@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 04/06, Christoph Hellwig wrote: > On Mon, Apr 06, 2026 at 03:49:40PM +0000, Jaegeuk Kim wrote: > > Let's check mmmap writes onto the large folio. > > Why? And how is this not breaking applications? Since we only support the large folio on the read case. > > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/file.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > index 2c4880f24b54..edfc3a374c40 100644 > > --- a/fs/f2fs/file.c > > +++ b/fs/f2fs/file.c > > @@ -82,7 +82,7 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf) > > int err = 0; > > vm_fault_t ret; > > > > - if (unlikely(IS_IMMUTABLE(inode))) > > + if (mapping_large_folio_support(inode->i_mapping)) > > return VM_FAULT_SIGBUS; > > > > if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) { > > -- > > 2.53.0.1213.gd9a14994de-goog > > > > > ---end quoted text---