From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09A1E309EEB for ; Tue, 7 Apr 2026 23:23:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775604183; cv=none; b=FVpYrax4Er7ddMidq63qQOtXra8ispTji0fZYe8vtB0MGRag0BSWzW8CJgLoCbLWrL9SYCgBKKgOkSdMqVVY3+ERPFpUseJYtr4MsH0KXZmk/MKdviR7tG3eKBsN3Tz3nT7DE9rC0a1qSI7wATOqrMdLpS+7YTrs5wOBY3AlhKE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775604183; c=relaxed/simple; bh=2ld9iGsd3tkfTJ7I+r4T2HzSpJWuUQNwwqwlZBNXwho=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=amq1/2DDuPAbzmb+pVUCqnez98pl181p/4YUyt7Z5ppvzbjmxHXVgU8kinwWOZww2lQgwZxSnLOOjTvCFYhy2SVMFbDVF2RsBIrOY6gn30nDdJbap+ij28rDrIQUdn6xWowbojR1O0Ek0SN5BOFOaALsiyH5X/tOH831gmvmsMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=gYmOn3Ho; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="gYmOn3Ho" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-827270d50d4so4927612b3a.3 for ; Tue, 07 Apr 2026 16:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1775604181; x=1776208981; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=eVvnM/2IBYVPmVA0rMm5aM3MfoNB4bAJvfYogxqAliE=; b=gYmOn3Ho/Fp1xqIJrny/Bj6a7wBAusnwTzAXirV+QIUkCjxiZytSWR7tgPyiu53Xg8 WDmqFXeVUfsUqMZMoolVv+wp1XzsBk18QAF/OJkfJaHsSijmkADxAme2MVeR4WnQr3p/ nV1DcE+K8wso6kkg5/MTZ+W2Hknkpt+ptFbJWfBaN9yRKTH3uGF08S5SRZ2FE4EfX7KJ 3Ex4LhGUinLTRG74I2sAoPB7SrmMj3zQ6XweMRhTFwwrF5kvMyc9s5zHClQqX3mvxAO2 3s3el7jpu7KjAS3oqMSMhNWU/A8aIdbXDzj2fgMZLbj0LxDeLDdJ1AVohGec+psDDe7O zs1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775604181; x=1776208981; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eVvnM/2IBYVPmVA0rMm5aM3MfoNB4bAJvfYogxqAliE=; b=BAqZJRP2is/V+2BQetlFXM82+pqYdiYIvQvZ+W0RrQHrsbP/beB/f6yqxl82FxYOsM cOzSUT/2sTGzsKlP/jBgclhUkpirmte+wk7LUSnbLvM2aFY28HDSJdVYcVNVOq1Pd5Qb iFx16tmJ/0tXazPDsB0m/67vKMANlQ58PbLAYUyp9irFNKQ0JXT7oSBw+T9+HEhVs0kl 9Qeuz9RD5ci92LdHqADMgWYf/9Lnoj+tK20IbWk57BCqO+4EQ2aK9xNoVetQHwcDiHWD mn/IVUQsnWdeB0d3RgRA1NaQR/gsx1qNCEykH57sBtdiR0y4hcbI0Vqsz3ngq0vFqTko 0SJg== X-Forwarded-Encrypted: i=1; AJvYcCUnsbXfAT/B2OpJU6GlpPM7xjFYetk9dSEsZ4XOT1GxgDvKoDW0mydQZU6iqZxxLZ2YGkZY3x0RKrZ9vTE=@vger.kernel.org X-Gm-Message-State: AOJu0YznImNGk2/BtcCbMOVL/Tk8vJl6OQDZ9AOkUK6xH2zL5FjG/8w4 voV3qPRAQAAfxZF2Qd6yMbdHmye5iS7/m/jxe6vgMsHqAPNKXj2hDfiZ14L017QB/mU= X-Gm-Gg: AeBDietAe9vmeqy0KEm+I4ZCsun2p0ANhM/zpg/3V6yAYw0nEAHMk3ebUa65w9nAamC xzOYT1i9aeJez1osCkqUsrCoF6ta1y0T4jh85V203ioPtoi6c5dRAM63HlX78VuxBHkMYthACsV aoQLVQIEdjTkbR+Q/9f7eoYn2lFCJeAMtOIL0QqtnYRnADAHUNkUg+OrWoNJg0H9h26EM4y3zSz plYi/8ILYd/yhT38Fj9AjHLxRsApmLC6f1gsSneCCEryyL9dk/0omeH/BmmKuwiIxJq9ZvbS+Hb bKwGkkGW9QIl80AfPD66r4xkDctNEcKsQ6/4BcSi6hjgmW33bbh9J0k5ApAU8+iSPwb4O9ffPrM Ryr1UNPFK0W2r9vQW6bJ24VeyccT2X5RDAc14skV2wQ8R/luyxTTQLMNLXTUKAvmhwbxyPwUlKY Mkt+W337ZRlr7IImo= X-Received: by 2002:a05:6a00:9083:b0:82c:d7c9:5489 with SMTP id d2e1a72fcca58-82d0db7e287mr17570997b3a.31.1775604181371; Tue, 07 Apr 2026 16:23:01 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:71::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9ca79basm22750950b3a.58.2026.04.07.16.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 16:23:00 -0700 (PDT) Date: Tue, 7 Apr 2026 16:23:00 -0700 From: Joe Damato To: netdev@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: horms@kernel.org, linux-kernel@vger.kernel.org, leon@kernel.org Subject: Re: [net-next v9 07/10] net: bnxt: Implement software USO Message-ID: Mail-Followup-To: Joe Damato , netdev@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , horms@kernel.org, linux-kernel@vger.kernel.org, leon@kernel.org References: <20260407220313.3990909-1-joe@dama.to> <20260407220313.3990909-8-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407220313.3990909-8-joe@dama.to> On Tue, Apr 07, 2026 at 03:03:03PM -0700, Joe Damato wrote: [...] > v9: > - Added inline slot check to prevent possible overwriting of in-flight > headers (suggested by AI). [...] > netdev_tx_t bnxt_sw_udp_gso_xmit(struct bnxt *bp, > struct bnxt_tx_ring_info *txr, > struct netdev_queue *txq, > struct sk_buff *skb) > { [...] > + > + /* BD backpressure alone cannot prevent overwriting in-flight > + * headers in the inline buffer. Check slot availability directly. > + */ > + slots = txr->tx_inline_prod - txr->tx_inline_cons; > + slots = BNXT_SW_USO_MAX_SEGS - slots; > + > + if (unlikely(slots < num_segs)) { > + netif_txq_try_stop(txq, slots, num_segs); > + return NETDEV_TX_BUSY; This is the check I added. AI says this is wrong and netdev_queues.h says: * @get_desc must be a formula or a function call, it must always * return up-to-date information when evaluated! which I obviously failed to do, so I'm pretty sure I got this wrong.